> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
Tejesh R has updated the pull request incrementally with two additional commits
since the last revision:
- Updated based on review comments
- Updated based on review comments
-
Changes:
- all:
On Wed, 10 May 2023 16:41:55 GMT, Damon Nguyen wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/java/awt/Robot/RobotMoveMultiscreen.java line 81:
>
>> 79:
On Tue, 9 May 2023 22:09:26 GMT, Alexander Zvegintsev
wrote:
> > I want to work through the scenarios and how much of it is specific to the
> > behaviours of the API you are using and so forth. Since you use the
> > Preferences API for saving the token, if you keyed it off the Robot class
>
On Wed, 10 May 2023 19:23:39 GMT, Phil Race wrote:
>> I agree, I'll try to come up with something less confusing.
>
> If there's no exception, how does the application know the colours aren't
> valid ?
> I think throwing the exception should be preferred behaviour and undefined
> colours would
On Wed, 10 May 2023 17:13:13 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Build hotspot libjvm.a and JDK static libraries for
On Wed, 10 May 2023 20:54:26 GMT, Harshitha Onkar wrote:
>> Which part is a Util method? I see a JRobot method. Or is Util and JRobot
>> linked somehow? My understanding is that they're separate since they're
>> separate in regtesthelpers.
>
> @DamonGuy 'clickMouseOn()'. Earlier this test had
On Wed, 10 May 2023 20:38:50 GMT, Jiangli Zhou wrote:
> > This change caused all our builds but Linux to fail. Did you verify on
> > other platforms than Linux at all? I see you have GHA turned off.
>
> Sorry about the issue. There were failed workflows after I merged with the
> latest JDK
On Wed, 10 May 2023 19:20:48 GMT, Phil Race wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - rephrase wording about mouse pointer may not visually move
>> - Remove mention of mouse cursor for screen
> We need to relax the java.awt.Robot specification according to the latest
> operating system trends.
> This should at least cover the case of Wayland, which has changed many
> familiar concepts in Linux.
>
> https://bugs.openjdk.org/browse/JDK-8280982 [Wayland] [XWayland]
> java.awt.Robot
On Mon, 8 May 2023 16:23:09 GMT, Damon Nguyen wrote:
>> test/jdk/javax/swing/JMenuItem/bug4839464.java line 220:
>>
>>> 218: // Check mnemonics
>>> 219: int tmpInt = item.getMnemonic();
>>> 220: robo.clickMouseOn(changeMnemonicButton);
>>
>> @DamonGuy Util's JRobot is
On Mon, 8 May 2023 09:33:40 GMT, Abhishek Kumar wrote:
>> This PR is to open source JMenuItem related swing tests.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
On Wed, 10 May 2023 20:24:30 GMT, Erik Joelsson wrote:
> This change caused all our builds but Linux to fail. Did you verify on other
> platforms than Linux at all? I see you have GHA turned off.
Sorry about the issue. There were failed workflows after I merged with the
latest JDK master this
On Mon, 8 May 2023 09:33:40 GMT, Abhishek Kumar wrote:
>> This PR is to open source JMenuItem related swing tests.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
Marked as reviewed by honkar
On Wed, 10 May 2023 17:13:13 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Build hotspot libjvm.a and JDK static libraries for
On Mon, 8 May 2023 09:33:40 GMT, Abhishek Kumar wrote:
>> This PR is to open source JMenuItem related swing tests.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
@prrace Please review.
On Wed, 10 May 2023 13:04:42 GMT, Kevin Rushforth wrote:
>> Updated according to your comments.
>> I still left `revokeScreenCapturePermission` here for now, so that its
>> documentation can be easily compared and aligned with the other
>> documentation changes.
>> After finalization it will
On Wed, 10 May 2023 13:48:20 GMT, Alexander Zvegintsev
wrote:
>> src/java.desktop/share/classes/java/awt/Robot.java line 431:
>>
>>> 429: * to capture screen content, and the required permissions are not
>>> granted,
>>> 430: * then a {@code SecurityException} may be thrown,
>>>
On Wed, 10 May 2023 13:56:56 GMT, Alexander Zvegintsev
wrote:
>> We need to relax the java.awt.Robot specification according to the latest
>> operating system trends.
>> This should at least cover the case of Wayland, which has changed many
>> familiar concepts in Linux.
>>
>>
> Adding some DnD tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fixing timeouts
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13756/files
- new:
On Tue, 9 May 2023 18:56:49 GMT, Rajat Mahajan wrote:
>So, I added this code specifically to have improved rendering for the 25%
>cases, like 125%, 225%, 325% as rendering was a little off f
But why it looks off if the clipRound is used? Does that size scales worse or
does it cut the image at
On Tue, 9 May 2023 17:54:41 GMT, Alisen Chung wrote:
>> Added DnD tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix space, add method on EDT
test/jdk/java/awt/dnd/DropTargetingTest.java line 256:
> 254: }
>
On Tue, 9 May 2023 18:05:39 GMT, Alisen Chung wrote:
>> moving tests to open
>
> Alisen Chung has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Merge branch 'JTREG_TEST_SPRINT3' of github.com:alisenchung/jdk into
> JTREG_TEST_SPRINT3
> -
On Mon, 8 May 2023 18:05:59 GMT, Tejesh R wrote:
>> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Changes
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
>
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> static-libs-image/static-libs-bundles targets; This change
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> static-libs-image/static-libs-bundles targets; This change
On Wed, 3 May 2023 13:34:12 GMT, Erik Joelsson wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle
On Wed, 10 May 2023 14:23:38 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to adjust an `@requires` tag into the proper format.
This pull request has now been integrated.
Changeset: 1bca05ea
Author:Daniel D. Daugherty
URL:
On Wed, 10 May 2023 14:26:48 GMT, Roger Riggs wrote:
>> A trivial fix to adjust an `@requires` tag into the proper format.
>
> Marked as reviewed by rriggs (Reviewer).
@RogerRiggs and @azvegint - Thanks for the lightning fast reviews!
-
PR Comment:
On Wed, 10 May 2023 14:23:38 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to adjust an `@requires` tag into the proper format.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13906#pullrequestreview-1420776595
On Wed, 10 May 2023 14:23:38 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to adjust an `@requires` tag into the proper format.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13906#pullrequestreview-1420777471
A trivial fix to adjust an `@requires` tag into the proper format.
-
Commit messages:
- Fix a bad copy-and-paste.
- 8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg
`@requires` clause
Changes: https://git.openjdk.org/jdk/pull/13906/files
Webrev:
On Wed, 10 May 2023 04:40:31 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - rephrase wording about mouse pointer may not visually move
>> - Remove mention of mouse cursor for
On Wed, 10 May 2023 12:54:37 GMT, Kevin Rushforth wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - rephrase wording about mouse pointer may not visually move
>> - Remove mention of mouse cursor for
> We need to relax the java.awt.Robot specification according to the latest
> operating system trends.
> This should at least cover the case of Wayland, which has changed many
> familiar concepts in Linux.
>
> https://bugs.openjdk.org/browse/JDK-8280982 [Wayland] [XWayland]
> java.awt.Robot
On Tue, 9 May 2023 20:14:56 GMT, Alexander Zvegintsev
wrote:
>>> I do not understand why we need this method.
>>
>> We need it in order to be able to revoke the saved permission.
>>
>> For example, it may be necessary if the user has two monitors, but the user
>> only allowed access to one
On Thu, 4 May 2023 16:26:47 GMT, Alexander Zvegintsev
wrote:
> We need to relax the java.awt.Robot specification according to the latest
> operating system trends.
> This should at least cover the case of Wayland, which has changed many
> familiar concepts in Linux.
>
>
On Tue, 9 May 2023 23:06:23 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle
38 matches
Mail list logo
