Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code

2023-05-12 Thread Kim Barrett
On Fri, 12 May 2023 15:29:32 GMT, Tyler Steele wrote: > I'm not sure if it's been mentioned to you already. As I understand it, we > usually wait for 2 reviews before proceeding with changes unless they are > deemed trivial. Also wait for 24 hours. See https://openjdk.org/guide/#life-of-a-pr

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-12 Thread Kim Barrett
On Fri, 12 May 2023 15:16:36 GMT, Tyler Steele wrote: >> JoKern65 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cosmetic changes > > src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp line 426: > >> 424: // Missing test if instr is commuta

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-12 Thread Kim Barrett
On Fri, 12 May 2023 16:16:01 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Many of those are in the aix or ppc specific codebase and could be addressed >> by small adjustments. >> A l

Integrated: 8307297: Move some DnD tests to open

2023-05-12 Thread Alisen Chung
On Tue, 2 May 2023 17:49:39 GMT, Alisen Chung wrote: > Adding some DnD tests This pull request has now been integrated. Changeset: 3bf38761 Author:Alisen Chung URL: https://git.openjdk.org/jdk/commit/3bf3876185f7b9e7679af3fa22ec20887cd4e498 Stats: 1233 lines in 7 files changed:

Re: RFR: 8307297: Move some DnD tests to open [v6]

2023-05-12 Thread Alisen Chung
> Adding some DnD tests Alisen Chung has updated the pull request incrementally with two additional commits since the last revision: - remove extra robot waits causing timeouts - fix test timeout - Changes: - all: https://git.openjdk.org/jdk/pull/13756/files - new: https://gi

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v7]

2023-05-12 Thread Alexey Ivanov
On Fri, 12 May 2023 19:24:07 GMT, Alisen Chung wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Updated based on review comments >> - Updated based on review comments > > test/jdk/java/awt/ScrollPane/ComponentScrollT

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v7]

2023-05-12 Thread Alisen Chung
On Thu, 11 May 2023 08:22:10 GMT, Tejesh R wrote: >> Open source few AWT ScrollPane related tests. > > Tejesh R has updated the pull request incrementally with two additional > commits since the last revision: > > - Updated based on review comments > - Updated based on review comments test/j

Re: RFR: 8289547 : Update javax/swing/Popup/TaskbarPositionTest.java [v2]

2023-05-12 Thread Alexey Ivanov
On Fri, 12 May 2023 12:26:52 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> Noticed this test case not verifying all the cases which is intended. >> Modified it for improving the coverage for 3 type of popups (menu, context >> menu and combobox). >> >> Evaluating conditions: >> 1

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-12 Thread Tyler Steele
On Fri, 12 May 2023 16:16:01 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Many of those are in the aix or ppc specific codebase and could be addressed >> by small adjustments. >> A l

Re: RFR: 8306638: Open source some AWT tests related to datatransfer and Toolkit

2023-05-12 Thread Damon Nguyen
On Tue, 25 Apr 2023 13:48:16 GMT, Jayathirth D V wrote: > This PR open sources some tests related to AWT datatransfer and Toolkit. test/jdk/java/awt/Toolkit/ToolkitListenerTest/ToolkitListenerTest.java line 64: > 62: EventQueue.invokeAndWait(() -> { > 63: frame = new Frame("

Re: RFR: 8289547 : Update javax/swing/Popup/TaskbarPositionTest.java [v2]

2023-05-12 Thread Harshitha Onkar
On Fri, 12 May 2023 12:26:52 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> Noticed this test case not verifying all the cases which is intended. >> Modified it for improving the coverage for 3 type of popups (menu, context >> menu and combobox). >> >> Evaluating conditions: >> 1

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-12 Thread JoKern65
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk > on AIX , we run into various "warnings as errors". > Many of those are in the aix or ppc specific codebase and could be addressed > by small adjustments. > A lot of those changes are in hotspot, some might be somewhe

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code

2023-05-12 Thread JoKern65
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote: > When using the new xlc17 compiler (based on a recent clang) to build OpenJDk > on AIX , we run into various "warnings as errors". > Many of those are in the aix or ppc specific codebase and could be addressed > by small adjustments. > A lot of

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code

2023-05-12 Thread Tyler Steele
On Fri, 12 May 2023 14:07:26 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Many of those are in the aix or ppc specific codebase and could be addressed >> by small adjustments. >> A l

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code

2023-05-12 Thread Tyler Steele
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote: > When using the new xlc17 compiler (based on a recent clang) to build OpenJDk > on AIX , we run into various "warnings as errors". > Many of those are in the aix or ppc specific codebase and could be addressed > by small adjustments. > A lot of

Re: RFR: 8307779: Relax the java.awt.Robot specification [v4]

2023-05-12 Thread Alexander Zvegintsev
> We need to relax the java.awt.Robot specification according to the latest > operating system trends. > This should at least cover the case of Wayland, which has changed many > familiar concepts in Linux. > > https://bugs.openjdk.org/browse/JDK-8280982 [Wayland] [XWayland] > java.awt.Robot ta

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code

2023-05-12 Thread JoKern65
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote: > When using the new xlc17 compiler (based on a recent clang) to build OpenJDk > on AIX , we run into various "warnings as errors". > Many of those are in the aix or ppc specific codebase and could be addressed > by small adjustments. > A lot of

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code

2023-05-12 Thread Erik Joelsson
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote: > When using the new xlc17 compiler (based on a recent clang) to build OpenJDk > on AIX , we run into various "warnings as errors". > Many of those are in the aix or ppc specific codebase and could be addressed > by small adjustments. > A lot of

Re: RFR: 8289547 : Update javax/swing/Popup/TaskbarPositionTest.java [v2]

2023-05-12 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > Noticed this test case not verifying all the cases which is intended. > Modified it for improving the coverage for 3 type of popups (menu, context > menu and combobox). > > Evaluating conditions: > 1. Not enough space for showing popup downwards(default layout), it should > s

Re: RFR: 8289547 : Update javax/swing/Popup/TaskbarPositionTest.java

2023-05-12 Thread Renjith Kannath Pariyangad
On Fri, 21 Apr 2023 12:58:58 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > Noticed this test case not verifying all the cases which is intended. > Modified it for improving the coverage for 3 type of popups (menu, context > menu and combobox). > > Evaluating conditions: > 1. Not e

RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code

2023-05-12 Thread JoKern65
When using the new xlc17 compiler (based on a recent clang) to build OpenJDk on AIX , we run into various "warnings as errors". Many of those are in the aix or ppc specific codebase and could be addressed by small adjustments. A lot of those changes are in hotspot, some might be somewhere else in

RFR: 8296920: Regression Test DialogOrient.java fails on MacOS

2023-05-12 Thread Prasanta Sadhukhan
Test was failing with PrinterException: Wrong Orientation since printing was done with default orientation. Fix is made to set the printable with correct PageFormat It was not seen prior to [JDK-8262731](https://bugs.openjdk.org/browse/JDK-8262731) probably because the exception was being swall