On Wed, 17 May 2023 16:25:59 GMT, Tejesh R wrote:
>> I technically had 2 questions in the last comment.
>> 1. Can't you just put the contents of `initialize()` in place of line 53?
>> It's the only thing being run.
>> 2. Why are we creating a `Runnable` instance instead of just calling
>> `init
> moving tests to open
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fix robot timeout
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13764/files
- new: https://git.openjdk.org/jdk/pull/13764/files/de4cfd7d..c2
On Wed, 17 May 2023 23:21:59 GMT, Jie Fu wrote:
>> configure --enable-debug
>>
>> error: infinite recursion detected [-Werror=infinite-recursion]
>> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>>
>> configure
>>
>> java.desktop/share/native/libharfbuzz/graph/../hb-ot
On Thu, 18 May 2023 03:15:53 GMT, xpbob wrote:
>> configure --enable-debug
>>
>> error: infinite recursion detected [-Werror=infinite-recursion]
>> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>>
>> configure
>>
>> java.desktop/share/native/libharfbuzz/graph/../hb-ot-
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-common.hh:1161:24:
> error: possibly dangling ref
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-common.hh:1161:24:
> error: possibly dangling ref
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-c
On Wed, 17 May 2023 23:21:59 GMT, Jie Fu wrote:
>> configure --enable-debug
>>
>> error: infinite recursion detected [-Werror=infinite-recursion]
>> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>>
>> configure
>>
>> java.desktop/share/native/libharfbuzz/graph/../hb-ot
On Wed, 17 May 2023 18:49:44 GMT, Phil Race wrote:
>> configure --enable-debug
>>
>> error: infinite recursion detected [-Werror=infinite-recursion]
>> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>>
>> configure
>>
>> java.desktop/share/native/libharfbuzz/graph/../hb
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-c
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-c
On Wed, 17 May 2023 18:49:44 GMT, Phil Race wrote:
> This is a duplicate of https://bugs.openjdk.org/browse/JDK-8307210
I don't think so since it also fixes the build broken due to
`-Werror=infinite-recursion`.
Actually, `-Werror=infinite-recursion` was first introduced in GCC12.
So the build
On Fri, 12 May 2023 09:03:07 GMT, Prasanta Sadhukhan
wrote:
> Test was failing with PrinterException: Wrong Orientation since printing was
> done with default orientation.
> Fix is made to set the printable with correct PageFormat
>
> It was not seen prior to
> [JDK-8262731](https://bugs.open
On Mon, 15 May 2023 17:41:18 GMT, Jiangli Zhou wrote:
> Remove DEF_STATIC_JNI_OnLoad from
> src/java.desktop/linux/native/libjsound/PLATFORM_API_LinuxOS_ALSA_CommonUtils.c.
> src/java.desktop/share/native/libjsound/Platform.c defines
> DEF_STATIC_JNI_OnLoad for libjsound.
This pull request ha
> Added DnD tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fix test timeout
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13759/files
- new: https://git.openjdk.org/jdk/pull/13759/files/6ef6c730..faca0092
On Tue, 2 May 2023 18:12:38 GMT, Alisen Chung wrote:
> Added DnD tests
This pull request has now been integrated.
Changeset: 950c5df8
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/950c5df859c373864ab4e7cf080c38bbd501e54b
Stats: 1780 lines in 6 files changed: 1780 i
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-c
On Mon, 15 May 2023 17:41:18 GMT, Jiangli Zhou wrote:
> Remove DEF_STATIC_JNI_OnLoad from
> src/java.desktop/linux/native/libjsound/PLATFORM_API_LinuxOS_ALSA_CommonUtils.c.
> src/java.desktop/share/native/libjsound/Platform.c defines
> DEF_STATIC_JNI_OnLoad for libjsound.
Thanks for the revie
On Mon, 15 May 2023 17:41:18 GMT, Jiangli Zhou wrote:
> Remove DEF_STATIC_JNI_OnLoad from
> src/java.desktop/linux/native/libjsound/PLATFORM_API_LinuxOS_ALSA_CommonUtils.c.
> src/java.desktop/share/native/libjsound/Platform.c defines
> DEF_STATIC_JNI_OnLoad for libjsound.
LGTM
-
> This is a regression from fix
> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of
> symlink is null in JFileChooser. The fix checks whether the file path is a
> symbolic link using `Files.isSymbolicLink()` method with path as input. In
> windows for specific folders
On Wed, 17 May 2023 16:14:43 GMT, Damon Nguyen wrote:
>> Means you are pointing towards `new Runnable()` within Swing worker thread ?
>> Or you are asking whether `initialize()` has to be in worker thread?
>
> I technically had 2 questions in the last comment.
> 1. Can't you just put the content
On Wed, 17 May 2023 05:25:42 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JFileChooser/FileChooserIPETest.java line 54:
>>
>>> 52: public void run() {
>>> 53: initialize();
>>> 54: }
>>
>> Does this need to be a "Runnable"? Can't initialize()'s contents j
On Mon, 15 May 2023 17:41:18 GMT, Jiangli Zhou wrote:
> Remove DEF_STATIC_JNI_OnLoad from
> src/java.desktop/linux/native/libjsound/PLATFORM_API_LinuxOS_ALSA_CommonUtils.c.
> src/java.desktop/share/native/libjsound/Platform.c defines
> DEF_STATIC_JNI_OnLoad for libjsound.
Could someone also p
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-c
When using the clang compiler to build OpenJDk on Linux, we encounter various
"warnings as errors".
They can be fixed with small changes.
-
Commit messages:
- 8308286 Fix clang warnings in linux code
Changes: https://git.openjdk.org/jdk/pull/14033/files
Webrev: https://webrevs.ope
configure --enable-debug
error: infinite recursion detected [-Werror=infinite-recursion]
193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
configure
java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-common.hh:1161:24:
error: possibly dangling reference to a tempor
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Many of those are in the aix or ppc specific codebase and could be addressed
> by small adjustments.
> A lot of
On Fri, 12 May 2023 16:16:01 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Many of those are in the aix or ppc specific codebase and could be addressed
>> by small adjustments.
>> A l
On Fri, 12 May 2023 16:16:01 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Many of those are in the aix or ppc specific codebase and could be addressed
>> by small adjustments.
>> A l
On Wed, 17 May 2023 11:49:24 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Many of those are in the aix or ppc specific codebase and could be addressed
>> by small adjustments.
>> A l
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Many of those are in the aix or ppc specific codebase and could be addressed
> by small adjustments.
> A lot of those changes are in hotspot, some might be somewhe
On Mon, 15 May 2023 09:52:59 GMT, JoKern65 wrote:
>> Such a fix of adlc is probably out of scope for this change though. We
>> should probably have a separate bug for that.
>
> And what should I use as a workaround meanwhile to get our new compiler
> through?
Now that I understand what the pr
On Tue, 16 May 2023 07:22:44 GMT, Matthias Baesken wrote:
>> I think disabling the warning is fine. Alternatively, we could `#define
>> MIN_INT16 -32768` somewhere or introduce `const int16_t min_int16 =
>> (int16_t)1 << (sizeof(int16_t)*BitsPerByte-1);`. What do you prefer, Kim?
>
> Hi Martin/
On Mon, 15 May 2023 09:34:28 GMT, JoKern65 wrote:
>> src/hotspot/os/aix/os_aix.cpp line 464:
>>
>>> 462: guarantee0(shmid != -1); // Should always work.
>>> 463: // Try to set pagesize.
>>> 464: struct shmid_ds shm_buf = {
>>> {0,0,0,0,0,0,0,0},0,0,0,0,0,0,0,0,0,0,0,0,0,0 };
>
Issue was bug6889007.java was causing a timeout issue on mac system. Although
bug6889007.java fail with small test group with "Wrong cursor type" error, it
could not reproduce bug6884066.java
It might be due to waitForIdle() being called in loop which will be calling
sync() so replaced with de
35 matches
Mail list logo
