Re: RFR: 8306812: Open source several AWT Miscellaneous tests [v4]

2023-05-23 Thread Tejesh R
On Wed, 24 May 2023 02:59:39 GMT, Sergey Bylokhov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/java/awt/Robot/RobotMoveMultiscreen.java line 82: > >> 80: ro

Re: RFR: 8306812: Open source several AWT Miscellaneous tests [v5]

2023-05-23 Thread Tejesh R
> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.org/jdk/pull/13828/file

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v14]

2023-05-23 Thread Tejesh R
> Open source few AWT ScrollPane related tests. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.org/jdk/pull/13621/files - new: https://git.openjdk.o

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v13]

2023-05-23 Thread Tejesh R
On Wed, 24 May 2023 02:56:30 GMT, Sergey Bylokhov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/java/awt/ScrollPane/ScrollPositionIntact.java line 91: > >> 89:

Re: RFR: 8306812: Open source several AWT Miscellaneous tests [v4]

2023-05-23 Thread Tejesh R
On Wed, 24 May 2023 02:58:54 GMT, Sergey Bylokhov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/java/awt/PopupMenu/PopupMenuStayOpen.java line 30: > >> 28: @summary Ch

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-23 Thread Kim Barrett
On Mon, 22 May 2023 07:09:30 GMT, JoKern65 wrote: >> The final suggested change (to direct-value-initialize the object) seems to >> have *not* been made. >> >> However, I think it doesn't matter. The mentioned restriction against being >> non-empty until C23 is not relevant. >> This is C++, n

Re: RFR: 8306812: Open source several AWT Miscellaneous tests [v4]

2023-05-23 Thread Sergey Bylokhov
On Fri, 12 May 2023 05:32:14 GMT, Tejesh R wrote: >> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Updated based on review comments test/jdk/java/

Re: RFR: 8306812: Open source several AWT Miscellaneous tests [v4]

2023-05-23 Thread Sergey Bylokhov
On Fri, 5 May 2023 17:57:33 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/java/awt/Scrollbar/ScrollbarKeyControlTest.java line 61: > >> 59: Sy

Re: RFR: 8306137: Open source several AWT ScrollPane related tests [v13]

2023-05-23 Thread Sergey Bylokhov
On Mon, 22 May 2023 14:36:08 GMT, Tejesh R wrote: >> Open source few AWT ScrollPane related tests. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Updated based on review comments test/jdk/java/awt/ScrollPane/ScrollPositionInt

Re: RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions [v6]

2023-05-23 Thread Sergey Bylokhov
On Thu, 4 May 2023 08:06:11 GMT, Maxim Kartashev wrote: >> Getting bounds of a `GraphicsDevice` and insets of a screen are fairly >> frequent operations. When working over the network (remote X session), those >> can take several *seconds* to complete, introducing repeated freezes even >> when

Integrated: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64

2023-05-23 Thread Daniel D . Daugherty
On Tue, 23 May 2023 20:24:18 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > [JDK-8308716](https://bugs.openjdk.org/browse/JDK-8308716) ProblemList > java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with > genzgc on windows-x64 > [JDK-8308718](

Re: Integrated: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64

2023-05-23 Thread Daniel D . Daugherty
On Tue, 23 May 2023 20:39:02 GMT, Alexander Zvegintsev wrote: >> Trivial fixes to ProblemList some tests: >> [JDK-8308716](https://bugs.openjdk.org/browse/JDK-8308716) ProblemList >> java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with >> genzgc on windows-x64 >> [JDK-830

Re: Integrated: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64

2023-05-23 Thread Alexander Zvegintsev
On Tue, 23 May 2023 20:24:18 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > [JDK-8308716](https://bugs.openjdk.org/browse/JDK-8308716) ProblemList > java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with > genzgc on windows-x64 > [JDK-8308718](

Re: Integrated: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64

2023-05-23 Thread Joe Darcy
On Tue, 23 May 2023 20:24:18 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > [JDK-8308716](https://bugs.openjdk.org/browse/JDK-8308716) ProblemList > java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with > genzgc on windows-x64 > [JDK-8308718](

Integrated: 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64

2023-05-23 Thread Daniel D . Daugherty
Trivial fixes to ProblemList some tests: [JDK-8308716](https://bugs.openjdk.org/browse/JDK-8308716) ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64 [JDK-8308718](https://bugs.openjdk.org/browse/JDK-8308718) ProblemList three mlvm/indy/

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v10]

2023-05-23 Thread Prasanta Sadhukhan
> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() > method which can fail due to missing implementation of equals method in CSS > subclasses. > In this issue, even when two CSS AttributeSet has same 42 font size string > value, Object equality fails. > Fixed by implementi

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v5]

2023-05-23 Thread Alexander Zvegintsev
On Mon, 22 May 2023 22:34:17 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v6]

2023-05-23 Thread Alexander Zvegintsev
> Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use the [X Window System > API](https://en.wikipedia.org/wiki/X_Wi

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v4]

2023-05-23 Thread Tejesh R
> This is a regression from fix > [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of > symlink is null in JFileChooser. The fix checks whether the file path is a > symbolic link using `Files.isSymbolicLink()` method with path as input. In > windows for specific folders

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v8]

2023-05-23 Thread Alexey Ivanov
On Tue, 23 May 2023 08:32:53 GMT, Prasanta Sadhukhan wrote: > The current PR passes regression test along with jtreg/jck tests > The suggested changes above does not pass the regression test I haven't tested the code above, I wrote it off the top of my head right here. Anyway passing tests a

Re: JVM hang with Swing and macOS

2023-05-23 Thread Martin Pernollet
Yep have been away from java and GL for some time hence answering oldest message first, but don't worry I will answer :) That is awesome if you had MESA working on macOS. I am curious how you solved the issue with library loading. If you bumped PanamaGL from Java 19 to 20 that is awesome. I was

Re: JVM hang with Swing and macOS

2023-05-23 Thread Michael Hall
> On May 23, 2023, at 5:54 AM, Martin Pernollet > wrote: > > Hi Philip, > > Thank you a lot for these helpful clarifications. > > You are right, I definitely need to jump on a dedicated OS thread. It is a > pity the -XstartOnFirstThread does not do it. > > We may probably use JOGL's OSXUti

Re: JVM hang with Swing and macOS

2023-05-23 Thread Martin Pernollet
Hi Philip, Thank you a lot for these helpful clarifications. You are right, I definitely need to jump on a dedicated OS thread. It is a pity the -XstartOnFirstThread does not do it. We may probably use JOGL's OSXUtil class that does a good job at handling this already. The only limitation is t

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v8]

2023-05-23 Thread Prasanta Sadhukhan
On Mon, 22 May 2023 10:59:53 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test and fix updated as per review comments > > src/java.desktop/share/classes/javax/swing/text/html/CSS.java li