On Thu, 18 May 2023 23:00:25 GMT, Sergey Bylokhov wrote:
>> Perhaps, this needs additional details. The size of checkbox and radio
>> button is 13 as reported by Theme API for the standard DPI of 96. Being a
>> prime number, 13 doesn't scale well, there's always fractional part unless
>> the s
On Thu, 25 May 2023 17:47:59 GMT, Harshitha Onkar wrote:
> > It saves the images to _the current directory_. When the test is run by
> > jtreg, the current directory is the `scratch` directory.
>
> For me, the generated screenshot was being saved to the test folder, as I was
> running it as st
On Thu, 25 May 2023 21:31:54 GMT, Mikael Vidstedt wrote:
>> Trivial fixes to ProblemList a few tests:
>> [JDK-8308907](https://bugs.openjdk.org/browse/JDK-8308907) ProblemList
>> java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on
>> linux-x64
>> [JDK-8308908](https://bugs.
On Thu, 25 May 2023 21:21:18 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to ProblemList a few tests:
> [JDK-8308907](https://bugs.openjdk.org/browse/JDK-8308907) ProblemList
> java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on
> linux-x64
> [JDK-8308908](https://bugs.
On Thu, 25 May 2023 21:21:18 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to ProblemList a few tests:
> [JDK-8308907](https://bugs.openjdk.org/browse/JDK-8308907) ProblemList
> java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on
> linux-x64
> [JDK-8308908](https://bugs.
Trivial fixes to ProblemList a few tests:
[JDK-8308907](https://bugs.openjdk.org/browse/JDK-8308907) ProblemList
java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java on
linux-x64
[JDK-8308908](https://bugs.openjdk.org/browse/JDK-8308908) ProblemList
javax/sound/sampled/Clip/Clip
On Thu, 25 May 2023 15:04:32 GMT, Kim Barrett wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those ch
On Thu, 25 May 2023 11:24:42 GMT, Alexey Ivanov wrote:
>> @lawrence-andrew
>>
>> Here is a consolidated review and few suggestions -
>>
>> - Firstly, the use of builder pattern for screenshot capability looks well
>> structured and clean. It is easy for extensibility and does not break the
>
On Thu, 25 May 2023 16:29:39 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we n
On Wed, 24 May 2023 03:45:50 GMT, Tejesh R wrote:
>> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
test/jdk/java/
> Modern Linux systems often come with
> [Wayland](https://wayland.freedesktop.org/) by default.
> This comes with some difficulties, and one of them is the inability to get
> screenshots from the system.
> This is because we now use the [X Window System
> API](https://en.wikipedia.org/wiki/X_Wi
On Thu, 25 May 2023 15:18:41 GMT, Kim Barrett wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those ch
On Thu, 25 May 2023 09:14:14 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Some of those are in shared codebase and could be addressed by small
> adjustments.
> A lot of those changes ar
On Thu, 25 May 2023 13:42:29 GMT, Alexey Ivanov wrote:
>>> Since `FileSystemView.isFileSystem` is used in many places for particular
>>> Look and Feel, there might be chances of regression. So how about checking
>>> for shell folder first and if yes then can combine the
>>> `shell.isFileSystem
On Thu, 25 May 2023 11:39:33 GMT, Alexey Ivanov wrote:
>>> I understand that, virtual folders don't have a filesystem path, this is
>>> why `fsv.isFileSystem(f)` should handle this situation. The implementation
>>> of `FileSystemView.isFileSystem` explicitly excludes such files which are
>>> b
On Thu, 25 May 2023 09:14:14 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Some of those are in shared codebase and could be addressed by small
> adjustments.
> A lot of those changes ar
On Thu, 25 May 2023 07:15:10 GMT, Tejesh R wrote:
> Since `FileSystemView.isFileSystem` is used in many places for particular
> Look and Feel, there might be chances of regression. So how about checking
> for shell folder first and if yes then can combine the `shell.isFileSystem()`
> with `isS
On Wed, 24 May 2023 23:07:11 GMT, Harshitha Onkar wrote:
> Here is a consolidated review and few suggestions -
>
> Firstly, the use of builder pattern for screenshot capability looks well
> structured and clean. It is easy for extensibility and does not break the
> existing functionality.
Thi
On Mon, 27 Feb 2023 21:56:28 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add nam
On Tue, 23 May 2023 15:15:29 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we n
On Fri, 28 Apr 2023 21:34:36 GMT, Sergey Bylokhov wrote:
> The description from big to small:
>
> - Our code to handle the image types we support is too generic, the
> LCMSImageLayout class can handle, byte, short, int, and double types, and
> many various properties of the image layout. As a
When using the new xlc17 compiler (based on a recent clang) to build OpenJDk on
AIX , we run into various "warnings as errors".
Some of those are in shared codebase and could be addressed by small
adjustments.
A lot of those changes are in hotspot, some might be somewhere else in the
OpenJDK C/C
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote:
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> rel
On Thu, 25 May 2023 07:16:29 GMT, JoKern65 wrote:
>> That's not what I see in this PR, and not what I see in the repository after
>> the integration. Where are you seeing
>> that? (If in your local repository, maybe you forgot a push to the PR?)
>
> I checked it directly in repository
> [https
On Mon, 22 May 2023 15:55:41 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> Changes requested by aivanov (Reviewer).
@aivanov-jdk The alternative fix validates
> This is a regression from fix
> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of
> symlink is null in JFileChooser. The fix checks whether the file path is a
> symbolic link using `Files.isSymbolicLink()` method with path as input. In
> windows for specific folders
> This is a regression from fix
> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of
> symlink is null in JFileChooser. The fix checks whether the file path is a
> symbolic link using `Files.isSymbolicLink()` method with path as input. In
> windows for specific folders
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote:
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> rel
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote:
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> rel
On Thu, 25 May 2023 07:22:50 GMT, Julian Waters wrote:
> All the changes from long were done since there was conversion from or to a
> jint somewhere down the line,
Okay I see that now. It is a messy situation - at some point the incoming
jint's need to be "converted" to a native type.
--
On Thu, 25 May 2023 01:34:15 GMT, David Holmes wrote:
> I think the JNI type definition change is okay.
>
> However many of the other changes appear to me to not involve Java variables
> and so don't need to be Java types i.e they should be `int` rather than
> `jint` - though as these are nati
On Wed, 24 May 2023 03:13:34 GMT, Kim Barrett wrote:
>> Strange the last resulting change I see is
>> `struct shmid_ds shm_buf{};`
>
> That's not what I see in this PR, and not what I see in the repository after
> the integration. Where are you seeing
> that? (If in your local repository, mayb
On Wed, 24 May 2023 15:48:34 GMT, Alexey Ivanov wrote:
>> I understand that, virtual folders don't have a filesystem path, this is why
>> `fsv.isFileSystem(f)` should handle this situation. The implementation of
>> `FileSystemView.isFileSystem` explicitly excludes such files which are both
>>
33 matches
Mail list logo
