Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v5]

2023-06-12 Thread Harshitha Onkar
On Wed, 7 Jun 2023 20:48:20 GMT, Harshitha Onkar wrote: >> ViewportOverlapping test was failing intermittently during CI runs on Win10 >> and Win11. >> >> Although this intermittent issue wasn't replicable when the individual test >> as well as the test group was run multiple times. Hence scr

Integrated: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11

2023-06-12 Thread Harshitha Onkar
On Fri, 2 Jun 2023 17:56:42 GMT, Harshitha Onkar wrote: > ViewportOverlapping test was failing intermittently during CI runs on Win10 > and Win11. > > Although this intermittent issue wasn't replicable when the individual test > as well as the test group was run multiple times. Hence screensh

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 22:17:25 GMT, Eirik Bjorsnos wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 'main.help.opt.any.file' value for _de > > src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_de.propertie

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-12 Thread Justin Lu
> Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the original file's changes in UTF-8 > native. Those fil

Re: RFR: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. [v2]

2023-06-12 Thread Alisen Chung
> added displayChanged call to CPlatformWindow when frame first needs to > deiconify or unmaximize > All client tests passed after change Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: use realsync to flush native queue ---

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Eirik Bjorsnos
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
Please review this PR which updates the JDK's localized resources since the previous L10n translation drop (1/26). To help with reviewing the changes, @jonathan-gibbons created a tool which displays the localized changes next to the original file's changes in UTF-8 native. Those files can be vi

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 21:42:24 GMT, Kevin Rushforth wrote: >> @prrace @jonathan-gibbons @pavelrappo @lahodaj @wangweij @igraves >> @AlanBateman @eirbjo could you please review the modules / changes you are >> familiar with, thank you. > > @justin-curtis-lu Unless there is a strong reason to do ot

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Kevin Rushforth
On Mon, 12 Jun 2023 21:27:05 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

RFR: 8309756: Occasional crashes with pipewire screen capture on Wayland

2023-06-12 Thread Phil Race
This fix seems to resolve some occasional crashes in our usage of pipewire for Wayland screen capture. See the bug report for more information. - Commit messages: - 8309756 Changes: https://git.openjdk.org/jdk/pull/14428/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14428

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

RFR: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-12 Thread Justin Lu
Please review this PR which updates the JDK's localized resources since the previous L10n translation drop (1/26). To help with reviewing the changes, @jonathan-gibbons created a tool which displays the localized changes next to the original file's changes in UTF-8 native. Those files can be vi

Re: RFR: JDK-8294427 - Check boxes and radio buttons have rendering issues on Windows in High DPI env [v14]

2023-06-12 Thread Alexey Ivanov
On Mon, 12 Jun 2023 20:38:40 GMT, Sergey Bylokhov wrote: > > There's always a mismatch (at this time). We already discussed it > > [above](https://github.com/openjdk/jdk/pull/13701#discussion_r1195604571). > > > > For example, for 125% scale, Windows returns 13×13 like for 100%; yet Swing > > e

Re: RFR: JDK-8294427 - Check boxes and radio buttons have rendering issues on Windows in High DPI env [v14]

2023-06-12 Thread Sergey Bylokhov
On Mon, 12 Jun 2023 19:59:00 GMT, Alexey Ivanov wrote: >> II am not sure that is correct way to calculate the dpi based on the "adhoc" >> change of the image size. That will add the mismatch between the code where >> we create the image, and the code where we request the image. We probably >>

Re: RFR: JDK-8294427 - Check boxes and radio buttons have rendering issues on Windows in High DPI env [v14]

2023-06-12 Thread Alexey Ivanov
On Mon, 8 May 2023 18:46:42 GMT, Alexey Ivanov wrote: >>> It may be useful to be able to run Java on previous versions though, yet >>> it's not a priority. >> >> Then probably it is better to add a fallback since that method was added to >> the win 10 after GA, and it does not exist in the ear

Re: RFR: JDK-8294427 - Check boxes and radio buttons have rendering issues on Windows in High DPI env [v14]

2023-06-12 Thread Alexey Ivanov
On Sat, 10 Jun 2023 01:20:36 GMT, Sergey Bylokhov wrote: > II am not sure that is correct way to calculate the dpi based on the "adhoc" > change of the image size. That will add the mismatch between the code where > we create the image, and the code where we request the image. There's always a

Re: RFR: JDK-8294427 - Check boxes and radio buttons have rendering issues on Windows in High DPI env [v14]

2023-06-12 Thread Rajat Mahajan
> Problem: > > Check boxes and radio buttons in Windows Look-and-Feel have rendering issues > when window is moved from display with one scale to display with a different > scale on a multi-monitor setup: > > - Scrawly ticks in checkboxes; > - Wrong circle relations in selected radio buttons. >

Re: RFR: JDK-8299052 : ViewportOverlapping test fails intermittently on Win10 & Win11 [v5]

2023-06-12 Thread Alexey Ivanov
On Wed, 7 Jun 2023 20:48:20 GMT, Harshitha Onkar wrote: >> ViewportOverlapping test was failing intermittently during CI runs on Win10 >> and Win11. >> >> Although this intermittent issue wasn't replicable when the individual test >> as well as the test group was run multiple times. Hence scr

Integrated: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-12 Thread Jiangli Zhou
On Fri, 19 May 2023 20:18:53 GMT, Jiangli Zhou wrote: > Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Buil

Re: RFR: 8309703: AIX build fails after JDK-8280982

2023-06-12 Thread Matthias Baesken
On Mon, 12 Jun 2023 14:13:15 GMT, Matthias Baesken wrote: > 8309703: AIX build fails after JDK-8280982 Hi Martin, thanks for the review ! - PR Comment: https://git.openjdk.org/jdk21/pull/8#issuecomment-1587485013

Integrated: 8309703: AIX build fails after JDK-8280982

2023-06-12 Thread Matthias Baesken
On Mon, 12 Jun 2023 14:13:15 GMT, Matthias Baesken wrote: > 8309703: AIX build fails after JDK-8280982 This pull request has now been integrated. Changeset: 005006e7 Author:Matthias Baesken URL: https://git.openjdk.org/jdk21/commit/005006e7c4bc9d59f3110b5f26362444b2bd214a Stats:

Re: RFR: 8309703: AIX build fails after JDK-8280982

2023-06-12 Thread Martin Doerr
On Mon, 12 Jun 2023 14:13:15 GMT, Matthias Baesken wrote: > 8309703: AIX build fails after JDK-8280982 This is a must have for JDK 21. Fixes AIX build. Low risk because code is protected by ifdefs and change is small. - Marked as reviewed by mdoerr (Reviewer). PR Review: https://

RFR: 8309703: AIX build fails after JDK-8280982

2023-06-12 Thread Matthias Baesken
8309703: AIX build fails after JDK-8280982 - Commit messages: - Backport 3981297fd34a628dff44898e6c60455cf071741a Changes: https://git.openjdk.org/jdk21/pull/8/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=8&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309703

Re: RFR: 8308286 Fix clang warnings in linux code [v5]

2023-06-12 Thread Erik Joelsson
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request with a new target base due to a > merge or a r

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v4]

2023-06-12 Thread Tejesh R
On Mon, 12 Jun 2023 10:40:03 GMT, Tejesh R wrote: >> When a frame is dragged from one screen to another screen, the >> `GraphicsConfigurations` may vary depending on screen/monitor. However, >> transparency has to be maintained since it is expected as it is set. So the >> fix addresses in main

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v4]

2023-06-12 Thread Tejesh R
> When a frame is dragged from one screen to another screen, the > `GraphicsConfigurations` may vary depending on screen/monitor. However, > transparency has to be maintained since it is expected as it is set. So the > fix addresses in maintaining the translucency capability when frame is moved

Integrated: 4516654: Metalworks Demo: Window title not displayed fully in Low Vision Theme

2023-06-12 Thread Prasanta Sadhukhan
On Wed, 7 Jun 2023 06:55:27 GMT, Prasanta Sadhukhan wrote: > In Metalworks demo in Low Vision theme, window title is not diplayed fully in > this theme. The first letter of the title, that is letter "M", is cut > vertically > > ![image](https://github.com/openjdk/jdk/assets/43534309/b122787c-

Integrated: JDK-8309703: AIX build fails after JDK-8280982

2023-06-12 Thread Matthias Baesken
On Fri, 9 Jun 2023 10:12:57 GMT, Matthias Baesken wrote: > After > [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982): [Wayland] > [XWayland] java.awt.Robot taking screenshots > the AIX build fails. > We get > > * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o: