Re: RFR: JDK-8294427 - Check boxes and radio buttons have rendering issues on Windows in High DPI env [v16]

> Problem: > > Check boxes and radio buttons in Windows Look-and-Feel have rendering issues > when window is moved from display with one scale to display with a different > scale on a multi-monitor setup: > > - Scrawly ticks in checkboxes; > - Wrong circle relations in selected radio buttons. >

Re: RFR: 8308780: Fix the Java Integer types on Windows [v11]

On Fri, 23 Jun 2023 02:38:13 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

On Thu, 22 Jun 2023 09:58:19 GMT, Daniel Jeliński wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241: > >> 239: DISABLED_WARNINGS_

Re: RFR: 8308780: Fix the Java Integer types on Windows [v4]

On Thu, 8 Jun 2023 11:20:05 GMT, Alexey Ivanov wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix the code that is actually warning > > I'll take a look… hopefully next week. Wait a minute, I was right, it was a

JDK-6196792 Image.getScaledInstance

The performance of Image.getScaledInstance() has been known to be a problem for a long time. (This ticket discusses it well. It has a complicated history.) I have developed code that is muc

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v7]

On Fri, 23 Jun 2023 04:52:45 GMT, Tejesh R wrote: >> We have a couple of places where we call "setGraphicsConfiguration(null)", >> previously that sets the default GC, now it will set the null, can we try to >> trigger that codepath and check how it will work? > > Removing a Component will call

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v7]

On Thu, 22 Jun 2023 18:36:26 GMT, Sergey Bylokhov wrote: >> Yeah, have tested in CI multiple time and also few manual dual screen >> related test. No regression found with fix. > > We have a couple of places where we call "setGraphicsConfiguration(null)", > previously that sets the default GC,

Re: RFR: 8140527: JInternalFrame has incorrect title button width [v3]

On Thu, 22 Jun 2023 20:35:45 GMT, Alexey Ivanov wrote: > > > I wonder if the values stored in the UI Manager should have this trick > > > applied rather tweaking the values on the fly. If a programmer gets the > > > values from `UIManager` directly, they will get the incorrect value. > > > >

Re: RFR: 8140527: JInternalFrame has incorrect title button width [v3]

On Thu, 22 Jun 2023 20:27:44 GMT, Alexey Ivanov wrote: >> It can be removed in the strict sense but we need something to initialise it >> to so kept it as it is, as it will do no harm > >> It can be removed in the strict sense but we need something to initialise it >> to so kept it as it is, as

Re: RFR: 8140527: JInternalFrame has incorrect title button width [v3]

> Title buttons under Widows Classic L&F got their sizes from the XP desktop > theme in which button width can be bigger than height. It is construed as XP > bug where sizes aren't updated properly so it uses height units for width for > XP and later windows. The proposed fix uses the [same > t

Re: RFR: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key. [v2]

On Thu, 22 Jun 2023 21:17:53 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Formatting > > test/jdk/javax/swing/JTable/JLayerTableTest.java line 57: > >> 55: @Override publi

Re: RFR: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key. [v2]

> If a JTable is wrapped in JLayer and first row is selected and VK_PAGE_DOWN > is pressed, the last row of the table is selected instead of the next row > after current viewport. > This is because table.getParent.getSize() returns the whole table size > whereas it should be the JViewport which

Re: RFR: 8308780: Fix the Java Integer types on Windows [v11]

> On Windows, the basic Java Integer types are defined as long and __int64 > respectively. In particular, the former is rather problematic since it breaks > compilation as the Visual C++ becomes stricter and more compliant with every > release, which means the way Windows code treats long as a t

Re: RFR: 8308780: Fix the Java Integer types on Windows [v10]

On Fri, 23 Jun 2023 00:31:28 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308780: Fix the Java Integer types on Windows [v10]

On Fri, 23 Jun 2023 00:31:28 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308780: Fix the Java Integer types on Windows [v10]

> On Windows, the basic Java Integer types are defined as long and __int64 > respectively. In particular, the former is rather problematic since it breaks > compilation as the Visual C++ becomes stricter and more compliant with every > release, which means the way Windows code treats long as a t

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 22 Jun 2023 19:51:42 GMT, Alexey Ivanov wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert "GetDIBits should take an LPVOID" >> >> This reverts commit 7dbe5dea84b1afb2235b66da581bcd3c1da4d6ac. > >

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 22 Jun 2023 19:24:29 GMT, Alexey Ivanov wrote: >> src/java.desktop/windows/native/libawt/java2d/windows/GDIRenderer.cpp line >> 605: >> >>> 603: return; >>> 604: } >>> 605: jint sx, sy, ex, ey; >> >> Again these don't seem to need to be Java types. > > I've got the same

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 22 Jun 2023 19:20:09 GMT, Alexey Ivanov wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert "GetDIBits should take an LPVOID" >> >> This reverts commit 7dbe5dea84b1afb2235b66da581bcd3c1da4d6ac. > >

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 22 Jun 2023 19:37:56 GMT, Alexey Ivanov wrote: >> src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 1084: >> >>> 1082: >>> 1083: jint *colorBits = nullptr; >>> 1084: int *maskBits = nullptr; >> >> Suggestion: >> >> jint *colorBits

Re: RFR: 8310054: ScrollPane insets are incorrect

On Wed, 14 Jun 2023 20:17:32 GMT, Alexey Ivanov wrote: > After the size of `ScrollPane` child component changes, it recalculates the > size of the scroll bars and hides or shows them as necessary. This situation > is handled in `WScrollPanePeer.childResized`: > > https://github.com/openjdk/jdk

Re: RFR: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.

On Thu, 22 Jun 2023 13:47:56 GMT, Prasanta Sadhukhan wrote: > If a JTable is wrapped in JLayer and first row is selected and VK_PAGE_DOWN > is pressed, the last row of the table is selected instead of the next row > after current viewport. > This is because table.getParent.getSize() returns th

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Thu, 22 Jun 2023 18:45:27 GMT, Alexander Zuev wrote: >> src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java line 185: >> >>> 183: // Do send check box state changes to native side >>> 184: if (thisRole == AccessibleRole.CHECK_BOX) { >>> 18

Re: RFR: 8140527: JInternalFrame has incorrect title button width [v2]

On Thu, 22 Jun 2023 03:39:00 GMT, Prasanta Sadhukhan wrote: > > I wonder if the values stored in the UI Manager should have this trick > > applied rather tweaking the values on the fly. If a programmer gets the > > values from `UIManager` directly, they will get the incorrect value. > > OK. U

Re: RFR: 8140527: JInternalFrame has incorrect title button width [v2]

On Thu, 22 Jun 2023 03:44:19 GMT, Prasanta Sadhukhan wrote: >> Title buttons under Widows Classic L&F got their sizes from the XP desktop >> theme in which button width can be bigger than height. It is construed as XP >> bug where sizes aren't updated properly so it uses height units for width

Re: RFR: 8140527: JInternalFrame has incorrect title button width [v2]

On Thu, 22 Jun 2023 03:35:57 GMT, Prasanta Sadhukhan wrote: > It can be removed in the strict sense but we need something to initialise it > to so kept it as it is, as it will do no harm Why does it need anything to initialise? The value is now set in either `if` or `else` branch. It does no

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Thu, 22 Jun 2023 18:46:51 GMT, Artem Semenov wrote: > Is it possible to add a regression test on these components? to > `test/jdk/java/awt/a11y` Not within this regression type fix unless i find a way to write an automatic regression test which i don't see a way of. As of creating a compreh

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 22 Jun 2023 19:33:17 GMT, Alexey Ivanov wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert "GetDIBits should take an LPVOID" >> >> This reverts commit 7dbe5dea84b1afb2235b66da581bcd3c1da4d6ac. > >

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 25 May 2023 01:30:34 GMT, David Holmes wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert "GetDIBits should take an LPVOID" >> >> This reverts commit 7dbe5dea84b1afb2235b66da581bcd3c1da4d6ac. > >

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 22 Jun 2023 14:40:23 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v2]

On Mon, 19 Jun 2023 08:41:48 GMT, Abhishek Kumar wrote: >> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line >> 162: >> >>> 160: AccessibleContext ac = this.getAccessibleContext(); >>> 161: if (ac != null && (comboBox.getSelectedItem() != null))

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v2]

On Mon, 19 Jun 2023 09:27:01 GMT, Abhishek Kumar wrote: >> The issue exist only for non-editable combobox and the root cause is >> accessible object is not created due to incorrect index returned from >> component class which results in no a11y API invoked. >> >> Proposed solution is to return

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Thu, 22 Jun 2023 18:44:00 GMT, Sergey Bylokhov wrote: >> Only pass value changed event to the native accessibility peer when the >> value is actually changed. While at fixing it for RadioButton also fixing it >> for checkbox and toggle button so there is no need to re-visit this file >> lat

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v7]

On Fri, 16 Jun 2023 08:09:36 GMT, Tejesh R wrote: >> src/java.desktop/share/classes/java/awt/Window.java line 3223: >> >>> 3221: getDefaultScreenDevice(). >>> 3222: getDefaultConfiguration(); >>> 3223: } >> >> It looks like `gc` was always not nul

Re: RFR: 8308286 Fix clang warnings in linux code [v7]

> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all:

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

On Thu, 22 Jun 2023 09:58:49 GMT, Daniel Jeliński wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 260: > >> 258: DISABLED_WARNINGS_clang_ai

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Thu, 22 Jun 2023 15:41:47 GMT, Alexander Zuev wrote: > > Should VO announce radiobutton's position also? > > That is beyond the scope of this bug but overall i would look at the native > applications with the same type of controls. If native controls do not > demonstrate the same behavior t

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Wed, 21 Jun 2023 20:37:01 GMT, Alexander Zuev wrote: > Only pass value changed event to the native accessibility peer when the value > is actually changed. While at fixing it for RadioButton also fixing it for > checkbox and toggle button so there is no need to re-visit this file later. > Al

Re: RFR: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

On Thu, 22 Jun 2023 05:27:43 GMT, Abhishek Kumar wrote: > Should VO announce radiobutton's position also? That is beyond the scope of this bug but overall i would look at the native applications with the same type of controls. If native controls do not demonstrate the same behavior then i woul

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 22 Jun 2023 14:40:23 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

On Thu, 22 Jun 2023 14:40:23 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308780: Fix the Java Integer types on Windows [v9]

> On Windows, the basic Java Integer types are defined as long and __int64 > respectively. In particular, the former is rather problematic since it breaks > compilation as the Visual C++ becomes stricter and more compliant with every > release, which means the way Windows code treats long as a t

Re: RFR: 8308780: Fix the Java Integer types on Windows [v8]

On Thu, 22 Jun 2023 14:23:25 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308780: Fix the Java Integer types on Windows [v7]

On Thu, 22 Jun 2023 14:16:28 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308780: Fix the Java Integer types on Windows [v8]

> On Windows, the basic Java Integer types are defined as long and __int64 > respectively. In particular, the former is rather problematic since it breaks > compilation as the Visual C++ becomes stricter and more compliant with every > release, which means the way Windows code treats long as a t

Re: RFR: JDK-8310550: Adjust references to rt.jar

On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote: > There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. src/java.sql/share/classes/java/sql/DriverManager.java line 658: > 656: * (which is invoking this class

Re: RFR: 8308780: Fix the Java Integer types on Windows [v7]

> On Windows, the basic Java Integer types are defined as long and __int64 > respectively. In particular, the former is rather problematic since it breaks > compilation as the Visual C++ becomes stricter and more compliant with every > release, which means the way Windows code treats long as a t

Re: RFR: 8308780: Fix the Java Integer types on Windows [v6]

On Thu, 22 Jun 2023 14:05:15 GMT, Julian Waters wrote: >> I'm currently running version 13.1, win32 threads > > I'll retry again, maybe the warning has changed now Seems like it doesn't trigger any longer, I'll revert the cast. Thanks for catching this - PR Review Comment: https:/

Re: RFR: 8308780: Fix the Java Integer types on Windows [v6]

On Thu, 22 Jun 2023 14:04:48 GMT, Julian Waters wrote: >> Which gcc? This code compiles without warnings: >> >> #include >> int main() { >> unsigned long i = 1; >> long j = 2; >> printf("%ld %ld %lx %lx %lu %lu\n", i, j, i, j, i, j); >> return 0; >> } >> >> >> # gcc -Wall

Re: RFR: 8308780: Fix the Java Integer types on Windows [v6]

On Thu, 22 Jun 2023 13:48:53 GMT, Julian Waters wrote: >> src/jdk.accessibility/windows/native/jaccesswalker/jaccesswalker.cpp line >> 547: >> >>> 545: snprintf( s, sizeof(s), >>> 546: "ERROR calling GetAccessibleContextInfo; vmID = %lX, >>> context = %p", >>> 547:

Re: RFR: 8308780: Fix the Java Integer types on Windows [v6]

On Thu, 22 Jun 2023 14:03:26 GMT, Daniel Jeliński wrote: >> gcc will crash with a warning about a mismatched format specifier between >> signed and unsigned if this isn't done, unfortunately > > Which gcc? This code compiles without warnings: > > #include > int main() { > unsigned long i

RFR: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.

If a JTable is wrapped in JLayer and first row is selected and VK_PAGE_DOWN is pressed, the last row of the table is selected instead of the next row after current viewport. This is because table.getParent.getSize() returns the whole table size whereas it should be the JViewport which size shoul

Re: RFR: 8308780: Fix the Java Integer types on Windows [v6]

On Thu, 22 Jun 2023 10:37:11 GMT, Daniel Jeliński wrote: >> Julian Waters has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new

client-libs-dev@openjdk.org

On Thu, 22 Jun 2023 04:53:21 GMT, Tejesh R wrote: > Ok, in summary there exists 2 major issues: Yes. > 1. The text should positioned till the blue-ish pixels is just behind the > header border for each header cell. Let's focus on this one here. Position the text so that it touches the shadow

Re: RFR: 8308780: Fix the Java Integer types on Windows [v6]

On Thu, 22 Jun 2023 03:00:16 GMT, Julian Waters wrote: >> On Windows, the basic Java Integer types are defined as long and __int64 >> respectively. In particular, the former is rather problematic since it >> breaks compilation as the Visual C++ becomes stricter and more compliant >> with every

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

On Thu, 22 Jun 2023 09:13:21 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sin

Re: RFR: JDK-8310550: Adjust references to rt.jar

On Wed, 21 Jun 2023 21:46:03 GMT, David Holmes wrote: >> There are a few references to rt.jar in comments and in the codebase itself. >> Some of them might be removed or adjusted. > > src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java > line 196: > >> 194: >> 195:

Re: RFR: 8308286 Fix clang warnings in linux code [v5]

On Wed, 21 Jun 2023 07:35:16 GMT, Daniel Jeliński wrote: >> Artem Semenov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains five commits: >> >> - update >> - update >> - update >> - update >> - 8308286 Fix clang warnings in lin

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all:

[jdk21] Integrated: 8310187: Improve Generational ZGC jtreg testing

On Tue, 20 Jun 2023 11:17:40 GMT, Axel Boldt-Christmas wrote: > Hi all, > > This pull request contains a backport of commit > [a0595761](https://github.com/openjdk/jdk/commit/a0595761ef35c4eec8cb84326a869b9473cd5bba) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The c