On Thu, 6 Jul 2023 08:28:22 GMT, Tejesh R wrote:
>> The header border uses `g.drawLine` whereas the JTable data grid lines uses
>> `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
>> horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect`
>> which contrib
On Wed, 14 Jun 2023 12:43:18 GMT, Prasanta Sadhukhan
wrote:
> Trying to iterate for HEAD HTML tag or for any other "Block" Tag results in
> NPE due to some spurious unhandled code which just return NULL.
> Removing the code solves this problem and also does not cause any regression
> in client
That would be nice but I suspect it would not be easy to get agreement
on that.
At least the dev guide also says "Some teams may require more Reviewers."
https://openjdk.org/guide/#fixing-a-bug
And it recommends 24 business hrs as well ..
"In general all PRs should be open for at least 24 hour
I think it would be less confusing all around to have a general requirement
for 2 reviewers across the whole OpenJDK.
On Thu, Jul 13, 2023 at 5:28 PM Philip Race wrote:
> Please see "Code Reviews" on the Group page
> https://openjdk.org/groups/client-libs/ where it says
>
> The Java Client Libra
On Wed, 5 Jul 2023 23:19:39 GMT, Liam Miller-Cushon wrote:
> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to
> use the reported length of the segment instead of assuming it's always
> exactly 14 bytes.
This pull request has now been integrated.
Changeset: c7c6d47a
On Thu, 13 Jul 2023 05:13:45 GMT, Sergey Bylokhov wrote:
> * Added @throws IllegalArgumentException to the specification of
> java.awt.color.ColorSpace.getInstance(int)
> * Deleted duplicate text about IllegalArgumentException from the
> java.awt.color.ICC_Profile.getInstance(int)
Marked as re
On Tue, 11 Jul 2023 15:54:56 GMT, Liam Miller-Cushon wrote:
>> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to
>> use the reported length of the segment instead of assuming it's always
>> exactly 14 bytes.
>
> Liam Miller-Cushon has updated the pull request increment
* Added @throws IllegalArgumentException to the specification of
java.awt.color.ColorSpace.getInstance(int)
* Deleted duplicate text about IllegalArgumentException from the
java.awt.color.ICC_Profile.getInstance(int)
-
Commit messages:
- 6211202: ColorSpace.getInstance(int): IAE is
Please see "Code Reviews" on the Group page
https://openjdk.org/groups/client-libs/ where it says
The Java Client Library Group has always standardized on two approvals -
where at least one must have the Reviewer role.
Historically this was addressed entirely by social conventions but today
the
On Tue, 16 May 2023 17:56:04 GMT, Artem Semenov wrote:
>> This enhancement covers basic API and shared code that should be implemented
>> for the Accessibility Announcement feature.
>>
>> CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499
>> "bugs.openjdk.org")
>>
>> @mrserb @prrac
On Wed, 12 Jul 2023 07:07:05 GMT, Matthias Baesken wrote:
> There is a MAP_FAILED definition in
> src/java.desktop/unix/native/common/awt/fontpath.c but it is never used in
> the coding and seems to be obsolete.
This pull request has now been integrated.
Changeset: a38a421f
Author:Matthia
On Wed, 12 Jul 2023 07:07:05 GMT, Matthias Baesken wrote:
> There is a MAP_FAILED definition in
> src/java.desktop/unix/native/common/awt/fontpath.c but it is never used in
> the coding and seems to be obsolete.
Hi Phil, thanks for the review !
-
PR Comment: https://git.openjdk.o
12 matches
Mail list logo
