Re: RFR: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left [v2]

2023-07-20 Thread Damon Nguyen
On Fri, 21 Jul 2023 03:56:03 GMT, Tejesh R wrote: >> Popup menu is created on mouse click, hence the orientation for FileChooser >> won't apply to the popup menu created. Hence the fix address the issue by >> applying the FileChooser orientation when it is created on mouse operation >> (Right

Re: RFR: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left [v2]

2023-07-20 Thread Tejesh R
On Fri, 21 Jul 2023 03:39:53 GMT, Tejesh R wrote: >> test/jdk/javax/swing/JFileChooser/FCPopupMenuOrientationTest.java line 51: >> >>> 49: UIManager.getInstalledLookAndFeels()) { >>> 50: String className = laf.getName().toLowerCase(); >>> 51:

Re: RFR: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left [v2]

2023-07-20 Thread Tejesh R
> Popup menu is created on mouse click, hence the orientation for FileChooser > won't apply to the popup menu created. Hence the fix address the issue by > applying the FileChooser orientation when it is created on mouse operation > (Right Click). > The test does not apply to Motif and Aqua Loo

Re: RFR: JDK-8302618: [macOS] Problem typing uppercase letters with java.awt.Robot when moving mouse [v7]

2023-07-20 Thread Sergey Bylokhov
On Mon, 17 Jul 2023 23:53:16 GMT, Harshitha Onkar wrote: >I don't think it is applicable for mouse clicks, as the issue (details below) >occurs only when flagState is obtained using - >CGEventSourceFlagsState(kCGEventSourceStateHIDSystemState) which was the case >for keyEvents. I can double-ch

Re: RFR: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left

2023-07-20 Thread Tejesh R
On Fri, 21 Jul 2023 03:32:58 GMT, Sergey Bylokhov wrote: >> Popup menu is created on mouse click, hence the orientation for FileChooser >> won't apply to the popup menu created. Hence the fix address the issue by >> applying the FileChooser orientation when it is created on mouse operation >>

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-20 Thread Sergey Bylokhov
On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization libr

Re: RFR: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left

2023-07-20 Thread Sergey Bylokhov
On Thu, 20 Jul 2023 09:40:41 GMT, Tejesh R wrote: > Popup menu is created on mouse click, hence the orientation for FileChooser > won't apply to the popup menu created. Hence the fix address the issue by > applying the FileChooser orientation when it is created on mouse operation > (Right Clic

Re: RFR: 8280482: Window transparency bug on Linux [v2]

2023-07-20 Thread Alexander Zvegintsev
On Thu, 20 Jul 2023 17:32:13 GMT, Tejesh R wrote: > shows same for all the windows, either in primary/secondary monitor. For me it is not true: [GCBounds.java.txt](https://github.com/openjdk/jdk/files/12113425/GCBounds.java.txt) > Screen bounds java.awt.Rectangle[x=0,y=0,width=2560,height=1440

Re: RFR: 8280482: Window transparency bug on Linux [v2]

2023-07-20 Thread Tejesh R
On Thu, 20 Jul 2023 12:46:39 GMT, Alexander Zvegintsev wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix > > test/jdk/java/awt/Multiscreen/MultiScreenCheckScreenIDTest.java line 128: > >> 126:

Re: RFR: 8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS

2023-07-20 Thread Alexander Zvegintsev
On Thu, 20 Jul 2023 15:52:37 GMT, Sergey Bylokhov wrote: > Both bugs mentioned in the problemlist do not have any references/logs about > macos x64 please attach it. It does not differ from the jtr file from windows attached to 7099223, but I added in a comment. As for the 8274106, I have no l

Withdrawn: JDK-8292276 : Add named colors from CSS Color Module Level 4

2023-07-20 Thread duke
On Wed, 10 Aug 2022 20:00:29 GMT, ScientificWare wrote: > This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named col

Withdrawn: JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color

2023-07-20 Thread duke
On Fri, 16 Sep 2022 23:16:19 GMT, ScientificWare wrote: > This is referenced in Java Bug Database as > - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded > Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776) > > This is tracked in JBS as > - [JDK-8293776 : Adds CSS 4 and 8 dig

Re: RFR: 8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS

2023-07-20 Thread Sergey Bylokhov
On Thu, 20 Jul 2023 13:17:48 GMT, Alexander Zvegintsev wrote: > This test fails in macOS 13, making the CI noise. Both bugs mentioned in the problemlist do not have any references/logs about macos x64 please attach it. - PR Comment: https://git.openjdk.org/jdk/pull/14956#issuecom

Re: RFR: 8280482: Window transparency bug on Linux [v2]

2023-07-20 Thread Tejesh R
On Thu, 20 Jul 2023 13:55:43 GMT, Alexander Zvegintsev wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix > > test/jdk/java/awt/Multiscreen/MultiScreenCheckScreenIDTest.java line 45: > >> 43: * @bug 8280482

Re: RFR: 8280482: Window transparency bug on Linux [v2]

2023-07-20 Thread Alexander Zvegintsev
On Wed, 12 Jul 2023 04:59:30 GMT, Tejesh R wrote: >> The bug mentions about transparency issue on Linux which actually got >> resolved with [JDK-8006421](https://bugs.openjdk.org/browse/JDK-8006421) >> fix. Now there is another problem related to the bug, which is screen >> selection going wro

Integrated: 8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS

2023-07-20 Thread Alexander Zvegintsev
On Thu, 20 Jul 2023 13:17:48 GMT, Alexander Zvegintsev wrote: > This test fails in macOS 13, making the CI noise. This pull request has now been integrated. Changeset: fe419101 Author:Alexander Zvegintsev URL: https://git.openjdk.org/jdk/commit/fe419101411d47f81f2dc5f95605308780302

Re: RFR: 8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS

2023-07-20 Thread Prasanta Sadhukhan
On Thu, 20 Jul 2023 13:17:48 GMT, Alexander Zvegintsev wrote: > This test fails in macOS 13, making the CI noise. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14956#pullrequestreview-1539281573

RFR: 8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS

2023-07-20 Thread Alexander Zvegintsev
This test fails in macOS 13, making the CI noise. - Commit messages: - initial Changes: https://git.openjdk.org/jdk/pull/14956/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14956&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8312459 Stats: 1 line in 1 file change

Re: RFR: 8280482: Window transparency bug on Linux [v2]

2023-07-20 Thread Alexander Zvegintsev
On Thu, 20 Jul 2023 03:49:16 GMT, Tejesh R wrote: >> src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java line 807: >> >>> 805: insLog.fine(xe.toString()); >>> 806: } >>> 807: checkIfOnNewScreen(new Rectangle(scaleDown(xe.get_x()), >> >> After the fix I am unab

RFR: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left

2023-07-20 Thread Tejesh R
Popup menu is created on mouse click, hence the orientation for FileChooser won't apply to the popup menu created. Hence the fix address the issue by applying the FileChooser orientation when it is created on mouse operation (Right Click). The test does not apply to Motif and Aqua Look And Feel