On Mon, 24 Jul 2023 09:58:09 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disabled OLE1 from CoInit
>
> src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.c
On Tue, 25 Jul 2023 00:13:12 GMT, Jiangli Zhou wrote:
> Please review the simple fix that changes start|stop_timer to static.
I was thinking of asking you to see if there are any other variables or
functions in this file that could be made static, but it looks like xx_timer
are the only one le
Please review the simple fix that changes start|stop_timer to static.
-
Commit messages:
- Change 'start|stop_timer' to be static.
Changes: https://git.openjdk.org/jdk/pull/15006/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15006&range=00
Issue: https://bugs.openjdk.org
On Mon, 24 Jul 2023 18:16:21 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test changes: added CountDownLatch
>
> test/jdk/java/awt/Robot/RobotModifierMaskTest.java line 107:
>
>> 105:
> **Problem:**
>
> On macOS, Robot erroneously produces lowercase letter when mouse is moved
> (manually) in unison with Robot's keyEvents. This issue was originally logged
> by a developer of an on-screen accessibility keyboard - TouchBoard.
> Originally reported at https://github.com/adoptiu
On Mon, 24 Jul 2023 10:37:43 GMT, Aleksey Shipilev wrote:
> At least GCC 6 fail the build with warnings-as-errors here:
>
>
> ../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc: In function
> 'void _collect_layout_variation_indices(hb_subset_plan_t*)':
> ../src/java.desktop/share/n
On Mon, 24 Jul 2023 18:27:20 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test changes: added CountDownLatch
>
> test/jdk/java/awt/Robot/RobotModifierMaskTest.java line 245:
>
>> 243:
On Mon, 24 Jul 2023 18:05:32 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test changes: added CountDownLatch
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m line 317:
>
>> 315
On Mon, 24 Jul 2023 10:21:52 GMT, Aleksey Shipilev wrote:
> There is a simple build failure after
> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>
>
> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
> In file included from
> /home/bui
On Mon, 24 Jul 2023 10:21:52 GMT, Aleksey Shipilev wrote:
> There is a simple build failure after
> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>
>
> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
> In file included from
> /home/bui
On Tue, 18 Jul 2023 18:00:11 GMT, Gabriel wrote:
> I think this patch would also address
> https://bugs.openjdk.org/browse/JDK-7116070
It didn't, the test case still produces truncated names.
Although, the mixer name used for recording in the stand-alone test attached to
[JDK-8301846](https:/
On Mon, 24 Jul 2023 10:37:43 GMT, Aleksey Shipilev wrote:
> At least GCC 6 fail the build with warnings-as-errors here:
>
>
> ../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc: In function
> 'void _collect_layout_variation_indices(hb_subset_plan_t*)':
> ../src/java.desktop/share/n
On Mon, 24 Jul 2023 19:06:23 GMT, Alexey Ivanov wrote:
> What I mean is to look further whether this situation affects any internal
> state of Robot so that wrong mouse events are posted.
>
> It could still be a possible scenario. Consider Robot is moving mouse slowly,
> the user presses a mou
On Fri, 21 Jul 2023 19:42:00 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Fri, 21 Jul 2023 19:32:07 GMT, Abhishek Kumar wrote:
>> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line
>> 242:
>>
>>> 240: ac.setAccessibleName(label.getText());
>>> 241: }
>>> 242: }
>>
>> How it will work in other L&Fs?
>
> I
On Fri, 21 Jul 2023 03:39:27 GMT, Sergey Bylokhov wrote:
>> @mrserb
>>
>>> Just to clarify an idea of this change. We would like to maintain the
>>> "flag" keys pressed by the user and maintain the list of current flags. So
>>> if the user will press SHIFT key, we will use that modifier for a
On Mon, 24 Jul 2023 17:55:49 GMT, Alexey Ivanov wrote:
> If the user moves the mouse when Robot generates mouse events, it is expected
> to produce erroneous results because the mouse ends up in the wrong position
> when Robot issues further events — essentially it breaks the assumptions in
>
On Mon, 17 Jul 2023 19:09:29 GMT, Harshitha Onkar wrote:
>> **Problem:**
>>
>> On macOS, Robot erroneously produces lowercase letter when mouse is moved
>> (manually) in unison with Robot's keyEvents. This issue was originally
>> logged by a developer of an on-screen accessibility keyboard -
On Fri, 21 Jul 2023 21:09:56 GMT, Harshitha Onkar wrote:
> Additionally, I believe concurrent external manual mouse movement is not
> supported when Robot is performing mouse events. This would produce erroneous
> result.
I don't think it's correct to say that such a situation is *not supporte
On Mon, 24 Jul 2023 00:38:52 GMT, Sergey Bylokhov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added test cases, fixed spacing
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line
> 98
On Mon, 24 Jul 2023 10:21:52 GMT, Aleksey Shipilev wrote:
> There is a simple build failure after
> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>
>
> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
> In file included from
> /home/bui
On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization libr
At least GCC 6 fail the build with warnings-as-errors here:
../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc: In function
'void _collect_layout_variation_indices(hb_subset_plan_t*)':
../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc:389:83: error:
suggest parentheses
There is a simple build failure after
[JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
* For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
In file included from
/home/buildbot/worker/build-jdkX-debian9/build/src/java.desktop/unix/native/libpipe
On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization libr
When a JFormattedTextField field value is set by setText, then when the field
initially gains focus it seems to not use the edit formatter, but rather use
display formatter, which is wrong.
Native "Date and Time setting" in windows changes the date field to edit mode
in initial focus itself.
Fi
On Wed, 12 Jul 2023 07:36:56 GMT, Prasanta Sadhukhan
wrote:
> Due to some threading issues, Progress Monitor is not shown in macos..
> Seems like we need to call ProgressMonitor swing component in EDT..
This pull request has now been integrated.
Changeset: 197981b4
Author:Prasanta Sadhukha
On Thu, 20 Jul 2023 09:40:41 GMT, Tejesh R wrote:
> Popup menu is created on mouse click, hence the orientation for FileChooser
> won't apply to the popup menu created. Hence the fix address the issue by
> applying the FileChooser orientation when it is created on mouse operation
> (Right Clic
28 matches
Mail list logo
