Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

2023-07-27 Thread Prasanta Sadhukhan
On Thu, 27 Jul 2023 14:30:23 GMT, Prasanta Sadhukhan wrote: > Adding buttons in a JToolBar after a JSeparator will push the button to the > far right of the frame instead of just after the separator > > ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a8aa

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

2023-07-27 Thread Sergey Bylokhov
On Thu, 27 Jul 2023 14:30:23 GMT, Prasanta Sadhukhan wrote: > Adding buttons in a JToolBar after a JSeparator will push the button to the > far right of the frame instead of just after the separator > > ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a8aa

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

2023-07-27 Thread Prasanta Sadhukhan
On Thu, 27 Jul 2023 14:30:23 GMT, Prasanta Sadhukhan wrote: > Adding buttons in a JToolBar after a JSeparator will push the button to the > far right of the frame instead of just after the separator > > ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a8aa

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

2023-07-27 Thread Sergey Bylokhov
On Thu, 27 Jul 2023 14:30:23 GMT, Prasanta Sadhukhan wrote: > Adding buttons in a JToolBar after a JSeparator will push the button to the > far right of the frame instead of just after the separator > > ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a8aa

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v2]

2023-07-27 Thread Renjith Kannath Pariyangad
On Thu, 27 Jul 2023 16:32:35 GMT, Alexey Ivanov wrote: >>> > I think this patch would also address >>> > https://bugs.openjdk.org/browse/JDK-7116070 >>> >>> It didn't, the test case still produces truncated names. >>> >>> Although, the mixer name used for recording in the stand-alone test >>>

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

2023-07-27 Thread Prasanta Sadhukhan
On Thu, 27 Jul 2023 14:30:23 GMT, Prasanta Sadhukhan wrote: > Adding buttons in a JToolBar after a JSeparator will push the button to the > far right of the frame instead of just after the separator > > ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a8aa

Re: RFR: 8312591: GCC 6 build failure after JDK-8280982 [v2]

2023-07-27 Thread Jie Fu
On Thu, 27 Jul 2023 19:01:35 GMT, Aleksey Shipilev wrote: >> There is a simple build failure after >> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs: >> >> >> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o: >> In file included from >> /h

Re: RFR: JDK-8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources [v2]

2023-07-27 Thread Alexey Ivanov
On Wed, 26 Jul 2023 11:59:06 GMT, Matthias Baesken wrote: >> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels >> we release some resources at the end of the function by calling >> DeleteObject/DeleteDC. This is recommended by the MS API docs. >> However this should b

Re: RFR: 8312591: GCC 6 build failure after JDK-8280982 [v2]

2023-07-27 Thread Phil Race
On Thu, 27 Jul 2023 19:01:35 GMT, Aleksey Shipilev wrote: >> There is a simple build failure after >> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs: >> >> >> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o: >> In file included from >> /h

Integrated: 8312626: Resolve multiple definition of 'start_timer' when statically linking JDK native libraries with user code

2023-07-27 Thread Jiangli Zhou
On Tue, 25 Jul 2023 00:13:12 GMT, Jiangli Zhou wrote: > Please review the simple fix that changes start|stop_timer to static. This pull request has now been integrated. Changeset: c55d29ff Author:Jiangli Zhou URL: https://git.openjdk.org/jdk/commit/c55d29ff119598a410e714ef36f47fb662

Re: RFR: 8312591: GCC 6 build failure after JDK-8280982 [v2]

2023-07-27 Thread Aleksey Shipilev
On Thu, 27 Jul 2023 19:01:35 GMT, Aleksey Shipilev wrote: >> There is a simple build failure after >> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs: >> >> >> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o: >> In file included from >> /h

Re: RFR: 8312591: GCC 6 build failure after JDK-8280982 [v2]

2023-07-27 Thread Aleksey Shipilev
> There is a simple build failure after > [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs: > > > * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o: > In file included from > /home/buildbot/worker/build-jdkX-debian9/build/src/java.desktop/unix/

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

2023-07-27 Thread Sergey Bylokhov
On Thu, 27 Jul 2023 14:30:23 GMT, Prasanta Sadhukhan wrote: > Adding buttons in a JToolBar after a JSeparator will push the button to the > far right of the frame instead of just after the separator > > ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a8aa

Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-27 Thread Naoto Sato
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote: > Please review this PR which contains the translations for updates to > localized resources in the JDK since RDP1. > > Included in this change are improved translations for certain values, which > also includes global updates for translations

Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-27 Thread Damon Nguyen
On Thu, 27 Jul 2023 06:48:32 GMT, Justin Lu wrote: >> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties >> line 185: >> >>> 183: jshell.console.no.javadoc = >>> 184: jshell.console.do.nothing = Do nothing >>> 185: jshell.console.choice = Choice:\u0020 >> >> I see

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v2]

2023-07-27 Thread Alexey Ivanov
On Tue, 25 Jul 2023 07:01:35 GMT, Renjith Kannath Pariyangad wrote: > > I think this patch would also address > > https://bugs.openjdk.org/browse/JDK-7116070 > > It didn't, the test case still produces truncated names. > > Although, the mixer name used for recording in the stand-alone test at

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-27 Thread Alexey Ivanov
On Thu, 27 Jul 2023 16:23:01 GMT, Alexey Ivanov wrote: >> is it possible that our "::CoInitialize(NULL);" prevents the >> ::CoInitializeEx(NULL, COINIT_MULTITHREADED); in the lib later? > >> is it possible that our "::CoInitialize(NULL);" prevents the >> ::CoInitializeEx(NULL, COINIT_MULTITHREA

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-27 Thread Alexey Ivanov
On Wed, 26 Jul 2023 23:35:25 GMT, Sergey Bylokhov wrote: > is it possible that our "::CoInitialize(NULL);" prevents the > ::CoInitializeEx(NULL, COINIT_MULTITHREADED); in the lib later? It is not only possible, it is explicitly stated. If the threading mode is different, the function fails wit

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v5]

2023-07-27 Thread Alexey Ivanov
On Thu, 27 Jul 2023 03:46:23 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization libr

Re: RFR: 8312626: Resolve multiple definition of 'start_timer' when statically linking JDK native libraries with user code [v4]

2023-07-27 Thread Jiangli Zhou
> Please review the simple fix that changes start|stop_timer to static. Jiangli Zhou has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional com

RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

2023-07-27 Thread Prasanta Sadhukhan
Adding buttons in a JToolBar after a JSeparator will push the button to the far right of the frame instead of just after the separator ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a8aa7) This is because BasicSeparatorUI does not define a maximum size. Th

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v2]

2023-07-27 Thread 柳鲲鹏
On Thu, 16 Mar 2023 08:33:35 GMT, 柳鲲鹏 wrote: >> Candidat box can moving with caret on windows version. Someone must wrote >> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. >> Why it doesn't work, is the key problem. >> >> 1, I wrote a example for linux: >> https:/

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v2]

2023-07-27 Thread 极速蜗牛
On Thu, 16 Mar 2023 08:33:35 GMT, 柳鲲鹏 wrote: >> Candidat box can moving with caret on windows version. Someone must wrote >> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. >> Why it doesn't work, is the key problem. >> >> 1, I wrote a example for linux: >> https:/

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v2]

2023-07-27 Thread senluowx
On Wed, 28 Jun 2023 21:46:30 GMT, Nikita Provotorov wrote: > Hi, guys! I want to notice that JetBrains is working on the issue too and > we're going to propose our own fix. This problem has existed for more than ten years, do you guys have time to plan - PR Comment: https://git.op

Integrated: JDK-8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources

2023-07-27 Thread Matthias Baesken
On Wed, 26 Jul 2023 10:43:20 GMT, Matthias Baesken wrote: > In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels > we release some resources at the end of the function by calling > DeleteObject/DeleteDC. This is recommended by the MS API docs. > However this should be do