Re: RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale

2023-08-07 Thread Tejesh R
On Fri, 4 Aug 2023 18:34:31 GMT, Phil Race wrote: >> I can see French resource files: >> [`windows_fr.properties`](https://github.com/openjdk/jdk/blob/e8a37b90db8dca4dc3653970b2d66d2faf8ef452/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties); >> t

Re: RFR: 8313348: Fix typo in JFormattedTextField: 'it self'

2023-08-07 Thread Sergey Bylokhov
On Sat, 5 Aug 2023 18:24:44 GMT, Alexey Ivanov wrote: >>> For what it's worth, we have spent much more time discussing it… >> >> Right, and I do not se a reason why other cases of the exactly same typo at >> least in java.desktop module is not fixed. Or do you suggest to create one >> more JBS

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v31]

2023-08-07 Thread ScientificWare
On Mon, 7 Aug 2023 18:00:38 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add name

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame

2023-08-07 Thread Alexey Ivanov
On Tue, 23 May 2023 02:52:03 GMT, lawrence.andrews wrote: > 1) Used builder pattern > 2) Tested AWT tests and it passed test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 87: > 85: .rows(18) > 86: .columns(85) > 87: .enableScreenCapture()

Re: RFR: 8313810: BoxLayout uses instead of list for layout options

2023-08-07 Thread Alexey Ivanov
On Mon, 7 Aug 2023 19:43:38 GMT, Alexey Ivanov wrote: > A clean-up of documentation for > [`BoxLayout`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/BoxLayout.html#class-description): > > 1. Use the `` element instead of `` to list layout options or > axes. > 2.

RFR: 8313810: BoxLayout uses instead of list for layout options

2023-08-07 Thread Alexey Ivanov
A clean-up of documentation for [`BoxLayout`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/BoxLayout.html#class-description): 1. Use the `` element instead of `` to list layout options or axes. 2. Add links to `GridBagLayout` and `Box` classes. 3. Markup references

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v29]

2023-08-07 Thread Alexey Ivanov
On Mon, 7 Aug 2023 14:08:13 GMT, Alexey Ivanov wrote: >> Delay due to the reorganization of my contribution schedule caused by new >> requests. > >> @scientificware Please do not rebase or force-push to an active PR as it >> invalidates existing review comments. Note for future reference, the b

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v29]

2023-08-07 Thread ScientificWare
On Mon, 7 Aug 2023 14:08:13 GMT, Alexey Ivanov wrote: >> Delay due to the reorganization of my contribution schedule caused by new >> requests. > >> @scientificware Please do not rebase or force-push to an active PR as it >> invalidates existing review comments. Note for future reference, the b

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v31]

2023-08-07 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge [v4]

2023-08-07 Thread Damon Nguyen
On Mon, 7 Aug 2023 09:31:43 GMT, Prasanta Sadhukhan wrote: >> Adding buttons in a JToolBar after a JSeparator will push the button to the >> far right of the frame instead of just after the separator >> >> ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v29]

2023-08-07 Thread Alexey Ivanov
On Thu, 25 May 2023 05:59:32 GMT, ScientificWare wrote: >> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java >> >> Remove space. >> >> Co-

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge [v4]

2023-08-07 Thread Alexey Ivanov
On Mon, 7 Aug 2023 09:31:43 GMT, Prasanta Sadhukhan wrote: >> Adding buttons in a JToolBar after a JSeparator will push the button to the >> far right of the frame instead of just after the separator >> >> ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge [v3]

2023-08-07 Thread Prasanta Sadhukhan
On Thu, 3 Aug 2023 10:34:11 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments > > test/jdk/javax/swing/JToolBar/ToolBarSeparatorTest.java line 37: > >> 35: import java.awt.In

Re: RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge [v4]

2023-08-07 Thread Prasanta Sadhukhan
> Adding buttons in a JToolBar after a JSeparator will push the button to the > far right of the frame instead of just after the separator > > ![image](https://github.com/openjdk/jdk/assets/43534309/7fcad657-493f-4370-b046-b31c212a8aa7) > > This is because BasicSeparatorUI does not define a maxi

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread Kim Barrett
On Mon, 7 Aug 2023 08:00:12 GMT, David Holmes wrote: >> Hi David, this throw was removed for this method's declaration in the >> corresponding hpp file in an earlier commit [8305590: Remove nothrow >> exception specifications from operator >> new](https://github.com/openjdk/jdk/commit/0f51e632

Integrated: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.

2023-08-07 Thread Prasanta Sadhukhan
On Thu, 22 Jun 2023 13:47:56 GMT, Prasanta Sadhukhan wrote: > If a JTable is wrapped in JLayer and first row is selected and VK_PAGE_DOWN > is pressed, the last row of the table is selected instead of the next row > after current viewport. > This is because table.getParent.getSize() returns th

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread Julian Waters
On Tue, 1 Aug 2023 08:19:06 GMT, Julian Waters wrote: >> src/hotspot/os/windows/symbolengine.cpp line 114: >> >>> 112: _capacity = (int)(sizeof(_fallback_buffer) / sizeof(T)); >>> 113: } >>> 114: _p[0] = (T) '\0'; >> >> I find this use of `'\0'` quite suspicious in itself, but it

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread Julian Waters
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the signific

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread David Holmes
On Tue, 1 Aug 2023 08:16:41 GMT, Julian Waters wrote: >> src/hotspot/share/memory/allocation.cpp line 114: >> >>> 112: // >>> 113: >>> 114: void* AnyObj::operator new(size_t size, Arena *arena) { >> >> Please remind us what the issue is with `throw()` as this is a change to >> shared code and

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread David Holmes
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the signific