Integrated: 8314076: ICC_ColorSpace#minVal/maxVal have the opposite description

2023-08-16 Thread Sergey Bylokhov
On Wed, 9 Aug 2023 23:31:39 GMT, Sergey Bylokhov wrote: > Fixed a typo in the spec which changes the meaning of the > ICC_ColorSpace#minVal/maxVal fields to the opposite. This pull request has now been integrated. Changeset: b78f5a10 Author:Sergey Bylokhov URL: https://git.openjdk.

Re: RFR: 8258970: Disabled JPasswordField foreground color is wrong with GTK LAF

2023-08-16 Thread Tejesh R
On Mon, 14 Aug 2023 03:31:37 GMT, Abhishek Kumar wrote: > Disabled JPasswordField foreground color was not grayed out in GTK LAF. > > The foreground color in disabled state was close to black color (RGB 0,0,0) > for password field which is not differentiable from enabled state foreground > col

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-16 Thread Julian Waters
On Wed, 16 Aug 2023 19:22:01 GMT, Sergey Bylokhov wrote: > Why initial patch was reverter using this comment: "unfortunately, did not > prove to be as useful as expected"? What was the problem? What about the > "pedantic" option which was added last time? Hi, the problem was that gcc and clang

Re: RFR: JDK-8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux [v2]

2023-08-16 Thread Sergey Bylokhov
On Wed, 16 Aug 2023 23:52:48 GMT, Harshitha Onkar wrote: >> JToolBar test - bug4529206.java was failing intermittently on Linux. It was >> due to timing issue. Added appropriate delay to fix the issue. >> >> CI Testing passes on all platforms. > > Harshitha Onkar has updated the pull request in

Re: RFR: JDK-8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux [v2]

2023-08-16 Thread Harshitha Onkar
On Wed, 16 Aug 2023 22:48:19 GMT, Damon Nguyen wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> AutoWaitForIdle > > test/jdk/javax/swing/JToolBar/4529206/bug4529206.java line 82: > >> 80: SwingUtilit

Re: RFR: JDK-8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux [v2]

2023-08-16 Thread Harshitha Onkar
> JToolBar test - bug4529206.java was failing intermittently on Linux. It was > due to timing issue. Added appropriate delay to fix the issue. > > CI Testing passes on all platforms. Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8139208: [macosx] Issue with setExtendedState of JFrame [v2]

2023-08-16 Thread Damon Nguyen
On Fri, 11 Aug 2023 21:50:35 GMT, Alisen Chung wrote: >> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line >> 674: >> >>> 672: /* Frame or Dialog should be set property >>> WINDOW_FULLSCREENABLE to true if the >>> 673: Frame or Dialog is

Re: RFR: JDK-8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux

2023-08-16 Thread Damon Nguyen
On Wed, 16 Aug 2023 18:23:59 GMT, Harshitha Onkar wrote: > JToolBar test - bug4529206.java was failing intermittently on Linux. It was > due to timing issue. Added appropriate delay to fix the issue. > > CI Testing passes on all platforms. Marked as reviewed by dnguyen (Committer). test/jdk/j

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-16 Thread Sergey Bylokhov
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less acceptin

Re: RFR: JDK-8311113: Remove invalid pointer cast and clean up setLabel() in awt_MenuItem.cpp

2023-08-16 Thread Alexey Ivanov
On Mon, 14 Aug 2023 18:03:21 GMT, Harshitha Onkar wrote: > In awt_MenuItem.cpp (712,22): ` mii.dwTypeData = (LPTSTR)(*sb)` produces > invalid pointer cast warning when complied on clang and moreover this is a > no-op. > > `mii.dwTypeData` is used only when **MIIM_STRING** flag is set in the

RFR: JDK-8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux

2023-08-16 Thread Harshitha Onkar
JToolBar test - bug4529206.java was failing intermittently on Linux. It was due to timing issue. Added appropriate delay to fix the issue. CI Testing passes on all platforms. - Commit messages: - copyright year - initial commit Changes: https://git.openjdk.org/jdk/pull/15316/file

Re: RFR: 8312191: ColorConvertOp.filter for the default destination is too slow

2023-08-16 Thread Sergey Bylokhov
On Mon, 17 Jul 2023 20:59:05 GMT, Sergey Bylokhov wrote: > I have found that MTPerLineTransformValidation - one of our slowest stress > test spends most of the time not in the code related to the colors > conversion(as it was intended) but in the initialization of the native > cmm-transforms.

Re: RFR: JDK-8311113: Remove invalid pointer cast and clean up setLabel() in awt_MenuItem.cpp

2023-08-16 Thread Alexey Ivanov
On Mon, 14 Aug 2023 18:03:21 GMT, Harshitha Onkar wrote: > In awt_MenuItem.cpp (712,22): ` mii.dwTypeData = (LPTSTR)(*sb)` produces > invalid pointer cast warning when complied on clang and moreover this is a > no-op. > > `mii.dwTypeData` is used only when **MIIM_STRING** flag is set in the

Re: RFR: 6415065: Submenu is shown on wrong screen in multiple monitor environment

2023-08-16 Thread Sergei Tachenov
On Thu, 10 Aug 2023 05:04:48 GMT, Sergei Tachenov wrote: >> src/java.desktop/share/classes/javax/swing/JMenu.java line 489: >> >>> 487: } >>> 488: if (position.y + y >= screenBounds.y + screenBounds.height) { >>> // Below the current screen? >>> 489: y = screenBounds

Re: RFR: 6415065: Submenu is shown on wrong screen in multiple monitor environment

2023-08-16 Thread Sergei Tachenov
On Thu, 10 Aug 2023 00:04:52 GMT, Sergey Bylokhov wrote: >> Hello! >> >> I'm a member of the UI team in JetBrains IntelliJ department, and we have >> this bug with popup menus being shown on the wrong monitor in multi-monitor >> environments: >> >> https://youtrack.jetbrains.com/issue/JBR-582

Re: RFR: 6415065: Submenu is shown on wrong screen in multiple monitor environment

2023-08-16 Thread Sergey Bylokhov
On Tue, 8 Aug 2023 08:44:25 GMT, Sergei Tachenov wrote: > Hello! > > I'm a member of the UI team in JetBrains IntelliJ department, and we have > this bug with popup menus being shown on the wrong monitor in multi-monitor > environments: > > https://youtrack.jetbrains.com/issue/JBR-5824/Dual-m

Re: RFR: 6415065: Submenu is shown on wrong screen in multiple monitor environment

2023-08-16 Thread Sergei Tachenov
On Tue, 8 Aug 2023 08:44:25 GMT, Sergei Tachenov wrote: > Hello! > > I'm a member of the UI team in JetBrains IntelliJ department, and we have > this bug with popup menus being shown on the wrong monitor in multi-monitor > environments: > > https://youtrack.jetbrains.com/issue/JBR-5824/Dual-m

RFR: 6415065: Submenu is shown on wrong screen in multiple monitor environment

2023-08-16 Thread Sergei Tachenov
Hello! I'm a member of the UI team in JetBrains IntelliJ department, and we have this bug with popup menus being shown on the wrong monitor in multi-monitor environments: https://youtrack.jetbrains.com/issue/JBR-5824/Dual-monitor-bug-on-the-context-menu I managed to track it down to this JDK b

Re: RFR: JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color [v15]

2023-08-16 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded > Color](https://bugs.java.com/bugdatabase/view_bug?bug_id=8293776) > > This is tracked in JBS as > - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded > Color](https://bugs.openjdk.java.net/browse/

Re: RFR: JDK-8294090 : Aligns the CSS and function behaviours [v2]

2023-08-16 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8294090 : Aligns the CSS `` and `` function > behaviours](https://bugs.java.com/bugdatabase/view_bug?bug_id=8294090) > > This is tracked in JBS as > - [JDK-8294090 : Aligns the CSS `` and `` function > behaviours](https://bugs.openjdk.java.n

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v35]

2023-08-16 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk.ja

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v34]

2023-08-16 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk.ja

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v33]

2023-08-16 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.openjdk.ja

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v32]

2023-08-16 Thread Andrey Turbanov
On Sun, 13 Aug 2023 04:20:29 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named