Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v2]

2023-08-22 Thread 柳鲲鹏
On Wed, 28 Jun 2023 22:05:50 GMT, Nikita Provotorov wrote: > Have you tried to use just _java.awt.Component#getLocationOnScreen_? The document say:"The x and y coordinates are relative to the focus window". - PR Review Comment: https://git.openjdk.org/jdk/pull/13055#discussion_r130

Re: RFR: 8313403: Remove unused 'mask' field from JFormattedTextField

2023-08-22 Thread Harshitha Onkar
On Mon, 31 Jul 2023 10:26:44 GMT, Alexey Ivanov wrote: > The private field `mask` is never used in `JFormattedTextField`. > > I couldn't find any usages of the field, including JNI. Therefore, it is safe > to remove. Marked as reviewed by honkar (Committer). - PR Review: https://

Re: RFR: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1) [v3]

2023-08-22 Thread Alexey Ivanov
On Tue, 22 Aug 2023 17:25:54 GMT, Phil Race wrote: > > > It was pointed out (privately) that we should say ideographs not > > > hieroglyphs. You can look up the difference. > > > > @prrace Should we say _“glyphs”_ instead? Latin characters are also > > affected if the font has embedded bitmaps

Re: RFR: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1) [v3]

2023-08-22 Thread Phil Race
On Fri, 18 Aug 2023 13:24:00 GMT, Alexey Ivanov wrote: >> **Problem** >> >> Glyphs aren't stretched by applying an affine transform `scale(2, 1)` to a >> font. Instead, the space between glyphs increases. >> >> **Root Cause** >> >> Bitmaps embedded in the font are used to render the glyphs; t

Integrated: 8313408: Use SVG for BoxLayout example

2023-08-22 Thread Alexey Ivanov
On Sat, 5 Aug 2023 19:13:20 GMT, Alexey Ivanov wrote: > Replace the GIF image of `BoxLayout` example with an SVG one which renders > crisp on all the displays, including High DPI ones. > > Compare the images: > > * > [`BoxLayout`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desk

Re: RFR: JDK-8314731 : Adds support for the alt attribute in the image type imput HTML tag.

2023-08-22 Thread Victor Dyakov
On Thu, 17 Aug 2023 00:16:07 GMT, ScientificWare wrote: > According [HTML 3.2 > specification](https://www.w3.org/TR/2018/SPSD-html32-20180315/#input) > > `alt` is not an attribute of the `imput` element. > > According [HTML 4.01 > specifications](https://www.w3.org/TR/html4/interact/forms.ht

RFR: JDK-8314731 : Adds support for the alt attribute in the image type imput HTML tag.

2023-08-22 Thread ScientificWare
According [HTML 3.2 specification](https://www.w3.org/TR/2018/SPSD-html32-20180315/#input) `alt` is not an attribute of the `imput` element. According [HTML 4.01 specifications](https://www.w3.org/TR/html4/interact/forms.html#h-17.4) : > ... For accessibility reasons, authors should provide [

Re: RFR: 8314753: Remove support for @beaninfo, @ToDo, @since.unbundled, and @Note [v2]

2023-08-22 Thread Pavel Rappo
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote: >> Please review this trivial PR. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into 8314753 > - Initial commit Than

Re: RFR: 8314753: Remove support for @beaninfo, @ToDo, @since.unbundled, and @Note [v2]

2023-08-22 Thread Roger Riggs
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote: >> Please review this trivial PR. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into 8314753 > - Initial commit Look

Re: RFR: 8314753: Remove support for @beaninfo, @ToDo, @since.unbundled, and @Note [v2]

2023-08-22 Thread Pavel Rappo
> Please review this trivial PR. Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into 8314753 - Initial commit - Changes: https://git.openjdk.org/jdk/pull/15385/files W

Re: RFR: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1) [v3]

2023-08-22 Thread Alexey Ivanov
On Tue, 22 Aug 2023 04:57:30 GMT, Phil Race wrote: > It was pointed out (privately) that we should say ideographs not hieroglyphs. > You can look up the difference. @prrace Should we say *“glyphs”* instead? Latin characters are also affected if the font has embedded bitmaps for them, and the M

Re: RFR: 8314753: Remove support for @beaninfo, @ToDo, @since.unbundled, and @Note

2023-08-22 Thread Pavel Rappo
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote: > Please review this trivial PR. CC'ing client-libs-dev because @beaninfo and @Note and jmx-dev because of @since.unbundled, which might've been used for JMX before 2007. - PR Comment: https://git.openjdk.org/jdk/pull/15385#issu

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v8]

2023-08-22 Thread 柳鲲鹏
> Candidat box can moving with caret on windows version. Someone must wrote > codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. > Why it doesn't work, is the key problem. > > 1, I wrote a example for linux: > https://github.com/quantum6/X11InputMethod > > I tried all