In
https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
the weak reference was accidentally changed from a field to a local variable,
which means that the PropertyChangeListener keeps a strong reference to
executorService, which is a resource leak
-
On Sun, 30 Jul 2023 12:50:58 GMT, Christopher Sahnwaldt
wrote:
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
>
On Sun, 30 Jul 2023 12:50:58 GMT, Christopher Sahnwaldt
wrote:
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
>
Few closed JMenu swing tests are open sourced.
-
Commit messages:
- Open source swing JMenu tests
Changes: https://git.openjdk.org/jdk/pull/15639/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15639=00
Issue: https://bugs.openjdk.org/browse/JDK-8315898
Stats: 357 lines in
On Fri, 8 Sep 2023 13:02:07 GMT, Alan Bateman wrote:
> So what about FontConfiguration? Is that something using the class directly
> too?
I think this is not needed either. As far as I can see, the instance of
`FontConfiguration` is created from `doPrivileged`, therefore these two system
On Fri, 8 Sep 2023 10:58:23 GMT, Matthias Baesken wrote:
> So probably we could avoid changing VMManagementImpl.java because it is not
> needed any more at least in jdk-head .
It's a JDK internal class so should never have been used directly. I can't
imagine what might be using a JDK internal
Some closed awt tests are opensourced
-
Commit messages:
- 8315663: Open source misc awt tests
Changes: https://git.openjdk.org/jdk/pull/15634/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15634=00
Issue: https://bugs.openjdk.org/browse/JDK-8315663
Stats: 263 lines in 2
On Fri, 8 Sep 2023 08:26:16 GMT, Matthias Baesken wrote:
> There are some remaining places in 'general' JDK code (= code not related to
> e.g. a specific tool) getting properties like :
>
> osName = System.getProperty(os.name)
>
>
On Fri, 8 Sep 2023 07:07:20 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JList/bug4832765.java line 41:
>
>> 39: public class
> Few closed JList and JMenubar swing tests are open sourced.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15621/files
- new:
On Fri, 8 Sep 2023 08:26:16 GMT, Matthias Baesken wrote:
> There are some remaining places in 'general' JDK code (= code not related to
> e.g. a specific tool) getting properties like :
>
> osName = System.getProperty(os.name)
>
>
There are some remaining places in 'general' JDK code (= code not related to
e.g. a specific tool) getting properties like :
osName = System.getProperty(os.name)
https://github.com/openjdk/jdk/blob/master/src/java.management/share/classes/sun/management/VMManagementImpl.java#L225
On Fri, 8 Sep 2023 07:12:50 GMT, Prasanta Sadhukhan
wrote:
> Minor comment...Also please ensure mach5 job is run in open too before
> integration
Ran the mach5 job in open too, it was green. Link added in JBS comment.
-
PR Comment:
On Fri, 8 Sep 2023 07:04:54 GMT, Prasanta Sadhukhan
wrote:
> I hope you have run these tests in open in mach5 as mentioned, as I dont see
> any test run job result in JBS..Approving assumming you have run and no
> issues in test job..
I ran these tests in CI, it was green. Forgot to add in
On Thu, 7 Sep 2023 15:19:37 GMT, Abhishek Kumar wrote:
> Few closed JList and JMenubar swing tests are open sourced.
Minor comment...Also please ensure mach5 job is run in open too before
integration
test/jdk/javax/swing/JList/bug4832765.java line 41:
> 39: public class bug4832765 {
> 40:
>
On Thu, 7 Sep 2023 18:57:50 GMT, Abhishek Kumar wrote:
> Few closed JFileChooser and other swing tests are open sourced.
I hope you have run these tests in open in mach5 as mentioned, as I dont see
any test run job result in JBS..Approving assumming you have run and no issues
in test job..
16 matches
Mail list logo
