On Wed, 13 Sep 2023 13:00:28 GMT, Prasanta Sadhukhan
wrote:
> JMenubar manual applet test converted to automated and opensourced
Marked as reviewed by tr (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/15717#pullrequestreview-1625854618
On Wed, 13 Sep 2023 15:53:30 GMT, Alexander Zuev wrote:
> Clean up and open source five tests:
> javax/swing/DefaultListCellRenderer/4180943/bug4180943.java
> javax/swing/DefaultListModel/4466250/bug4466250.java
> javax/swing/DefaultListSelectionModel/4140619/bug4140619.java
> javax/swing/Default
On Tue, 12 Sep 2023 17:05:47 GMT, Harshitha Onkar wrote:
> Following tests are being open sourced as part of this PR.
>
> javax/swing/text/html/HTMLDocument/4251593/bug4251593.java
> javax/swing/text/html/HTMLDocument/4687405/bug4687405.java
> javax/swing/text/html/HTMLDocument/4226914/bug422691
On Wed, 13 Sep 2023 22:47:20 GMT, Harshitha Onkar wrote:
>> Open sourcing the following tests -
>>
>> 1. javax/swing/text/CompositeView/4398059/bug4398059.java
>> 2. javax/swing/text/DefaultCaret/4197894/bug4197894.java
>> 3. javax/swing/text/DefaultCaret/4203175/bug4203175.java
>> 4. javax/swin
On Thu, 17 Aug 2023 08:38:01 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
On Fri, 1 Sep 2023 00:04:18 GMT, Harshitha Onkar wrote:
>> In awt_MenuItem.cpp (712,22): ` mii.dwTypeData = (LPTSTR)(*sb)` produces
>> invalid pointer cast warning when complied on clang and moreover this is a
>> no-op.
>>
>> `mii.dwTypeData` is used only when **MIIM_STRING** flag is set in
On Mon, 17 Jul 2023 20:59:05 GMT, Sergey Bylokhov wrote:
> I have found that MTPerLineTransformValidation - one of our slowest stress
> test spends most of the time not in the code related to the colors
> conversion(as it was intended) but in the initialization of the native
> cmm-transforms.
On Thu, 14 Sep 2023 00:09:29 GMT, Harshitha Onkar wrote:
>> This PR open sources few Swing Text/HTML related tests.
>
> Harshitha Onkar has updated the pull request incrementally with one
> additional commit since the last revision:
>
> test update
Marked as reviewed by azvegint (Reviewer).
On Wed, 13 Sep 2023 06:29:20 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor changes
>
> test/jdk/javax/swing/text/html/bug4210307.java line 40:
>
>> 38:
>> 39: public class bug4
> This PR open sources few Swing Text/HTML related tests.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
test update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15675/files
- new: https://git.openjdk.org/j
On Wed, 13 Sep 2023 09:22:27 GMT, Tejesh R wrote:
>> Harshitha Onkar has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - delay changes
>> - minor review change
>
> test/jdk/javax/swing/text/DefaultCaret/bug4197894.java line 53:
>
>> 51:
> Open sourcing the following tests -
>
> 1. javax/swing/text/CompositeView/4398059/bug4398059.java
> 2. javax/swing/text/DefaultCaret/4197894/bug4197894.java
> 3. javax/swing/text/DefaultCaret/4203175/bug4203175.java
> 4. javax/swing/text/DefaultEditorKit/4265242/bug4265242.java
> 5. javax/swing/
On Mon, 11 Sep 2023 22:18:51 GMT, Alexander Zvegintsev
wrote:
> Some closed AWT test are open sourced.
This pull request has now been integrated.
Changeset: 1741d13b
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/commit/1741d13b1260253d1e299e8da9c42b5519a7ae48
Stats:
> Some closed AWT test are open sourced.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
fix whitespaces
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15671/files
- new: https://git.openjdk.org/jdk/pull/
On Wed, 13 Sep 2023 18:50:54 GMT, Alexey Ivanov wrote:
>> The manual test frame does not provide any layout managers for test windows,
>> the user has to implement one. This demonstrates how to position a several
>> test UI windows.
>>
>> We may include some implementations into the manual tes
On Wed, 13 Sep 2023 20:09:07 GMT, Alexey Ivanov wrote:
>Did you submit a follow-up bug for those files?
>Do you have a PR already?
I plan to work on new PR after merge of this.
-
PR Comment: https://git.openjdk.org/jdk/pull/14847#issuecomment-1718280444
On Tue, 12 Sep 2023 19:59:27 GMT, Andrey Turbanov wrote:
> Do we need a second reviewer or I can integrate?
It's a good question.
Overall, the changes are trivial: only comments are updated, some javadoc for
private classes which are comments, then a couple of method names and variable
names
On Wed, 30 Aug 2023 14:08:21 GMT, Alexey Ivanov wrote:
> I reverted changes in non-Swing parts to reduce amount of files to review.
Did you submit a follow-up bug for those files?
Do you have a PR already?
-
PR Comment: https://git.openjdk.org/jdk/pull/14847#issuecomment-17182508
On Tue, 12 Sep 2023 21:33:44 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Choice/ChoiceSelectTest.java line 160:
>>
>>> 158: public static void main(String[] args) throws Exception {
>>> 159: EventQueue.invokeAndWait(() -> new ChoiceSelectTest().test());
>>> 160: }
>>
On Tue, 12 Sep 2023 21:52:33 GMT, Alexander Zvegintsev
wrote:
>> Some closed AWT test are open sourced.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fix path
Looks good.
-
Marked as reviewed by ai
On Wed, 13 Sep 2023 08:48:25 GMT, Alexander Zuev wrote:
> Clean up and move to open source five tests.
> javax/swing/AncestorNotifier/4817630/bug4817630.java
> javax/swing/BoxLayout/4191948/bug4191948.java
> javax/swing/ComponentInputMap/4248723/bug4248723.java
> javax/swing/DefaultBoundedRangeMo
On Wed, 13 Sep 2023 15:53:30 GMT, Alexander Zuev wrote:
> Clean up and open source five tests:
> javax/swing/DefaultListCellRenderer/4180943/bug4180943.java
> javax/swing/DefaultListModel/4466250/bug4466250.java
> javax/swing/DefaultListSelectionModel/4140619/bug4140619.java
> javax/swing/Default
On Wed, 13 Sep 2023 18:50:54 GMT, Alexey Ivanov wrote:
>> The manual test frame does not provide any layout managers for test windows,
>> the user has to implement one. This demonstrates how to position a several
>> test UI windows.
>>
>> We may include some implementations into the manual tes
On Tue, 12 Sep 2023 19:51:45 GMT, Alexey Ivanov wrote:
>>> However, to test this case I'll need a (simple) scenario where multiple
>>> windows are created.
>>
>> For example
>> `test/jdk/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java`
>> is not converted to use PassFailJ
> The manual test frame does not provide any layout managers for test windows,
> the user has to implement one. This demonstrates how to position a several
> test UI windows.
>
> We may include some implementations into the manual test framework in the
> future.
>
> **This PR is not meant to b
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote:
> Looks good to me, although I did not look at each l10n file, but sampled
> some. Thanks for tackling this conversion.
Thanks for the review; (In addition to testing), I ran a script to verify only
white space escape sequences exist in JDK .
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files changed
> are localized resource files.
>
> This change converts the Un
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote:
>> This enhances the `Builder` pattern added in
>> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
>> `testUI` which allows passing a lambda expression or a method reference to
>> create *the test UI window*.
>
On Tue, 8 Aug 2023 08:44:25 GMT, Sergei Tachenov wrote:
> Hello!
>
> I'm a member of the UI team in JetBrains IntelliJ department, and we have
> this bug with popup menus being shown on the wrong monitor in multi-monitor
> environments:
>
> https://youtrack.jetbrains.com/issue/JBR-5824/Dual-m
Clean up and open source five tests:
javax/swing/DefaultListCellRenderer/4180943/bug4180943.java
javax/swing/DefaultListModel/4466250/bug4466250.java
javax/swing/DefaultListSelectionModel/4140619/bug4140619.java
javax/swing/DefaultListSelectionModel/4177723/bug4177723.java
javax/swing/ImageIcon/482
> This update to `FileChooserSymLinkTest.java` demonstrates the usage of the
> `testUI` method of the `PassFailJFrame.Builder` class to streamline creating
> the UI for manual tests.
>
> The [`main`
> method](https://github.com/aivanov-jdk/jdk/blob/cb1835527d718226f1c6fdd85ff5986703ea356f/test/
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote:
>> This enhances the `Builder` pattern added in
>> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
>> `testUI` which allows passing a lambda expression or a method reference to
>> create *the test UI window*.
>
The manual test frame does not provide any layout managers for test windows,
the user has to implement one. This demonstrates how to position a several test
UI windows.
We may include some implementations into the manual test framework in the
future.
**This PR is not meant to be integrated.**
> This enhances the `Builder` pattern added in
> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
> `testUI` which allows passing a lambda expression or a method reference to
> create *the test UI window*.
>
> The `PassFailJFrame` will automatically call the method o
JMenubar manual applet test converted to automated and opensourced
-
Commit messages:
- 8316164: Opensource JMenuBar manual test
Changes: https://git.openjdk.org/jdk/pull/15717/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15717&range=00
Issue: https://bugs.openjdk.org/b
On Wed, 13 Sep 2023 07:32:04 GMT, Prasanta Sadhukhan
wrote:
> JTextArea manual applet test converted to automated and opensourced
LGTM.
-
Marked as reviewed by abhiscxk (Committer).
PR Review: https://git.openjdk.org/jdk/pull/15700#pullrequestreview-1624290505
On Tue, 12 Sep 2023 21:32:58 GMT, Harshitha Onkar wrote:
> Open sourcing the following tests -
>
> 1. javax/swing/text/CompositeView/4398059/bug4398059.java
> 2. javax/swing/text/DefaultCaret/4197894/bug4197894.java
> 3. javax/swing/text/DefaultCaret/4203175/bug4203175.java
> 4. javax/swing/text
Open source these Swing PopupMenu related tests:
javax/swing/JPopupMenu/4236750/bug4236750.java
javax/swing/JPopupMenu/4321273/bug4321273.java
javax/swing/JPopupMenu/4711693/bug4711693.java
javax/swing/JPopupMenu/4962731/bug4962731.java
javax/swing/JPopupMenu/4966109/bug4966109.java
javax/swing/JP
**Problem**
On a standard display with the scale of 100%, the BoxLayout sample has blurred
edges.
It is the result of how SVG is rendered: the strokes fall between the pixel
grid, therefore a 1-pixel wide stroke is blurred between the previous and the
following pixels with 50% of colour on eac
> Open source these Swing JSpinner related tests:
>
> javax/swing/JSpinner/4522737/bug4522737.java
> javax/swing/JSpinner/4656590/bug4656590.java
> javax/swing/JSpinner/4680204/bug4680204.java
> javax/swing/JSpinner/4862257/bug4862257.java
> javax/swing/JSpinner/5104421/bug5104421.java
Tejesh R h
Clean up and move to open source five tests.
javax/swing/AncestorNotifier/4817630/bug4817630.java
javax/swing/BoxLayout/4191948/bug4191948.java
javax/swing/ComponentInputMap/4248723/bug4248723.java
javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java
javax/swing/DefaultButtonModel/4097723/b
On Wed, 13 Sep 2023 07:46:50 GMT, Alexey Ivanov wrote:
> The image in the [documentation for
> `Document.remove`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/Document.html#remove(int,int))
> looks as if the portion between the offsets 6 and 10 is removed. Ho
On Tue, 12 Sep 2023 04:45:51 GMT, Prasanta Sadhukhan
wrote:
> Test was run without waiting for UI to be made visible leading to
> IllegalComponentStateException.
> Used robot.delay consistent with other headful tests to made the test wait
> after UI is created and shown.
>
> Test passed in se
The image in the [documentation for
`Document.remove`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/Document.html#remove(int,int))
looks as if the portion between the offsets 6 and 10 is removed. However, the
entire region for _‘quick ’_ is highlighted.
I upd
On Fri, 8 Sep 2023 15:17:49 GMT, Abhishek Kumar wrote:
> Few closed JMenu swing tests are open sourced.
This pull request has now been integrated.
Changeset: fecd2fd8
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/fecd2fd8f26d0e8905a519e30e9aa171683c9df1
Stats: 35
JTextArea manual applet test converted to automated and opensourced
-
Commit messages:
- 8316154: Opensource JTextArea manual tests
Changes: https://git.openjdk.org/jdk/pull/15700/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15700&range=00
Issue: https://bugs.openjdk.or
On Thu, 7 Sep 2023 15:19:37 GMT, Abhishek Kumar wrote:
> Few closed JList and JMenubar swing tests are open sourced.
This pull request has now been integrated.
Changeset: bb6b3f24
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/bb6b3f2486b07a6ccdeea18519453e6d9c05c2c3
On Thu, 7 Sep 2023 18:57:50 GMT, Abhishek Kumar wrote:
> Few closed JFileChooser and other swing tests are open sourced.
This pull request has now been integrated.
Changeset: fe5ef5f2
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/fe5ef5f20dcf647b4ca30963b42fa01449f0d
On Wed, 13 Sep 2023 07:22:52 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JSpinner/bug4522737.java line 51:
>>
>>> 49: objectOutputStream = new
>>> ObjectOutputStream(byteArrayOutputStream);
>>> 50: objectOutputStream.writeObject(originalComponent);
>>> 51:
On Wed, 13 Sep 2023 06:32:54 GMT, Prasanta Sadhukhan
wrote:
>> Open source these Swing JSpinner related tests:
>>
>> javax/swing/JSpinner/4522737/bug4522737.java
>> javax/swing/JSpinner/4656590/bug4656590.java
>> javax/swing/JSpinner/4680204/bug4680204.java
>> javax/swing/JSpinner/4862257/bug48
52 matches
Mail list logo
