Re: RFR: 8316061: Open source several Swing RootPane and Slider related tests

2023-09-14 Thread Abhishek Kumar
On Thu, 14 Sep 2023 07:29:57 GMT, Tejesh R wrote: > Open sourcing these Swing RootPane and Slider related tests: > > javax/swing/JRootPane/4207333/bug4207333.java > javax/swing/JRootPane/4224113/bug4224113.java > javax/swing/JRootPane/4627806/bug4627806.java > javax/swing/JSlider/4200901/bug4200

Re: RFR: 8316104: Open source several Swing SplitPane and RadioButton related tests

2023-09-14 Thread Abhishek Kumar
On Thu, 14 Sep 2023 09:33:03 GMT, Tejesh R wrote: > Open sourcing these Swing SplitPane and RadioButton related tests: > > javax/swing/JSplitPane/4147653/bug4147653.java > javax/swing/JSplitPane/4870674/bug4870674.java > javax/swing/JRadioButton/4823809/bug4823809.java Do we need to add auto de

Re: RFR: 8316104: Open source several Swing SplitPane and RadioButton related tests

2023-09-14 Thread Abhishek Kumar
On Thu, 14 Sep 2023 09:33:03 GMT, Tejesh R wrote: > Open sourcing these Swing SplitPane and RadioButton related tests: > > javax/swing/JSplitPane/4147653/bug4147653.java > javax/swing/JSplitPane/4870674/bug4870674.java > javax/swing/JRadioButton/4823809/bug4823809.java test/jdk/javax/swing/JRad

Integrated: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests

2023-09-14 Thread Abhishek Kumar
On Thu, 14 Sep 2023 09:02:51 GMT, Abhishek Kumar wrote: > Few closed JFormattedTextField and JPopupMenu tests are open sourced. This pull request has now been integrated. Changeset: bfbc41c1 Author:Abhishek Kumar URL: https://git.openjdk.org/jdk/commit/bfbc41c1f177c7a2b8e91351ac41ea

Integrated: 8316106: Open source few swing JInternalFrame and JMenuBar tests

2023-09-14 Thread Abhishek Kumar
On Thu, 14 Sep 2023 08:05:58 GMT, Abhishek Kumar wrote: > Few closed JInternalFrame and JMenuBar swing tests are open sourced. This pull request has now been integrated. Changeset: 0775bf2f Author:Abhishek Kumar URL: https://git.openjdk.org/jdk/commit/0775bf2f0375b1bc63c187399cbc3fd

Integrated: 8315834: Open source several Swing JSpinner related tests

2023-09-14 Thread Tejesh R
On Tue, 12 Sep 2023 05:46:23 GMT, Tejesh R wrote: > Open source these Swing JSpinner related tests: > > javax/swing/JSpinner/4522737/bug4522737.java > javax/swing/JSpinner/4656590/bug4656590.java > javax/swing/JSpinner/4680204/bug4680204.java > javax/swing/JSpinner/4862257/bug4862257.java > java

Re: RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests [v2]

2023-09-14 Thread Tejesh R
On Fri, 15 Sep 2023 05:51:38 GMT, Abhishek Kumar wrote: >> Few closed JInternalFrame and JMenuBar swing tests are open sourced. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment update Marked as reviewed by

Re: RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests [v2]

2023-09-14 Thread Abhishek Kumar
On Fri, 15 Sep 2023 04:56:25 GMT, Tejesh R wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comment update > > test/jdk/javax/swing/JInternalFrame/bug4268949.java line 52: > >> 50: || >> !

Re: RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests [v2]

2023-09-14 Thread Abhishek Kumar
> Few closed JInternalFrame and JMenuBar swing tests are open sourced. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Review comment update - Changes: - all: https://git.openjdk.org/jdk/pull/15735/files - new: htt

Re: RFR: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests

2023-09-14 Thread Abhishek Kumar
On Fri, 15 Sep 2023 05:04:10 GMT, Tejesh R wrote: >> Few closed JFormattedTextField and JPopupMenu tests are open sourced. > > test/jdk/javax/swing/JFormattedTextField/bug4741926.java line 30: > >> 28: * @key headful >> 29: * @run main bug4741926 >> 30: */ > > Alignment can corrected. I gue

Re: RFR: 8315669: Open source several Swing PopupMenu related tests [v2]

2023-09-14 Thread Tejesh R
> Open source these Swing PopupMenu related tests: > > javax/swing/JPopupMenu/4236750/bug4236750.java > javax/swing/JPopupMenu/4321273/bug4321273.java > javax/swing/JPopupMenu/4711693/bug4711693.java > javax/swing/JPopupMenu/4962731/bug4962731.java > javax/swing/JPopupMenu/4966109/bug4966109.java

Re: RFR: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests

2023-09-14 Thread Tejesh R
On Thu, 14 Sep 2023 09:02:51 GMT, Abhishek Kumar wrote: > Few closed JFormattedTextField and JPopupMenu tests are open sourced. Marked as reviewed by tr (Committer). test/jdk/javax/swing/JFormattedTextField/bug4741926.java line 30: > 28: * @key headful > 29: * @run main bug4741926 > 30: */

Re: RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests

2023-09-14 Thread Tejesh R
On Thu, 14 Sep 2023 08:05:58 GMT, Abhishek Kumar wrote: > Few closed JInternalFrame and JMenuBar swing tests are open sourced. test/jdk/javax/swing/JInternalFrame/bug4309079.java line 58: > 56: try { > 57: Robot robot = new Robot(); > 58: robot.setAutoDelay(100);

Re: RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests

2023-09-14 Thread Tejesh R
On Thu, 14 Sep 2023 08:05:58 GMT, Abhishek Kumar wrote: > Few closed JInternalFrame and JMenuBar swing tests are open sourced. test/jdk/javax/swing/JInternalFrame/bug4268949.java line 52: > 50: || > !((if2.getContentPane().getBackground()).equals(Color.blue)) > 51:

Integrated: 8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again

2023-09-14 Thread Jayathirth D V
On Fri, 15 Sep 2023 02:41:19 GMT, Jayathirth D V wrote: > java/awt/Mouse/EnterExitEvents/DragWindowTest.java was de-problemlisted > wrongly under https://bugs.openjdk.org/browse/JDK-8315990. > This is creating lot of noise in our CI. Need to problemlist this test again. This pull request has no

Re: RFR: 8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again

2023-09-14 Thread Jayathirth D V
On Fri, 15 Sep 2023 02:57:10 GMT, David Holmes wrote: >> java/awt/Mouse/EnterExitEvents/DragWindowTest.java was de-problemlisted >> wrongly under https://bugs.openjdk.org/browse/JDK-8315990. >> This is creating lot of noise in our CI. Need to problemlist this test again. > > Looks good and trivi

Re: RFR: 8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again

2023-09-14 Thread David Holmes
On Fri, 15 Sep 2023 02:41:19 GMT, Jayathirth D V wrote: > java/awt/Mouse/EnterExitEvents/DragWindowTest.java was de-problemlisted > wrongly under https://bugs.openjdk.org/browse/JDK-8315990. > This is creating lot of noise in our CI. Need to problemlist this test again. Looks good and trivial.

RFR: 8316326: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all again

2023-09-14 Thread Jayathirth D V
java/awt/Mouse/EnterExitEvents/DragWindowTest.java was de-problemlisted wrongly under https://bugs.openjdk.org/browse/JDK-8315990. This is creating lot of noise in our CI. Need to problemlist this test again. - Commit messages: - 8316326: ProblemList java/awt/Mouse/EnterExitEvents/D

Integrated: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-09-14 Thread Justin Lu
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote: > JDK .properties files still use ISO-8859-1 encoding with escape sequences. It > would improve readability to see the native characters instead of escape > sequences (especially for the L10n process). The majority of files changed > are local

Integrated: JDK-8315731: Open source several Swing Text related tests

2023-09-14 Thread Harshitha Onkar
On Tue, 12 Sep 2023 21:32:58 GMT, Harshitha Onkar wrote: > Open sourcing the following tests - > > 1. javax/swing/text/CompositeView/4398059/bug4398059.java > 2. javax/swing/text/DefaultCaret/4197894/bug4197894.java > 3. javax/swing/text/DefaultCaret/4203175/bug4203175.java > 4. javax/swing/text

Re: RFR: 8315669: Open source several Swing PopupMenu related tests

2023-09-14 Thread Damon Nguyen
On Wed, 13 Sep 2023 09:19:27 GMT, Tejesh R wrote: > Open source these Swing PopupMenu related tests: > > javax/swing/JPopupMenu/4236750/bug4236750.java > javax/swing/JPopupMenu/4321273/bug4321273.java > javax/swing/JPopupMenu/4711693/bug4711693.java > javax/swing/JPopupMenu/4962731/bug4962731.ja

RFR: 8316056: Open source several Swing JTree tests

2023-09-14 Thread Damon Nguyen
These are the tests being converted: javax/swing/JTree/4210432/bug4210432.java javax/swing/JTree/4213868/bug4213868.java javax/swing/JTree/4224491/bug4224491.java javax/swing/JTree/4237370/bug4237370.java javax/swing/JTree/4662505/bug4662505.java - Commit messages: - Initial test co

Re: RFR: 8315871: Opensource five more Swing regression tests [v2]

2023-09-14 Thread Damon Nguyen
On Thu, 14 Sep 2023 15:27:48 GMT, Alexander Zuev wrote: >> Clean up and move to open source five tests. >> javax/swing/AncestorNotifier/4817630/bug4817630.java >> javax/swing/BoxLayout/4191948/bug4191948.java >> javax/swing/ComponentInputMap/4248723/bug4248723.java >> javax/swing/DefaultBoundedRa

RFR: 8315952: Open source several Swing JToolbar JTooltip JTree tests

2023-09-14 Thread Damon Nguyen
These are the tests being converted: javax/swing/JToolBar/4368050/bug4368050.java javax/swing/JToolBar/4465534/bug4465534.java javax/swing/JToolBar/4700351/bug4700351.java javax/swing/JToolTip/4107843/bug4107843.java javax/swing/JTree/4161685/bug4161685.java - Commit messages: - Ini

RFR: 8315965: Open source various AWT applet tests

2023-09-14 Thread Alexander Zvegintsev
Open sourcing few applet tests: java/awt/ScrollPane/ScrollPaneTest.java java/awt/TextArea/Length.java java/awt/Window/WindowOwner.java java/awt/font/Rotate/RotateTest3.java - Commit messages: - initial Changes: https://git.openjdk.org/jdk/pull/15754/files Webrev: https://webrevs.o

Re: RFR: JDK-8315889: Open source several Swing HTMLDocument related tests

2023-09-14 Thread Alexander Zvegintsev
On Tue, 12 Sep 2023 17:05:47 GMT, Harshitha Onkar wrote: > Following tests are being open sourced as part of this PR. > > javax/swing/text/html/HTMLDocument/4251593/bug4251593.java > javax/swing/text/html/HTMLDocument/4687405/bug4687405.java > javax/swing/text/html/HTMLDocument/4226914/bug422691

RFR: JDK-8315951: Open source several Swing HTMLEditorKit related tests

2023-09-14 Thread Harshitha Onkar
Following tests are open sourced as part of this PR. 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java 3. javax/swing/text/html/HTMLEditorKit/4230197/bug4230197.java 4. javax/swing/text/html/HTMLEditorKit/4238223/bug4238223.jav

Re: RFR: 4622866: javax.swing.text.Document.remove(int, int) has a misleading picture [v2]

2023-09-14 Thread Alexey Ivanov
> The image in the [documentation for > `Document.remove`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/Document.html#remove(int,int)) > looks as if the portion between the offsets 6 and 10 is removed. However, > the entire region for _‘quick ’_ is highlighted

Integrated: JDK-8315824: Open source several Swing Text/HTML related tests

2023-09-14 Thread Harshitha Onkar
On Tue, 12 Sep 2023 00:34:16 GMT, Harshitha Onkar wrote: > This PR open sources few Swing Text/HTML related tests. This pull request has now been integrated. Changeset: c11f8352 Author:Harshitha Onkar URL: https://git.openjdk.org/jdk/commit/c11f8352e96a01b39e54080716030ec96f717cae S

RFR: 8315883: Open source several Swing JToolbar tests

2023-09-14 Thread Damon Nguyen
These are the tests being converted: javax/swing/JToolBar/4138694/bug4138694.java javax/swing/JToolBar/4140421/bug4140421.java javax/swing/JToolBar/4196662/bug4196662.java javax/swing/JToolBar/4243930/bug4243930.java - Commit messages: - Initial test conversion to open Changes: htt

RFR: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests

2023-09-14 Thread Damon Nguyen
These are the tests being converted: javax/swing/JTabbedPane/4703690/bug4703690.java javax/swing/JTabbedPane/GetComponentAt/GetComponentAtTest.java javax/swing/JTabbedPane/ReplaceCompTab/ReplaceCompTab.java javax/swing/JTextArea/4849868/bug4849868.java javax/swing/JTextField/4244613/bug4244613.jav

Integrated: 8316242: Opensource SwingGraphics manual test

2023-09-14 Thread Prasanta Sadhukhan
On Thu, 14 Sep 2023 13:06:18 GMT, Prasanta Sadhukhan wrote: > Swing Translate manual applet test is opensourced This pull request has now been integrated. Changeset: a57b9dab Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/a57b9dab6c02c313f3975f47d502dae270c67508

Re: RFR: 8316242: Opensource SwingGraphics manual test

2023-09-14 Thread Abhishek Kumar
On Thu, 14 Sep 2023 13:06:18 GMT, Prasanta Sadhukhan wrote: > Swing Translate manual applet test is opensourced LGTM. - Marked as reviewed by abhiscxk (Committer). PR Review: https://git.openjdk.org/jdk/pull/15741#pullrequestreview-1627238953

Re: RFR: 8316104: Open source several Swing SplitPane and RadioButton related tests

2023-09-14 Thread Alexander Zuev
On Thu, 14 Sep 2023 09:33:03 GMT, Tejesh R wrote: > Open sourcing these Swing SplitPane and RadioButton related tests: > > javax/swing/JSplitPane/4147653/bug4147653.java > javax/swing/JSplitPane/4870674/bug4870674.java > javax/swing/JRadioButton/4823809/bug4823809.java Looks fine -

Re: RFR: 8316242: Opensource SwingGraphics manual test

2023-09-14 Thread Alexander Zuev
On Thu, 14 Sep 2023 13:06:18 GMT, Prasanta Sadhukhan wrote: > Swing Translate manual applet test is opensourced Looks good - Marked as reviewed by kizune (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15741#pullrequestreview-1627224077

Re: RFR: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests

2023-09-14 Thread Alexander Zuev
On Thu, 14 Sep 2023 09:02:51 GMT, Abhishek Kumar wrote: > Few closed JFormattedTextField and JPopupMenu tests are open sourced. Looks good to me. - Marked as reviewed by kizune (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15737#pullrequestreview-1627215450

Re: RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests

2023-09-14 Thread Alexander Zuev
On Thu, 14 Sep 2023 08:05:58 GMT, Abhishek Kumar wrote: > Few closed JInternalFrame and JMenuBar swing tests are open sourced. LGTM - Marked as reviewed by kizune (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15735#pullrequestreview-1627204092

Re: RFR: 8316061: Open source several Swing RootPane and Slider related tests

2023-09-14 Thread Alexander Zuev
On Thu, 14 Sep 2023 07:29:57 GMT, Tejesh R wrote: > Open sourcing these Swing RootPane and Slider related tests: > > javax/swing/JRootPane/4207333/bug4207333.java > javax/swing/JRootPane/4224113/bug4224113.java > javax/swing/JRootPane/4627806/bug4627806.java > javax/swing/JSlider/4200901/bug4200

Re: RFR: 8315981: Opensource five more random Swing tests [v2]

2023-09-14 Thread Alexander Zuev
> Clean up and open source five tests: > javax/swing/DefaultListCellRenderer/4180943/bug4180943.java > javax/swing/DefaultListModel/4466250/bug4466250.java > javax/swing/DefaultListSelectionModel/4140619/bug4140619.java > javax/swing/DefaultListSelectionModel/4177723/bug4177723.java > javax/swing/I

Re: RFR: 8315871: Opensource five more Swing regression tests [v2]

2023-09-14 Thread Alexander Zuev
> Clean up and move to open source five tests. > javax/swing/AncestorNotifier/4817630/bug4817630.java > javax/swing/BoxLayout/4191948/bug4191948.java > javax/swing/ComponentInputMap/4248723/bug4248723.java > javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java > javax/swing/DefaultButtonMod

Re: RFR: 8294156: Demo positioning of multiple test windows [v2]

2023-09-14 Thread Alexey Ivanov
On Wed, 13 Sep 2023 21:17:46 GMT, Alexander Zvegintsev wrote: >> Alexey Ivanov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8294156: Additional layouts for vertically positioned test windows > > test/jdk/java/awt/Window/8294156/manyW

RFR: 8316242: Opensource SwingGraphics manual test

2023-09-14 Thread Prasanta Sadhukhan
Swing Translate manual applet test is opensourced - Commit messages: - 8316242: Opensource SwingGraphics manual test Changes: https://git.openjdk.org/jdk/pull/15741/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15741&range=00 Issue: https://bugs.openjdk.org/browse/JDK-83

Integrated: 8316164: Opensource JMenuBar manual test

2023-09-14 Thread Prasanta Sadhukhan
On Wed, 13 Sep 2023 13:00:28 GMT, Prasanta Sadhukhan wrote: > JMenubar manual applet test converted to automated and opensourced This pull request has now been integrated. Changeset: 8f4dfc44 Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/8f4dfc443ba5820f5799fff1

Integrated: 8316154: Opensource JTextArea manual tests

2023-09-14 Thread Prasanta Sadhukhan
On Wed, 13 Sep 2023 07:32:04 GMT, Prasanta Sadhukhan wrote: > JTextArea manual applet test converted to automated and opensourced This pull request has now been integrated. Changeset: 33c62e4f Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/33c62e4fffe33a7593fd0c0

Re: RFR: 8315834: Open source several Swing JSpinner related tests [v3]

2023-09-14 Thread Abhishek Kumar
On Thu, 14 Sep 2023 09:35:37 GMT, Tejesh R wrote: >> Open source these Swing JSpinner related tests: >> >> javax/swing/JSpinner/4522737/bug4522737.java >> javax/swing/JSpinner/4656590/bug4656590.java >> javax/swing/JSpinner/4680204/bug4680204.java >> javax/swing/JSpinner/4862257/bug4862257.java

Re: RFR: 8316164: Opensource JMenuBar manual test

2023-09-14 Thread Jayathirth D V
On Wed, 13 Sep 2023 13:00:28 GMT, Prasanta Sadhukhan wrote: > JMenubar manual applet test converted to automated and opensourced Marked as reviewed by jdv (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15717#pullrequestreview-1626489285

RFR: 8316104: Open source several Swing SplitPane and RadioButton related tests

2023-09-14 Thread Tejesh R
Open sourcing these Swing SplitPane and RadioButton related tests: javax/swing/JSplitPane/4147653/bug4147653.java javax/swing/JSplitPane/4870674/bug4870674.java javax/swing/JRadioButton/4823809/bug4823809.java - Commit messages: - Open sourcing few SplitPane and RadioButton test Ch

Re: RFR: 8315834: Open source several Swing JSpinner related tests [v3]

2023-09-14 Thread Tejesh R
> Open source these Swing JSpinner related tests: > > javax/swing/JSpinner/4522737/bug4522737.java > javax/swing/JSpinner/4656590/bug4656590.java > javax/swing/JSpinner/4680204/bug4680204.java > javax/swing/JSpinner/4862257/bug4862257.java > javax/swing/JSpinner/5104421/bug5104421.java Tejesh R h

Re: RFR: 8316154: Opensource JTextArea manual tests

2023-09-14 Thread Jayathirth D V
On Wed, 13 Sep 2023 07:32:04 GMT, Prasanta Sadhukhan wrote: > JTextArea manual applet test converted to automated and opensourced Marked as reviewed by jdv (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15700#pullrequestreview-1626447002

Re: RFR: 8315834: Open source several Swing JSpinner related tests [v2]

2023-09-14 Thread Tejesh R
On Thu, 14 Sep 2023 09:08:05 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix > > test/jdk/javax/swing/JSpinner/bug4656590.java line 110: > >> 108: System.out.println("Test Pa

RFR: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests

2023-09-14 Thread Abhishek Kumar
Few closed JFormattedTextField and JPopupMenu tests are open sourced. - Commit messages: - Open source few swing JFormattedTextField and JPopupMenu tests Changes: https://git.openjdk.org/jdk/pull/15737/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15737&range=00 Issue: h

Re: RFR: 8315834: Open source several Swing JSpinner related tests [v2]

2023-09-14 Thread Abhishek Kumar
On Wed, 13 Sep 2023 09:10:18 GMT, Tejesh R wrote: >> Open source these Swing JSpinner related tests: >> >> javax/swing/JSpinner/4522737/bug4522737.java >> javax/swing/JSpinner/4656590/bug4656590.java >> javax/swing/JSpinner/4680204/bug4680204.java >> javax/swing/JSpinner/4862257/bug4862257.java

RFR: 8316106: Open source few swing JInternalFrame and JMenuBar tests

2023-09-14 Thread Abhishek Kumar
Few closed JInternalFrame and JMenuBarswing tests are open sourced. - Commit messages: - Open source few swing JInternalFrame and JMenuBar tests Changes: https://git.openjdk.org/jdk/pull/15735/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15735&range=00 Issue: https://bu

RFR: 8316061: Open source several Swing RootPane and Slider related tests

2023-09-14 Thread Tejesh R
Open sourcing these Swing RootPane and Slider related tests: javax/swing/JRootPane/4207333/bug4207333.java javax/swing/JRootPane/4224113/bug4224113.java javax/swing/JRootPane/4627806/bug4627806.java javax/swing/JSlider/4200901/bug4200901.java javax/swing/JSlider/4203754/bug4203754.java --