Integrated: 8316053: Open some swing tests 3

2023-09-22 Thread Alisen Chung
On Wed, 20 Sep 2023 22:30:04 GMT, Alisen Chung wrote: > Moving tests from closed to open > 8 javax/swing/SwingGraphics/VolatileBackBuffer/MultimonVImage.java > 9 javax/swing/SwingUtilities/4859570/bug4859570.java > 10 javax/swing/SwingUtilities/4936652/bug4936652.java > 11 javax/swing/ToolTipMana

Integrated: 8315882: Open some swing tests 2

2023-09-22 Thread Alisen Chung
On Wed, 20 Sep 2023 22:19:42 GMT, Alisen Chung wrote: > Moving some tests to open > 5 javax/swing/ScrollPaneLayout/4688907/bug4688907.java > 6 javax/swing/SpringLayout/4756178/bug4756178.java > 7 javax/swing/SpringLayout/4803649/bug4803649.java This pull request has now been integrated. Changes

Re: RFR: 8315882: Open some swing tests 2 [v6]

2023-09-22 Thread Alisen Chung
> Moving some tests to open > 5 javax/swing/ScrollPaneLayout/4688907/bug4688907.java > 6 javax/swing/SpringLayout/4756178/bug4756178.java > 7 javax/swing/SpringLayout/4803649/bug4803649.java Alisen Chung has updated the pull request incrementally with one additional commit since the last revision

Re: RFR: 8316146: Open some swing tests 4

2023-09-22 Thread Harshitha Onkar
On Thu, 21 Sep 2023 22:00:27 GMT, Alisen Chung wrote: > Opening closed tests: > 12 javax/swing/ToolTipManager/5078214/bug5078214.java > 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java > 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java > 15 javax/swing/plaf/metal/430

Re: RFR: 8315882: Open some swing tests 2 [v5]

2023-09-22 Thread Alisen Chung
> Moving some tests to open > 5 javax/swing/ScrollPaneLayout/4688907/bug4688907.java > 6 javax/swing/SpringLayout/4756178/bug4756178.java > 7 javax/swing/SpringLayout/4803649/bug4803649.java Alisen Chung has updated the pull request incrementally with one additional commit since the last revision

Integrated: 8315825: Open some swing tests

2023-09-22 Thread Alisen Chung
On Wed, 20 Sep 2023 00:57:57 GMT, Alisen Chung wrote: > Opening some swing tests: > 1 javax/swing/LayoutComparator/4907772/bug4907772.java > 2 javax/swing/LayoutComparator/4979794/bug4979794.java > 3 javax/swing/LegacyGlueFocusTraversalPolicy/4765272/bug4765272.java > 4 javax/swing/RootPaneChecki

Re: RFR: 8315825: Open some swing tests [v4]

2023-09-22 Thread Alisen Chung
> Opening some swing tests: > 1 javax/swing/LayoutComparator/4907772/bug4907772.java > 2 javax/swing/LayoutComparator/4979794/bug4979794.java > 3 javax/swing/LegacyGlueFocusTraversalPolicy/4765272/bug4765272.java > 4 javax/swing/RootPaneChecking/RootPaneChecking.java Alisen Chung has updated the p

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-22 Thread Alexander Zvegintsev
> Open sourcing several manual applet tests > > > test/jdk/java/awt/Frame/DefaultSizeTest.java > test/jdk/java/awt/LightweightComponent/LightweightCliprect.java > test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java > test/jdk/javax/swing/JFrame/DefaultCloseOperation.java Alexander Zvegintsev h

Integrated: 8316206: Test StretchedFontTest.java fails for Baekmuk font

2023-09-22 Thread Alexey Ivanov
On Tue, 19 Sep 2023 13:41:27 GMT, Alexey Ivanov wrote: > **Root cause** > > The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has > zero length. > > The test fails if the right half of the image with the rendered glyph > contains only pixels of background colour. In this c

Re: RFR: 8316206: Test StretchedFontTest.java fails for Baekmuk font [v2]

2023-09-22 Thread Goetz Lindenmaier
On Wed, 20 Sep 2023 14:07:17 GMT, Alexey Ivanov wrote: >> **Root cause** >> >> The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has >> zero length. >> >> The test fails if the right half of the image with the rendered glyph >> contains only pixels of background colour. In

Re: RFR: 8316146: Open some swing tests 4

2023-09-22 Thread Alexey Ivanov
On Thu, 21 Sep 2023 22:36:16 GMT, Harshitha Onkar wrote: >> Opening closed tests: >> 12 javax/swing/ToolTipManager/5078214/bug5078214.java >> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java >> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java >> 15 javax/swing/plaf/m

Re: RFR: 8316556: Fix typos in java.desktop

2023-09-22 Thread Alexey Ivanov
On Sat, 16 Sep 2023 16:22:40 GMT, Andrey Turbanov wrote: > PR with non-swing changes extracted from initial #14847 src/java.desktop/unix/classes/sun/awt/X11/XMenuBarPeer.java line 132: > 130: * need to have somewhat strange behaviour > 131: * deduced from java.awt.MenuBar. > 132:

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-22 Thread Alexey Ivanov
On Fri, 22 Sep 2023 07:12:08 GMT, Prasanta Sadhukhan wrote: > I guess in test, resource leak probably wouldn't matter… No, it wouldn't. Yet someone could later copy the code and use file streams where closing the streams matters. Always following the pattern is safer. - PR Review

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-22 Thread Alexey Ivanov
On Fri, 22 Sep 2023 07:18:09 GMT, Prasanta Sadhukhan wrote: >> After the first time a JTableHeader is serialized, it no longer will >> uninstall its UI upon subsequent serializations. >> This happens for classes that use the BasicTableHeaderUI class. Any LAF that >> extends the BasicTableHeade

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-22 Thread Prasanta Sadhukhan
On Mon, 11 Sep 2023 19:05:25 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> try-with-resource use > > test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 46: > >> 44:

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI [v3]

2023-09-22 Thread Prasanta Sadhukhan
> After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI like SynthTableHeaderUI and > WindowsTableHeaderUI will get an

Re: RFR: 8316211: Open source several manual applet tests [v2]

2023-09-22 Thread Andrey Turbanov
On Wed, 20 Sep 2023 01:46:35 GMT, Alexander Zvegintsev wrote: >> Open sourcing several manual applet tests >> >> >> test/jdk/java/awt/Frame/DefaultSizeTest.java >> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java >> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java >> test/j