On Thu, 12 Oct 2023 17:54:07 GMT, Alexander Zuev wrote:
> As a workaround changing the method that filters out valid resolutions to not
> allow resolutions unsupported by Apple m1/m2 chips to be reported back to
> Java side.
>
> Also removing test from problem list as it should pass again now.
On Wed, 11 Oct 2023 17:49:14 GMT, Mikael Vidstedt wrote:
> macOS 10.x is no longer receiving updates - the most recent/last release was
> 10.15.7 back in July of 2022. It's time to bump the target macOS version
> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>
> This change
Adds additional test cases to
`javax/swing/text/html/CSS/CSSAttributeEqualityBug.java`.
Currently, CSS parser in Java allows space between the number and the unit or
percent. This is what the additional test cases verify.
There's also one additional case for `border-width: medium`.
---
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was
>> 10.15.7 back in July of 2022. It's time to bump the target macOS version
>> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>>
>> This ch
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was
>> 10.15.7 back in July of 2022. It's time to bump the target macOS version
>> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>>
>> This ch
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was
>> 10.15.7 back in July of 2022. It's time to bump the target macOS version
>> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>>
>> This ch
> macOS 10.x is no longer receiving updates - the most recent/last release was
> 10.15.7 back in July of 2022. It's time to bump the target macOS version
> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>
> This change updates the target version for macosx-x64 to 11.00.00, whic
> macOS 10.x is no longer receiving updates - the most recent/last release was
> 10.15.7 back in July of 2022. It's time to bump the target macOS version
> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>
> This change updates the target version for macosx-x64 to 11.00.00, whic
On Wed, 11 Oct 2023 05:14:11 GMT, Tejesh R wrote:
>> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
>> sub-components are unaffected since the sub-components didn't set/unset
>> enabled explicitly. The fix address the issue and sets the Enabled flag to
>> each sub-components
On Fri, 13 Oct 2023 15:07:30 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Revivers,
>
> Part of stability improvement for the test case **WheelModifier.java** I have
> moved _getLocationOnScreen()_ and _getSize()_ into EDT, part of warning
> removal updated _BUTTON1_MASK_ with _BUTTON1_DOWN_MA
Hi Revivers,
Part of stability improvement for the test case **WheelModifier.java** I have
moved _getLocationOnScreen()_ and _getSize()_ into EDT, part of warning removal
updated _BUTTON1_MASK_ with _BUTTON1_DOWN_MASK_
Please review and let me know your suggestions.
-
Commit messa
> Please review this patch that removes a number of unused exports from
> java.desktop native libraries.
>
> In most cases I removed JNIEXPORT from methods and variables that are only
> used within a single shared library. Other than that:
> - removed `getSunFontIDs` that was reportedly used by
On Fri, 13 Oct 2023 14:50:03 GMT, Alexey Ivanov wrote:
>> Sounds reasonable. Should I move the cleanup of Color as well?
>
>> Should I move the cleanup of Color as well?
>
> Removing `colorValueID` could be left here, I think: it removes an exported
> symbol which is no longer used.
>
> In add
On Fri, 13 Oct 2023 15:02:10 GMT, Daniel Jeliński wrote:
> …will file a follow-up PR once this one is merged
You can submit it right away, so that we'll not forget about it.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13261#discussion_r1358385429
On Thu, 12 Oct 2023 22:01:22 GMT, Damon Nguyen wrote:
>> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 103:
>>
>>> 101: !p.equals(endPoint) && !incorrectActionDetected;
>>> 102: p.translate(sign(endPoint.x - p.x),
>>> 103: sig
On Fri, 13 Oct 2023 14:38:59 GMT, Daniel Jeliński wrote:
> Should I move the cleanup of Color as well?
Removing `colorValueID` could be left here, I think: it removes an exported
symbol which is no longer used.
In addition to it, it makes `Java_java_awt_Color_initIDs` empty.
-
PR
On Fri, 13 Oct 2023 07:50:12 GMT, Daniel Jeliński wrote:
>> ~Good point. I only checked the Linux exports/imports, will check the
>> Windows-specific exports now.~
>
> Wait a sec, these symbols are removed from the export list in this PR. Are
> you saying that you still see them?
I saw these s
On Fri, 13 Oct 2023 14:27:07 GMT, Alexey Ivanov wrote:
>> Found and removed a few more initIDs methods that were empty on all
>> platforms.
>
>> Found and removed a few more initIDs methods that were empty on all
>> platforms.
>
> It could be a better idea to move this clean up to a separate b
On Fri, 13 Oct 2023 11:17:31 GMT, Daniel Jeliński wrote:
> Found and removed a few more initIDs methods that were empty on all platforms.
It could be a better idea to move this clean up to a separate bugid with
appropriate title. After all, removing empty initIDs affects Java sources as
well.
On Tue, 10 May 2022 19:03:23 GMT, Damon Nguyen wrote:
>> The insets for buttons were incorrect for L&Fs except for Aqua when the text
>> is set to HTML. This was fixed in Aqua by adding a conditional to check for
>> the BasicHTML property key in the button component. This same logic can be
>>
On Thu, 12 Oct 2023 17:12:05 GMT, Alexey Ivanov wrote:
> **Cleanup**
>
> A trivial modification which removes `class="centered"` from one of the
> `` elements. It's a remnant from a previous version of the image.
>
> Classes aren't used, all `` elements are centered.
This pull request has now
On Wed, 11 Oct 2023 05:14:11 GMT, Tejesh R wrote:
>> Invoking `setEnabled(false)` on an instance of `JFileChooser` the
>> sub-components are unaffected since the sub-components didn't set/unset
>> enabled explicitly. The fix address the issue and sets the Enabled flag to
>> each sub-components
On Fri, 13 Oct 2023 07:02:16 GMT, Daniel Jeliński wrote:
>> src/java.desktop/unix/native/libawt/awt/initIDs.c line 47:
>>
>>> 45: (JNIEnv *env, jclass clazz)
>>> 46: {
>>> 47: }
>>
>> Shall we remove `Color.initIDs`? Its implementation is now empty for all
>> platforms.
>
> Sure, will do.
F
On Thu, 5 Oct 2023 16:29:26 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within a single shared library. Other than
> Please review this patch that removes a number of unused exports from
> java.desktop native libraries.
>
> In most cases I removed JNIEXPORT from methods and variables that are only
> used within a single shared library. Other than that:
> - removed `getSunFontIDs` that was reportedly used by
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote:
> For stroked shapes (no Renderer use), the min-join-error check is disabled.
> Added new jtreg test to verify join using pixel counts
@johanvos could you review this fix?
-
PR Comment: https://git.openjdk.org/jdk/pull/16002#i
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Thu, 12 Oct 2023 16:31:38 GMT, Prasanta Sadhukhan
wrote:
> Yes, known issue...please refer
> [JDK-8298796](https://bugs.openjdk.org/browse/JDK-8298796)
As already mentioned above, this are known issues and not caused by this PR..
This issues will be investigated as part of that JBS...
On Thu, 12 Oct 2023 09:53:55 GMT, Alexey Ivanov wrote:
>> Did further investigation on JDK-7116070 (name truncation issue) and found
>> its [MS
>> structure](https://learn.microsoft.com/en-us/windows-hardware/drivers/audio/extended-capabilities-from-a-wdm-audio-driver)
>> limitation, this stru
On Fri, 13 Oct 2023 07:50:17 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named
On Fri, 13 Oct 2023 07:01:08 GMT, Daniel Jeliński wrote:
>> I totally understand this. However, Windows specific symbols:
>>
>>98 000380A0 GDIWinSD_InitDC
>> 109 000385F0 GDIWindowSurfaceData_GetComp
>> 11A 000386C0 GDIWindowSurfaceData_GetOps
>>
> This is referenced in Java Bug Database as
> - [JDK-8292276 : Add named colors from CSS Color Module Level
> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>
> This is tracked in JBS as
> - [JDK-8292276 : Add named colors from CSS Color Module Level
> 4](https://bugs.openjdk.ja
On Wed, 11 Oct 2023 17:28:07 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> com
On Thu, 12 Oct 2023 10:00:15 GMT, Alexey Ivanov wrote:
>> Keep in mind that on Linux libawt is split into libawt, libawt_headless and
>> libawt_xawt, and the export/import dependencies are different.
>
> I totally understand this. However, Windows specific symbols:
>
>98 000380A
34 matches
Mail list logo
