Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v3]

2023-10-23 Thread Alexey Ivanov
On Mon, 23 Oct 2023 20:59:49 GMT, Alexey Ivanov wrote: >>> > Shouldn't we mention here a window added by `testUI` via builder? >>> >>> I don't think it's necessary: the builder uses `addTestWindow` under the >>> hood. It's the builder that requires documentation. >>> >>> In fact, the entire cl

Re: RFR: 8294158: HTML formatting for PassFailJFrame instructions

2023-10-23 Thread Alexey Ivanov
On Wed, 20 Sep 2023 18:05:31 GMT, Phil Race wrote: >> I know HTML is *not case sensitive*. It's just HTML tags are always in lower >> case in recent years. >> >>> But I agree that this can be helpful for a certain amount of consistency >>> across tests(they can still use other tags in uppercas

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v3]

2023-10-23 Thread Alexey Ivanov
On Wed, 20 Sep 2023 18:12:25 GMT, Phil Race wrote: >>> Shouldn't we mention here a window added by `testUI` via builder? >> >> I don't think it's necessary: the builder uses `addTestWindow` under the >> hood. It's the builder that requires documentation. >> >> In fact, the entire class require

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2023-10-23 Thread ScientificWare
On Mon, 23 Oct 2023 12:04:10 GMT, Alexey Ivanov wrote: > What purpose does this distinction serve? Definitely an application developer and because it's the context of this HTML implementation, may I preserve this distinction ? > This actually raises another question: what if altAtt isn't provi

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v3]

2023-10-23 Thread Alexey Ivanov
> This enhances the `Builder` pattern added in > [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method > `testUI` which allows passing a lambda expression or a method reference to > create *the test UI window*. > > The `PassFailJFrame` will automatically call the method o

RFR: JDK-8313643: Update HarfBuzz to 8.2.2

2023-10-23 Thread Harshitha Onkar
Harfbuzz upgraded from 7.2.0 to 8.2.2 - 3 new files added - hb-subset-instancer-solver.cc, hb-subset-instancer-solver.hh, hb-subset-plan-member-list.hh - 2 files deleted - hb-subset-cff1.hh, hb-subset-cff1.hh - 173 files modified. - Commit messages: - .md file - modified files -

Re: RFR: 8318100: Remove redundant check for Metal support

2023-10-23 Thread Phil Race
On Mon, 23 Oct 2023 16:46:24 GMT, Jayathirth D V wrote: > We have updated minimum macOS version on which JDK can be used to macOS 11 > and we have check to enable metal pipeline only when macOS version is >=10.14. > > Since minimum macOS version is updated we don't need this check now. > Remove

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v39]

2023-10-23 Thread ScientificWare
On Fri, 13 Oct 2023 07:50:17 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named

Re: RFR: 8169475 : WheelModifier.java fails by timeout [v2]

2023-10-23 Thread Alexey Ivanov
On Mon, 23 Oct 2023 03:28:00 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have added additional CountDownLatch for making sure button is visible >> before proceeding,(observe this was one of the key reason for failure) so >> this helps to improve test case stability. Modifi

Re: RFR: 8169475 : WheelModifier.java fails by timeout [v2]

2023-10-23 Thread Alexey Ivanov
On Mon, 23 Oct 2023 03:28:00 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have added additional CountDownLatch for making sure button is visible >> before proceeding,(observe this was one of the key reason for failure) so >> this helps to improve test case stability. Modifi

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v39]

2023-10-23 Thread ScientificWare
On Fri, 13 Oct 2023 07:50:17 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named

Re: RFR: 8318100: Remove redundant check for Metal support

2023-10-23 Thread Sergey Bylokhov
On Mon, 23 Oct 2023 16:46:24 GMT, Jayathirth D V wrote: > We have updated minimum macOS version on which JDK can be used to macOS 11 > and we have check to enable metal pipeline only when macOS version is >=10.14. > > Since minimum macOS version is updated we don't need this check now. > Remove

Re: RFR: 8305321: Remove unused exports in java.desktop [v5]

2023-10-23 Thread Alexey Ivanov
On Fri, 13 Oct 2023 15:19:53 GMT, Daniel Jeliński wrote: >> Please review this patch that removes a number of unused exports from >> java.desktop native libraries. >> >> In most cases I removed JNIEXPORT from methods and variables that are only >> used within a single shared library. Other tha

Re: RFR: 8305321: Remove unused exports in java.desktop [v5]

2023-10-23 Thread Daniel Jeliński
On Fri, 13 Oct 2023 15:19:53 GMT, Daniel Jeliński wrote: >> Please review this patch that removes a number of unused exports from >> java.desktop native libraries. >> >> In most cases I removed JNIEXPORT from methods and variables that are only >> used within a single shared library. Other tha

RFR: 8318100: Remove redundant check for Metal support

2023-10-23 Thread Jayathirth D V
We have updated minimum macOS version on which JDK can be used to macOS 11 and we have check to enable metal pipeline only when macOS version is >=10.14. Since minimum macOS version is updated we don't need this check now. Removed redundant check and ran all clientlibs tests on CI for verificatio

Re: RFR: 8305321: Remove unused exports in java.desktop [v5]

2023-10-23 Thread Alexey Ivanov
On Fri, 13 Oct 2023 15:19:53 GMT, Daniel Jeliński wrote: >> Please review this patch that removes a number of unused exports from >> java.desktop native libraries. >> >> In most cases I removed JNIEXPORT from methods and variables that are only >> used within a single shared library. Other tha

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v39]

2023-10-23 Thread Phil Race
On Fri, 13 Oct 2023 07:50:17 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named

Re: RFR: 8305321: Remove unused exports in java.desktop [v5]

2023-10-23 Thread Alexey Ivanov
On Mon, 23 Oct 2023 15:46:26 GMT, Alexey Ivanov wrote: > `jvm`: I think it was discussed already. I see it's exported from > `libawt.so`, it is imported by `libawt_xawt.so` and `libawt_headless.so`. Or > do I misunderstand the split? Is `libawt.so` the common code for both > `libawt_xawt.so` a

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-10-23 Thread Alexey Ivanov
On Fri, 21 Jul 2023 03:35:57 GMT, Sergey Bylokhov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disabled OLE1 from CoInit > > Marked as reviewed by serb (Reviewer). > @mrserb Could you take a look

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2023-10-23 Thread Alexey Ivanov
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK

Re: RFR: 8305321: Remove unused exports in java.desktop [v5]

2023-10-23 Thread Alexey Ivanov
On Fri, 13 Oct 2023 15:19:53 GMT, Daniel Jeliński wrote: >> Please review this patch that removes a number of unused exports from >> java.desktop native libraries. >> >> In most cases I removed JNIEXPORT from methods and variables that are only >> used within a single shared library. Other tha

Re: RFR: 8169475 : WheelModifier.java fails by timeout [v2]

2023-10-23 Thread Dmitry Markov
On Mon, 23 Oct 2023 03:28:00 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have added additional CountDownLatch for making sure button is visible >> before proceeding,(observe this was one of the key reason for failure) so >> this helps to improve test case stability. Modifi

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2023-10-23 Thread Alexey Ivanov
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2023-10-23 Thread Alexey Ivanov
On Fri, 29 Sep 2023 12:12:23 GMT, Alexey Ivanov wrote: > You should probably pass `altAtt` as the `description` parameter, yet I'm > unsure if it's ever used in this context. As I say, I'm unsure if it's used… The description could be exposed to Accessibility API. By default, `ImageIcon` uses

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2023-10-23 Thread Alexey Ivanov
On Fri, 29 Sep 2023 12:41:10 GMT, Alexey Ivanov wrote: >> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/share/classes/javax/swing/text/html/FormView.java >> >> FormView.java : Remove a redund

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2023-10-23 Thread ScientificWare
On Fri, 29 Sep 2023 12:41:10 GMT, Alexey Ivanov wrote: >> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/share/classes/javax/swing/text/html/FormView.java >> >> FormView.java : Remove a redund

Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v8]

2023-10-23 Thread Julian Waters
> We should set the -permissive- flag for the Microsoft Visual C compiler, as > was requested by the now backed out > [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes > the Visual C compiler much less accepting of ill formed code, which will > improve code quality on W