On Fri, 3 Nov 2023 04:04:49 GMT, Zhao Song wrote:
> > @zhaosongzs Thank you for your suggestions xpbob is my account name, and
> > when I click on profile, the name is empty. I set it up and jcheck worked I
> > have not set a profile since I applied for an account.
>
> OK, but if you never set
On Wed, 1 Nov 2023 21:31:02 GMT, Daniel Jeliński wrote:
>> These two
>> #define HB_NO_SUBSET_LAYOUT
>> #define HB_NO_SUBSET_CFF
>
> You can find the file here:
> https://github.com/openjdk/jdk/blob/f262f06c97b9ea94cd6119b3a8beb16bf804d083/src/java.desktop/share/native/libharfbuzz/graph/gsubgpos-c
On Fri, 3 Nov 2023 04:57:26 GMT, Julian Waters wrote:
> Actually, I can do you one better, now that I think of it, so I don't have to
> explains potentially deeply nested and confusing error logs:
>
> ```
> int main() {
> goto skip;
> int i = 0;
> skip:
> std::printf("Done\n");
On Fri, 3 Nov 2023 04:12:46 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>
> "Sets the minimum size of this component to a constant value. Subsequent
> calls to getMinimumSize will always return this value..."
>
> However, JScrollBar overrides getMinimumSize() and breaks this contract - it
> always
On Fri, 3 Nov 2023 04:12:46 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
On Fri, 3 Nov 2023 04:12:46 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
On Fri, 3 Nov 2023 02:29:58 GMT, Julian Waters wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 218:
>>
>>> 216:
>>> 217: AwtCanvas *c;
>>> 218: c = (AwtCanvas*) pData;
>>
>> you probably explained it in some other thread, perhaps in an earlier review
>> bu
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
On Thu, 2 Nov 2023 16:09:28 GMT, Zhao Song wrote:
>> @erikj79
>> Thanks for the review.
>> The code has been updated
>
> Hi @xpbob,
> The jcheck is continuously failing because your GitHub name is `null`. Please
> set your name in your profile.
> And out of curiosity, I want to know did you se
On Thu, 2 Nov 2023 04:29:01 GMT, xpbob wrote:
> Build failure with GCC8.3.1
>
> === Output from failing command(s) repeated here ===
> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
> In fun
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
On Thu, 2 Nov 2023 16:09:28 GMT, Zhao Song wrote:
>> @erikj79
>> Thanks for the review.
>> The code has been updated
>
> Hi @xpbob,
> The jcheck is continuously failing because your GitHub name is `null`. Please
> set your name in your profile.
> And out of curiosity, I want to know did you se
On Thu, 2 Nov 2023 14:01:20 GMT, xpbob wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>>
On Thu, 2 Nov 2023 17:51:15 GMT, Phil Race wrote:
>> xpbob has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Update make/modules/java.desktop/lib/Awt2dLibraries.gmk
>>
>> break up line
>>
>> Co-authored-by: Erik Joelsson <375974
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
On Thu, 2 Nov 2023 21:10:45 GMT, Phil Race wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changes awt_Frame.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 61:
>
>> 59:
>> 60: jfiel
On Thu, 2 Nov 2023 18:43:14 GMT, Phil Race wrote:
>> Is this related to the `#define malloc Do_Not_Use_Malloc` issue? If so, the
>> required ordering of includes should be documented here as well.
>
> agreed
Will do
-
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discu
On Thu, 2 Nov 2023 18:46:15 GMT, Phil Race wrote:
>> I can try doing that, yes. There was actually a commit before this one that
>> addressed the same issue in awt, but it missed this one since without
>> -permissive- this error isn't caught, see
>> [8241087](https://bugs.openjdk.org/browse/JD
On Thu, 2 Nov 2023 19:15:42 GMT, Dean Long wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changes awt_Frame.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 220:
>
>> 218: c = (AwtC
On Thu, 2 Nov 2023 18:47:45 GMT, Phil Race wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changes awt_Frame.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 218:
>
>> 216:
>> 217:
The bug on Windows doesn't generate any error messages. During the testcase
run, every "Open MIDI port" message should be followed by an "All SysexMessage
sent" message. Alternatively, you can check `%ERRORLEVEL%` to determine if
there's an error when JVM exits.
On Linux, there are no software
> This is referenced in Java Bug Database as
> - [JDK-8314731 : Adds support for the alt attribute in the image type input
> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>
> This is tracked in JBS as
> - [JDK-8314731 : Add support for the alt attribute in the image type i
On Wed, 18 Oct 2023 17:14:06 GMT, Alexander Scherbatiy
wrote:
> > Why did you file a new RFE when you know about the existing one ? Close
> > your new one as a dup. and redirect everything to the existing one. Also I
> > don't see any UI work to enhance the dialog so it can be selected. And wh
On Thu, 21 Sep 2023 09:17:39 GMT, Magnus Ihse Bursie wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_DnDDT.cpp line 34:
>>
>>> 32: #include "sun_awt_windows_WDropTargetContextPeer.h"
>>> 33: #include "awt_Container.h"
>>> 34: #include "awt_ole.h"
>>
>> Why?
>
> Is this related to t
On Fri, 11 Aug 2023 07:41:45 GMT, Julian Waters wrote:
>> Oh. That's not good. Having such an undocumented reliance on order of
>> include just begs to bitrot at some point. Any chance you could unravel that
>> mystery, maybe in a later RFE? For now, can you please add a comment at
>> those pl
On Thu, 2 Nov 2023 11:07:27 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
On Thu, 2 Nov 2023 11:07:27 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
On Thu, 26 Oct 2023 21:45:46 GMT, Alisen Chung wrote:
> Updating freetype
> mach5 build is green
This pull request has now been integrated.
Changeset: 3b65b879
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/3b65b8797a0798474947d38d3facd17b3e89c602
Stats: 5484 lines
On Tue, 26 Sep 2023 11:12:08 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
On Thu, 2 Nov 2023 12:44:28 GMT, Matthias Baesken wrote:
>> There is an early return in Java_sun_awt_X11_XlibWrapper_SetBitmapShape
>> XlbWrapper.c that seems to miss a ReleaseIntArrayElements call.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sin
On Thu, 2 Nov 2023 14:01:20 GMT, null wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>> I
On Thu, 2 Nov 2023 13:58:01 GMT, null wrote:
>> null has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add comments
>
> @erikj79
> Thanks for the review.
> The code has been updated
Hi @xpbob,
The jcheck is continuously failing because
JProgressBar is always painted with border irrespective of the value set via
the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF.
Proposed fix is to add a check before painting the component.
CI jobs are green after the fix. Links attached to JBS.
-
Commit messa
On Thu, 2 Nov 2023 14:01:20 GMT, null wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>> I
> Build failure with GCC8.3.1
>
> === Output from failing command(s) repeated here ===
> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
> In function 'hb_bool_t hb_ot_layout_get_font_extents(h
On Thu, 2 Nov 2023 07:14:14 GMT, null wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>> I
On Thu, 2 Nov 2023 07:14:14 GMT, null wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>> I
On Mon, 30 Oct 2023 09:15:00 GMT, Matthias Baesken wrote:
>> There is an early return in Java_sun_awt_X11_XlibWrapper_SetBitmapShape
>> XlbWrapper.c that seems to miss a ReleaseIntArrayElements call.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit si
> There is an early return in Java_sun_awt_X11_XlibWrapper_SetBitmapShape
> XlbWrapper.c that seems to miss a ReleaseIntArrayElements call.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
remove JNU_ThrowOutOfMemoryError
---
On Thu, 2 Nov 2023 11:02:27 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
On Thu, 2 Nov 2023 10:52:27 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
On Thu, 2 Nov 2023 07:11:49 GMT, null wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>> I
On Thu, 2 Nov 2023 06:54:01 GMT, Jie Fu wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>>
> Build failure with GCC8.3.1
>
> === Output from failing command(s) repeated here ===
> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
> In function 'hb_bool_t hb_ot_layout_get_font_extents(h
51 matches
Mail list logo
