Hi Reviewers,
Updated the test and it will generate required images on the fly so storing and
loading image from repo could be avoided. Please review and let me know your
suggestions.
Regards,
Renjith.
-
Commit messages:
- Updated font and copyright year
- Removed commented
On Thu, 7 Dec 2023 18:41:12 GMT, Phil Race wrote:
> Clean up some un-used code in the 2D native font code that interfaces to
> libharfbuzz
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17022#pullrequestreview-1771320458
On Thu, 7 Dec 2023 19:47:22 GMT, Phil Race wrote:
> The conversion methods in this class return the wrong array.
This pull request has now been integrated.
Changeset: 25dc4762
Author:Phil Race
URL:
https://git.openjdk.org/jdk/commit/25dc4762b419a6b09d17d9055b1f75e4b531458a
Stats:
On Thu, 7 Dec 2023 19:47:22 GMT, Phil Race wrote:
> The conversion methods in this class return the wrong array.
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17024#pullrequestreview-1771287026
On Thu, 7 Dec 2023 19:47:22 GMT, Phil Race wrote:
> The conversion methods in this class return the wrong array.
Looks fine.
Probably corrects a faux pas of mine from about 18 years ago.
-
Marked as reviewed by bpb (Reviewer).
PR Review:
On Thu, 7 Dec 2023 15:11:24 GMT, Alexey Ivanov wrote:
>> Sergey Bylokhov has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - 8270269: Desktop.browse method fails if earlier CoInitialize call as
>> COINIT_MULTITHREADED
>> - Revert
> The fix for a regression caused by the
> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
> RPC_E_CHANGED_MODE when COM was already initialized using
> COINIT_MULTITHREADED mode.
>
> @aivanov-jdk please take a look.
Sergey Bylokhov has updated the pull request
On Thu, 7 Dec 2023 19:56:07 GMT, Phil Race wrote:
> As can be seen here
> https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/imageio/ImageReader.html#computeRegions(javax.imageio.ImageReadParam,int,int,java.awt.image.BufferedImage,java.awt.Rectangle,java.awt.Rectangle)
>
>
On Thu, 7 Dec 2023 19:56:07 GMT, Phil Race wrote:
> As can be seen here
> https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/imageio/ImageReader.html#computeRegions(javax.imageio.ImageReadParam,int,int,java.awt.image.BufferedImage,java.awt.Rectangle,java.awt.Rectangle)
>
>
As can be seen here
https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/imageio/ImageReader.html#computeRegions(javax.imageio.ImageReadParam,int,int,java.awt.image.BufferedImage,java.awt.Rectangle,java.awt.Rectangle)
There's an extra '>' in the javadoc source with the result
The conversion methods in this class return the wrong array.
-
Commit messages:
- 8286827
Changes: https://git.openjdk.org/jdk/pull/17024/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17024=00
Issue: https://bugs.openjdk.org/browse/JDK-8286827
Stats: 4 lines in 1 file
Clean up some un-used code in the 2D native font code that interfaces to
libharfbuzz
-
Commit messages:
- 8312307
Changes: https://git.openjdk.org/jdk/pull/17022/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17022=00
Issue: https://bugs.openjdk.org/browse/JDK-8312307
On Wed, 6 Dec 2023 18:04:59 GMT, Alexander Zvegintsev
wrote:
>> Anton Bobrov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8321176: remove RuntimeException and address review comments
>
> Looks good to me.
>
>> can you please file a
On Thu, 7 Dec 2023 03:03:59 GMT, Sergey Bylokhov wrote:
> The fix for a regression caused by the
> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
> RPC_E_CHANGED_MODE when COM was already initialized using
> COINIT_MULTITHREADED mode.
>
> @aivanov-jdk please take
On Wed, 6 Dec 2023 18:04:59 GMT, Alexander Zvegintsev
wrote:
>> Anton Bobrov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8321176: remove RuntimeException and address review comments
>
> Looks good to me.
>
>> can you please file a
On Wed, 18 Oct 2023 17:36:49 GMT, Alexander Scherbatiy
wrote:
>> The fix adds new public `OutputBin` print attribute class which allow to set
>> a printer output bin in a `PrinterJob` class. The corresponding internal
>> `CustomOutputBin` class is added as well.
>>
>> - Constants used in
On Thu, 7 Dec 2023 09:47:16 GMT, Daniel Jeliński wrote:
> This PR fixes a typo in exception message printed when `jdk.readPollers` or
> `jdk.writePollers` is not a power of two.
>
> While at it, I searched the code for other instances of `vale`, and corrected
> them as well.
Thanks for the
On Thu, 7 Dec 2023 09:47:16 GMT, Daniel Jeliński wrote:
> This PR fixes a typo in exception message printed when `jdk.readPollers` or
> `jdk.writePollers` is not a power of two.
>
> While at it, I searched the code for other instances of `vale`, and corrected
> them as well.
This pull
On Fri, 1 Dec 2023 06:31:00 GMT, Prasanta Sadhukhan
wrote:
> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
> field isn't declared as volatile. Without the volatile modifier,
> double-checked locking implementation is broken.
This pull request has now been
On Wed, 6 Dec 2023 11:47:03 GMT, Prasanta Sadhukhan
wrote:
>> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
>> field isn't declared as volatile. Without the volatile modifier,
>> double-checked locking implementation is broken.
>
> Prasanta Sadhukhan has updated
On Thu, 7 Dec 2023 09:47:16 GMT, Daniel Jeliński wrote:
> This PR fixes a typo in exception message printed when `jdk.readPollers` or
> `jdk.writePollers` is not a power of two.
>
> While at it, I searched the code for other instances of `vale`, and corrected
> them as well.
Marked as
This PR fixes a typo in exception message printed when `jdk.readPollers` or
`jdk.writePollers` is not a power of two.
While at it, I searched the code for other instances of `vale`, and corrected
them as well.
-
Commit messages:
- Fix vale->value
Changes:
The fix for a regression caused by the
https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
RPC_E_CHANGED_MODE when COM was already initialized using COINIT_MULTITHREADED
mode.
@aivanov-jdk please take a look.
-
Commit messages:
- 8270269: Desktop.browse
On Thu, 30 Nov 2023 19:20:50 GMT, Sergey Bylokhov wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Can this patch be covered by the new
> Hi Reviewers,
> There was a typo for color conversion instead of dstColorSpace function
> srcColorSpace was used. Please review and let me know your suggestions if
> any.
>
> Renjith.
Renjith Kannath Pariyangad has updated the pull request incrementally with one
additional commit since
25 matches
Mail list logo
