On Thu, 4 Jan 2024 06:08:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Something like this:
>>
>> /*
>> * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
>> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>> *
>> * This code is free software; you can re
On Thu, 4 Jan 2024 05:53:44 GMT, Sergey Bylokhov wrote:
>> and instead of comparing that the images are just different, it is probably
>> better to compare results of conversion via TestColorSpace wrapper vs
>> ColorSpace w/o wrapper.
>
> Something like this:
>
> /*
> * Copyright (c) 2024, Or
On Thu, 4 Jan 2024 05:15:05 GMT, Sergey Bylokhov wrote:
>> The difference between srcColorSpace.fromCIEXYZ and dtsColorSpace.fromCIEXYZ
>> can trigger an exception if both have different number of components, for
>> example srcColorSpace = CS_GRAY and srcColorSpace.CS_sRGB
>> =>ArrayIndexOutOf
> Hi Reviewers,
> There was a typo for color conversion instead of dstColorSpace function
> srcColorSpace was used. Please review and let me know your suggestions if
> any.
>
> Renjith.
Renjith Kannath Pariyangad has updated the pull request incrementally with one
additional commit since the
On Thu, 4 Jan 2024 04:42:24 GMT, Renjith Kannath Pariyangad
wrote:
>> Hm… If modify the `toRGB` and `fromRGB` methods to use `csRGB` object, then
>> the test does not fail without the fix.
>>
>> What's more interesting is that the images are equal before `filter` is
>> applied.
>
> @aivanov-j
On Thu, 4 Jan 2024 05:10:55 GMT, Sergey Bylokhov wrote:
>> @aivanov-jdk Thank you for clarifying, I thought he mean to modify
>> `toCIEXYZ` and `fromCIEXYZ`. Yes if we modify `toRGB `and `fromRGB` then it
>> will not pass through fixed area, So we may need to skip this.
>
> The difference betwe
On Wed, 3 Jan 2024 21:04:50 GMT, Alexey Ivanov wrote:
>> I agree with Sergey and I can't see any updates.
>
> Hm… If modify the `toRGB` and `fromRGB` methods to use `csRGB` object, then
> the test does not fail without the fix.
>
> What's more interesting is that the images are equal before `fi
On Wed, 3 Jan 2024 19:54:47 GMT, Alexey Ivanov wrote:
>> Updated this
>
> I agree with Sergey and I can't see any updates.
Hm… If modify the `toRGB` and `fromRGB` methods to use `csRGB` object, then the
test does not fail without the fix.
What's more interesting is that the images are equal be
On Wed, 3 Jan 2024 03:42:35 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/color/NonICCFilterTest.java line 53:
>>
>>> 51:
>>> 52: public float[] toRGB(float[] colorvalue) {
>>> 53: return colorvalue;
>>
>> Just for completeness, it is probably better to use c
On Wed, 3 Jan 2024 03:45:06 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad h
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
>
On Wed, 3 Jan 2024 08:16:12 GMT, Matthias Baesken wrote:
> https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-170
> The %S is for wide chars, do you think we need the other one (%s) ?
You're right, it should be wide-char.
On Thu, 28 Dec 2023 09:48:52 GMT, Matthias Baesken wrote:
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation befor
On Wed, 3 Jan 2024 00:38:19 GMT, Sergey Bylokhov wrote:
> I think we should fallback to something. The bug itself looks similar to
> this: https://bugs.openjdk.org/browse/JDK-8185862
[JDK-8185862](https://bugs.openjdk.org/browse/JDK-8185862) seems to be the
exact duplicate of this one.
It ref
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
>
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done and still
> the unneeded fully qualified class name "java.util.Arrays" is
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done and still
> the unneeded fully qualified class name "java.util.Arrays" is
On Wed, 3 Jan 2024 11:41:20 GMT, Matthias Baesken wrote:
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done and still
> th
In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
cleanup has been proposed before (and was done in the change). But there are a
number of other places in the codebase where the import is done and still the
unneeded fully qualified class name "java.util.Arrays" is used so
On Tue, 2 Jan 2024 19:33:44 GMT, Alexey Ivanov wrote:
>> When running with fastdebug binaries we run intermittent into the issue
>> below in
>> jtreg test
>> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
>> Seems we miss checking of successful HBITMAP creation befo
On Thu, 28 Dec 2023 09:48:52 GMT, Matthias Baesken wrote:
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation befor
21 matches
Mail list logo
