Re: RFR: 8318112: CSS percentage values are capped at 100%

On Mon, 8 Jan 2024 09:19:20 GMT, Prasanta Sadhukhan wrote: > Java CSS where values can be displayed in percent are capped at 100% so > "width: 200%" and "width: 100%" are equal, which is incorrect. > FIx is made to make sure parsing is not capped at 100% Looks good to me. - Mar

Re: RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64)

On Tue, 9 Jan 2024 21:06:50 GMT, Alisen Chung wrote: > SunToolkit.java is trying to post an event on the TrayIcon appContext, but > the TrayIcon was already removed by the test, causing an error. The fix is to > make SunToolkit skip posting the event if appContext is null. The test is > also u

Re: RFR: 8258979: The image didn't show correctly with GTK LAF [v3]

On Wed, 10 Jan 2024 05:00:33 GMT, Abhishek Kumar wrote: >> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component >> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned >> from BasicTreeUI class which doesn't contain any icon image whereas the >> expan

Re: RFR: 8264102: JTable Keyboards Navigation differs with Test Instructions. [v6]

> Updated the actions for "ctrl shift DOWN" to "`selectLastRowExtendSelection`" > and "ctrl shift UP", "`selectFirstRowExtendSelection`" in Basic and other > Look and feel. Tested in CI and no regressions found. > Test to be used - > [javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.ja

Re: RFR: 8264102: JTable Keyboards Navigation differs with Test Instructions. [v5]

On Wed, 10 Jan 2024 05:10:33 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated test instructions > > test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 230: > >> 228: try {

Re: RFR: 8264102: JTable Keyboards Navigation differs with Test Instructions. [v5]

On Tue, 9 Jan 2024 07:57:57 GMT, Tejesh R wrote: >> Updated the actions for "ctrl shift DOWN" to >> "`selectLastRowExtendSelection`" and "ctrl shift UP", >> "`selectFirstRowExtendSelection`" in Basic and other Look and feel. Tested >> in CI and no regressions found. >> Test to be used - >>

Re: RFR: 8258979: The image didn't show correctly with GTK LAF [v3]

> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component > c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned from > BasicTreeUI class which doesn't contain any icon image whereas the expanded > icon is returned from SynthTreeUI class and expanded icon

Re: RFR: 8258979: The image didn't show correctly with GTK LAF

On Mon, 8 Jan 2024 09:18:20 GMT, Abhishek Kumar wrote: >Also, if one icon is rendered and other is not, there is a potential to create >automated test to render the icons into bufferedimage and compare, the >collapsed one should be all white BI in failed case...and you can use that >automated

Re: RFR: 8258979: The image didn't show correctly with GTK LAF [v2]

> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component > c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned from > BasicTreeUI class which doesn't contain any icon image whereas the expanded > icon is returned from SynthTreeUI class and expanded icon

Integrated: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

On Tue, 9 Jan 2024 07:21:26 GMT, Sergey Bylokhov wrote: > Implementation of cmsFLAGS_COPY_ALPHA in littlecms 2.16 is changed to throw > an exception: > - if the number of extra channels in src and dst are different. > - If dst does not have an alpha but src has > - If src does not have an alp

Re: Windows 11: Notifications vanishes after few seconds.

Back in mid-2021 I submitted a feature request to add new APIs for toast notifications on macOS and Windows *without* using SystemTray. It's something I'd like to implement. Apple introduced its notification APIs

RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64)

SunToolkit.java is trying to post an event on the TrayIcon appContext, but the TrayIcon was already removed by the test, causing an error. The fix is to make SunToolkit skip posting the event if appContext is null. The test is also updated to remove applet usage and use PassFailJFrame instead.

Re: RFR: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

On Tue, 9 Jan 2024 07:21:26 GMT, Sergey Bylokhov wrote: > Implementation of cmsFLAGS_COPY_ALPHA in littlecms 2.16 is changed to throw > an exception: > - if the number of extra channels in src and dst are different. > - If dst does not have an alpha but src has > - If src does not have an alp

Re: RFR: JDK-8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows

On Tue, 2 Jan 2024 15:03:12 GMT, Matthias Baesken wrote: > The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced > with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni , and > shows on Windows server 2019 the following JNI warning , so the test fails on >

Re: RFR: JDK-8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows

On Tue, 2 Jan 2024 15:03:12 GMT, Matthias Baesken wrote: > The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced > with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni , and > shows on Windows server 2019 the following JNI warning , so the test fails on >

Re: RFR: JDK-8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows

On Tue, 2 Jan 2024 15:03:12 GMT, Matthias Baesken wrote: > The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced > with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni , and > shows on Windows server 2019 the following JNI warning , so the test fails on >

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v13]

On Tue, 9 Jan 2024 11:11:38 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> There was a typo for color conversion instead of dstColorSpace function >> srcColorSpace was used. Please review and let me know your suggestions if >> any. >> >> Renjith. > > Renjith Kannath Pariyangad h

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v13]

> Hi Reviewers, > There was a typo for color conversion instead of dstColorSpace function > srcColorSpace was used. Please review and let me know your suggestions if > any. > > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v6]

On Fri, 5 Jan 2024 16:16:51 GMT, Alexey Ivanov wrote: >> @mrserb for avoiding _ArrayIndexOutOfBoundsException_ I have modified >> `CS_GRAY `with `CS_LINEAR_RGB ` for making same number of channels. But the >> test passed irrespective of fix. >> Do you find any alternative way to fail the test w

Re: RFR: 8323170 - j2dbench is using outdated javac source/target to be able to build by itself

On Mon, 8 Jan 2024 13:03:22 GMT, Jiří Vaněk wrote: > This PR is fixig to-old values of javac source/target for jdk22. > Note, that jdk21 suffers the same, only the target values have to be 8. I > will be happy to backport this cange to jdk17 later. > > Note, that considering the rolling release

RFR: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Implementation of cmsFLAGS_COPY_ALPHA in littlecms 2.16 is changed to throw an exception: - if the number of extra channels in src and dst are different. - If dst does not have an alpha but src has - If src does not have an alpha but dst has Exception does not occurred if the number of extra c