On Mon, 8 Jan 2024 07:29:13 GMT, Abhishek Kumar wrote:
> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned from
> BasicTreeUI class which doesn't contain any icon image whereas the expanded
> i
> This is happening in linux where `BuffereStrategyPaintManager` is used to
> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
> to offscreen where the background is not refreshed, which does only clipping
> and then paints to offscreen. In order to handle the screen
On Fri, 12 Jan 2024 06:32:55 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JFrame/JFrameBackgroundRefreshTest.java line 129:
>
>> 127: g2d.setColor
On Tue, 12 Dec 2023 13:04:26 GMT, Tejesh R wrote:
> This is happening in linux where `BuffereStrategyPaintManager` is used to
> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
> to offscreen where the background is not refreshed, which does only clipping
> and then
On Fri, 12 Jan 2024 05:13:20 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JTree/bug8038113.java line 48:
>>
>>> 46: */
>>> 47:
>>> 48: public class bug8038113 {
>>
>> Will it be better to change the file & class name to something meaningful
>> instead of bug id since now two bugs refer
On Fri, 12 Jan 2024 04:10:09 GMT, Abhishek Kumar wrote:
>> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
>> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned
>> from BasicTreeUI class which doesn't contain any icon image whereas the
>> expan
On Fri, 12 Jan 2024 04:56:23 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comment added
>
> test/jdk/javax/swing/JTree/bug8038113.java line 48:
>
>> 46: */
>> 47:
>> 48: public class bug803811
> The issue is that the doc area (in respect to the screen height which is
> 768px) which is at the bottom was causing the `JFileChooser `to be placed
> slightly above the set location. Was able to reproduce in local machine with
> reference to the failure image provided in the CI logs. The sugg
On Fri, 12 Jan 2024 04:10:09 GMT, Abhishek Kumar wrote:
>> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
>> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned
>> from BasicTreeUI class which doesn't contain any icon image whereas the
>> expan
On Wed, 10 Jan 2024 21:08:35 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned from
> BasicTreeUI class which doesn't contain any icon image whereas the expanded
> icon is returned from SynthTreeUI class and expanded icon
On Thu, 11 Jan 2024 17:28:42 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line
> 791:
On Thu, 11 Jan 2024 15:21:46 GMT, Abhishek Kumar wrote:
>> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
>> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned
>> from BasicTreeUI class which doesn't contain any icon image whereas the
>> expan
On Thu, 11 Jan 2024 06:53:22 GMT, Renjith Kannath Pariyangad
wrote:
>Did you mean to use the wrapper for the middle like ColorSpace mid =
>createCS(ColorSpaceSelector.WRAPPED_PYCC); , So we can achieve :
Just repeat existed checks using wrapper. So you will have all combinations:
> wrapper->i
On Wed, 27 Dec 2023 04:20:42 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test case. Now test has pass/fail option also test will
> execute two time for covering different cases which are part of the test.
>
> Please review and let me know your suggestions.
>
On Thu, 11 Jan 2024 06:46:43 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 217:
>
>> 215: int screen
On Thu, 11 Jan 2024 18:43:00 GMT, Rajat Mahajan wrote:
> Remove commented out/ unused code from awt_List.cpp, which has been commented
> out since 2007, when the code was moved to Mercurial.
> The test ScrollPaneLimitation.java has been opened under
> [JDK-8306137](https://bugs.openjdk.org/brow
Update LCMS, mach5 client tests are green
-
Commit messages:
- update
- init commit
Changes: https://git.openjdk.org/jdk/pull/17382/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17382&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8321489
Stats: 1599 lines in 21
On Thu, 11 Jan 2024 18:43:00 GMT, Rajat Mahajan wrote:
> Remove commented out/ unused code from awt_List.cpp, which has been commented
> out since 2007, when the code was moved to Mercurial.
> The test ScrollPaneLimitation.java has been opened under
> [JDK-8306137](https://bugs.openjdk.org/brow
On Thu, 11 Jan 2024 20:04:56 GMT, Harshitha Onkar wrote:
> While investigating a macOS 14 issue noticed missing null checks in
> java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java
>
> The missing null check will cause an NPE in finally block when frame2 is not
> created in the
This test passes on the latest version of macOS (14.2). The reason as to why
this passes on the latest version of macOS is the order in which native Mouse
Moved event is received. Details and native event logs added to the JBS issue.
While looking into it noticed missing null checks in test hen
On Thu, 11 Jan 2024 20:04:56 GMT, Harshitha Onkar wrote:
> This test passes on the latest version of macOS (14.2). The reason as to why
> this passes on the latest version of macOS is the order in which native Mouse
> Moved event is received. Details and native event logs added to the JBS issu
On Wed, 10 Jan 2024 21:08:35 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
On Wed, 10 Jan 2024 21:35:57 GMT, Harshitha Onkar wrote:
> A black screen is seen on newer versions of macOS (13.3 & above) when a
> window is set to full-screen using `setFullScreenWindow()`. The root cause
> was narrowed down to the shield level of the full-screen window vs the shield
> leve
Thanks for raising that. Since I can’t comment on that issue directly, let me
respond here to the claim by Alex Z. that “it’s not so bad”:
I agree that the code snippet he posted doesn’t look too bad, at least for the
async case.
But!! Consider the following:
1. We never closed the stream.
Remove commented out/ unused code from awt_List.cpp, which has been commented
out since 2007, when the code was moved to Mercurial.
The test ScrollPaneLimitation.java has been opened under
[JDK-8306137](https://bugs.openjdk.org/browse/JDK-8306137), and it should be
safe to remove this code now.
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation before calling
> GetDIBits.
>
> HDC hBMDC = this->GetDC();
>
On Thu, 11 Jan 2024 07:07:10 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix and move file outside folder
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/Synt
> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned from
> BasicTreeUI class which doesn't contain any icon image whereas the expanded
> icon is returned from SynthTreeUI class and expanded icon
On Thu, 11 Jan 2024 12:11:17 GMT, Magnus Ihse Bursie wrote:
> What is remaining to get this PR committable? It has such a long history that
> it is hard to get a grasp on the remaining issues.
>
> @TheShermanTanker Could you perhaps summarize the remaining hurdles?
It's largely complete by now
On Thu, 11 Jan 2024 08:24:42 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
On Thu, 4 Jan 2024 12:32:21 GMT, Alexey Ivanov wrote:
> > Thank you, Karl, for bringing the problem in this PR. It already exist in
> > JBS as [JDK-8320692](https://bugs.openjdk.org/browse/JDK-8320692): _Cannot
> > invoke java.awt.Image.getWidth(java.awt.image.ImageObserver)_.
> > I added my ob
On Mon, 8 Jan 2024 09:19:20 GMT, Prasanta Sadhukhan
wrote:
> Java CSS where values can be displayed in percent are capped at 100% so
> "width: 200%" and "width: 100%" are equal, which is incorrect.
> FIx is made to make sure parsing is not capped at 100%
@aivanov-jdk Can you please review?
On Thu, 11 Jan 2024 05:21:51 GMT, Abhishek Kumar wrote:
>> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
>> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned
>> from BasicTreeUI class which doesn't contain any icon image whereas the
>> expan
On Mon, 4 Dec 2023 09:39:09 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less accepting
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
On Wed, 10 Jan 2024 09:18:53 GMT, Matthias Baesken wrote:
> There have been concerns raised about
> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) , so bring back
> the old behavior.
This pull request has now been integrated.
Changeset: cb1d25fc
Author:Matthias Baesken
URL:
37 matches
Mail list logo
