Re: RFR: JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 [v2]

On Fri, 12 Jan 2024 20:21:52 GMT, Harshitha Onkar wrote: >> ShapeNotSetSometimes.java fails intermittently on macOS 14. Following is a >> test stabilization fix for macOS 14. With the added delays >> ShapeNotSetSometimes.java passes on older versions of macOS as well as on >> macOS 14.1, 14.2.

Re: RFR: 6507038: Memory Leak in JTree / BasicTreeUI

On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan wrote: > When using a TreeCellRenterer which creates new components in > getTreeCellRendererComponent() in a JTree that is not visible, changes to the > nodes cause a memory leak. > When a node is changed, the Method getNodeDimensions() is c

Re: RFR: 8323108: BufferedImage.setData(Raster) should not cast float and double values to integers

On Mon, 13 Nov 2023 14:53:22 GMT, Martin Desruisseaux wrote: >> The `BufferedImage` Javadoc does not mention any constraint about the data >> type. In practice, `BufferedImage` with floating point values can be >> rendered by Java2D as well as integers, provided that a compatible >> `ColorMode

Integrated: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix

On Thu, 30 Nov 2023 03:34:08 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > There was a typo for color conversion instead of dstColorSpace function > srcColorSpace was used. Please review and let me know your suggestions if > any. > > Renjith. This pull request has now been integ

RFR: 8320692: Null icon returned for .exe without custom icon

Replaced asserts with NullPointerException calls because outside of testing that would be more informative - i do not think many people running their applications with assertions in system libraries enabled; Added a code that will analyze the result of the getIcon and will fall back to the defau

Re: RFR: 6507038: Memory Leak in JTree / BasicTreeUI

On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan wrote: > When using a TreeCellRenterer which creates new components in > getTreeCellRendererComponent() in a JTree that is not visible, changes to the > nodes cause a memory leak. > When a node is changed, the Method getNodeDimensions() is c

Re: RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v4]

On Wed, 17 Jan 2024 18:49:06 GMT, Alisen Chung wrote: >> So what is the root cause of null context here? > > I'm checking to see if removing executeOnEventHandlerThread solves the issue. > In this test the source of the appcontext (trayIcon) is deleted via an > actionPerformed listener, so prob

Re: RFR: 8323108: BufferedImage.setData(Raster) should not cast float and double values to integers

On Thu, 4 May 2023 10:14:10 GMT, Martin Desruisseaux wrote: > The `BufferedImage` Javadoc does not mention any constraint about the data > type. In practice, `BufferedImage` with floating point values can be rendered > by Java2D as well as integers, provided that a compatible `ColorModel` was

Re: Integrated: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions

Hi Simon, On 2024-01-17 17:53, Simon Nash wrote: I have tested this using JDK 23 build 5 and it works as expected. As I understand it, the original change JDK-8294427 has been backported to JDK 21u, 17u and 11u. What needs to happen to backport this change to 22u and also these older versions

Integrated: 8323554: The typos in Javadoc: "@return if "

On Wed, 10 Jan 2024 21:35:56 GMT, Sergey Bylokhov wrote: > The docs for the boolean methods are updated from this style: > > @return if the event has been consumed > > to this one > > @return {@code true} if the event has been consumed, otherwise > {@code false} > > plus small cleanups here a

Re: RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v4]

On Wed, 17 Jan 2024 00:26:20 GMT, Sergey Bylokhov wrote: >> Or maybe it is a lack of synchronization? > > So what is the root cause of null context here? I'm checking to see if removing executeOnEventHandlerThread solves the issue. In this test the source of the appcontext (trayIcon) is deleted

Re: Windows 11: Notifications vanishes after few seconds.

Hi Davide, The enhancement you submitted is now available in JBS: https://bugs.openjdk.org/browse/JDK-8323821 Use toast notifications on Windows 11 I updated the subject so that it sounds like an enhancement rather than a bug. JDK-8323821 is more specific than https://bugs.openjdk.org/brows

Re: [External] : Re: Windows 11: Notifications vanishes after few seconds.

Thank you, SWinxy. It is a helpful reference, I didn't know such an enhancement already existed: JDK-8266423: Triggering OS toast notifications without the use of SystemTray On 2024-01-09 21:50, SWinxy wrote: Back in mid-2021 I submitted a feature request

Re: [External] : Re: Windows 11: Notifications vanishes after few seconds.

Hi Davide, On 2024-01-08 21:05, Davide Perini wrote: Thanks for the explanation Aleksei but can you explain me what is the OpenJDK direction please? Suppose that you have a feature like this one, a simple notifications. Java worked well with Windows notifications until Win10, then Microsoft cha

Re: Integrated: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions

On 22/12/2023 20:19, Rajat Mahajan wrote: On Thu, 21 Dec 2023 01:19:40 GMT, Rajat Mahajan wrote: This pull request has now been integrated. Changeset: f695ca58 Author:Rajat Mahajan Committer: Alexey Ivanov URL: https://git.openjdk.org/jdk/commit/f695ca588453265d6ad791c6a396197e8a53

Integrated: 8317771 [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma

On Wed, 20 Dec 2023 09:28:47 GMT, Artem Semenov wrote: > NSAccessibility Outline is an accessibility representation of trees. > This representation requires that the visible children be represented as a > flat array. > The child linearization algorithm available in > ```CAccessibility.getChildr

RFR: 8323670: A few client tests intermittently throw ConcurrentModificationException

Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) also created concurrent exception intermittently (monthly once/quarterly once) on CI system. The issue was not able to be reproduced yet, hence proposing an alternative fix which uses iterators to compare the List. CI testi

Re: RFR: 8318590: JButton ignores margin when painting HTML text [v6]

On Tue, 5 Dec 2023 19:11:48 GMT, Damon Nguyen wrote: >> The initial issue was a padding issue for JButton when HTML content was set >> as the button's text. >> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772), >> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and >> [JD

Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v14]

On Wed, 17 Jan 2024 01:56:25 GMT, songpv-imt wrote: >> The root cause of the bug is because mousePress() method is invoked before >> mouseMove() event is completely processed causing the drag & drop behavior >> not being able to be recognized properly. This in turn makes the method >> dragSour

Re: RFR: 8317771 [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma

On Wed, 20 Dec 2023 09:28:47 GMT, Artem Semenov wrote: > NSAccessibility Outline is an accessibility representation of trees. > This representation requires that the visible children be represented as a > flat array. > The child linearization algorithm available in > ```CAccessibility.getChildr