Re: RFR: 8309460: JScrollBar leaves behind clutter for non-integer UI scales

2024-01-19 Thread Harshitha Onkar
On Thu, 18 Jan 2024 11:09:12 GMT, Prasanta Sadhukhan wrote: > Lines are left behind when moving the scrollbar in the positive direction. > but are cleaned up on mouse release. > Additonally, with right arrow clicks too, the lines are left behind. > Seems like for mouseDragged and

Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v46]

2024-01-19 Thread Phil Race
On Thu, 11 Jan 2024 08:24:42 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less

Re: RFR: 6507038: Memory Leak in JTree / BasicTreeUI

2024-01-19 Thread Phil Race
On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan wrote: > When using a TreeCellRenterer which creates new components in > getTreeCellRendererComponent() in a JTree that is not visible, changes to the > nodes cause a memory leak. > When a node is changed, the Method getNodeDimensions() is

Integrated: JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14

2024-01-19 Thread Harshitha Onkar
On Thu, 21 Dec 2023 20:33:53 GMT, Harshitha Onkar wrote: > ShapeNotSetSometimes.java fails intermittently on macOS 14. Following is a > test stabilization fix for macOS 14. With the added delays > ShapeNotSetSometimes.java passes on older versions of macOS as well as on > macOS 14.1, 14.2.

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2024-01-19 Thread ScientificWare
On Tue, 16 Jan 2024 21:57:31 GMT, Phil Race wrote: >> Waiting for a review. > > @scientificware - are you still working on this ? @prrace Yes but I have to postpone this work. - PR Comment: https://git.openjdk.org/jdk/pull/15319#issuecomment-1900986622

Re: RFR: 8323108: BufferedImage.setData(Raster) should not cast float and double values to integers

2024-01-19 Thread Sergey Bylokhov
On Thu, 4 May 2023 10:14:10 GMT, Martin Desruisseaux wrote: > The `BufferedImage` Javadoc does not mention any constraint about the data > type. In practice, `BufferedImage` with floating point values can be rendered > by Java2D as well as integers, provided that a compatible `ColorModel` was

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v8]

2024-01-19 Thread Phil Race
On Thu, 18 Jan 2024 21:46:39 GMT, Phil Race wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Honour max/min size if set by user > > src/java.desktop/share/classes/javax/swing/JScrollBar.java line 784: > >>

Re: RFR: 8323108: BufferedImage.setData(Raster) should not cast float and double values to integers

2024-01-19 Thread Brian Burkhalter
On Thu, 4 May 2023 10:14:10 GMT, Martin Desruisseaux wrote: > The `BufferedImage` Javadoc does not mention any constraint about the data > type. In practice, `BufferedImage` with floating point values can be rendered > by Java2D as well as integers, provided that a compatible `ColorModel` was

Re: RFR: 8320692: Null icon returned for .exe without custom icon [v2]

2024-01-19 Thread Alexey Ivanov
On Thu, 18 Jan 2024 19:34:11 GMT, Alexander Zuev wrote: >> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line >> 1208: >> >>> 1206: } else { >>> 1207: return new MultiResolutionIconImage(size, >>> multiResolutionIcon); >>> 1208:

Re: RFR: 8320692: Null icon returned for .exe without custom icon [v2]

2024-01-19 Thread Alexey Ivanov
On Thu, 18 Jan 2024 19:40:40 GMT, Alexander Zuev wrote: >> Replaced asserts with NullPointerException calls because outside of testing >> that would be more informative - i do not think many people running their >> applications with assertions in system libraries enabled; >> Added a code that

Re: RFR: JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 [v3]

2024-01-19 Thread Alexander Zvegintsev
On Thu, 18 Jan 2024 22:08:39 GMT, Harshitha Onkar wrote: >> ShapeNotSetSometimes.java fails intermittently on macOS 14. Following is a >> test stabilization fix for macOS 14. With the added delays >> ShapeNotSetSometimes.java passes on older versions of macOS as well as on >> macOS 14.1,

Re: RFR: 6507038: Memory Leak in JTree / BasicTreeUI

2024-01-19 Thread Prasanta Sadhukhan
On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan wrote: > When using a TreeCellRenterer which creates new components in > getTreeCellRendererComponent() in a JTree that is not visible, changes to the > nodes cause a memory leak. > When a node is changed, the Method getNodeDimensions() is