RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3

2024-01-28 Thread Renjith Kannath Pariyangad
Hi Reviewers, Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured. Please review and let me know your suggestions. Regards, Renjith - Commit messages: - JDK-8324808 : Manual

Re: RFR: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations [v3]

2024-01-28 Thread Christoph Langer
> This picks up fixing the issue of > [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had > been integrated with #17224 but @prrace had concerns and so it was backed out. > > I have now spent quite some thoughts into the problem and end up with the > [initial > commit](

Re: RFR: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations [v2]

2024-01-28 Thread Christoph Langer
On Sat, 27 Jan 2024 06:44:59 GMT, Christoph Langer wrote: > Thanks for the review. For some reason, however, I still saw the jni warning > in our env with the patch applied. Still looking into it to understand what > I'm missing... OK, got it. The exception check needs to be before the call to

RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2

2024-01-28 Thread Renjith Kannath Pariyangad
Hi Reviewers, Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured. Please review and let me know your suggestions. Regards, Renjith - Commit messages: - JDK-8324807 : Manual

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v7]

2024-01-28 Thread vtstydev
> More correct way to take in consideration nonzero PHYSICALOFFSETX, > PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows > platform under certain conditions real device prints shifted image on paper. vtstydev has updated the pull request incrementally with one additional

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v11]

2024-01-28 Thread Prasanta Sadhukhan
On Tue, 23 Jan 2024 03:37:45 GMT, Prasanta Sadhukhan wrote: >> javadoc contract for JComponent.setMinimumSize(Dimension) states: >> >> "Sets the minimum size of this component to a constant value. Subsequent >> calls to getMinimumSize will always return this value..." >> >> However, JScrollBa

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v12]

2024-01-28 Thread Prasanta Sadhukhan
> javadoc contract for JComponent.setMinimumSize(Dimension) states: > > "Sets the minimum size of this component to a constant value. Subsequent > calls to getMinimumSize will always return this value..." > > However, JScrollBar overrides getMinimumSize() and breaks this contract - it > always

RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close

2024-01-28 Thread Renjith Kannath Pariyangad
Hi Reviewers, Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured. Please review and let me know your suggestions. Regards, Renjith - Commit messages: - JDK-8320676 : Manual

Re: RFR: 6507038: Memory Leak in JTree / BasicTreeUI [v3]

2024-01-28 Thread Prasanta Sadhukhan
On Wed, 24 Jan 2024 20:25:26 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Retain last component in rendererPane. Testcase added > > test/jdk/javax/swing/plaf/basic/BasicTreeUI/TreeCellRe

Re: RFR: 6507038: Memory Leak in JTree / BasicTreeUI [v4]

2024-01-28 Thread Prasanta Sadhukhan
> When using a TreeCellRenterer which creates new components in > getTreeCellRendererComponent() in a JTree that is not visible, changes to the > nodes cause a memory leak. > When a node is changed, the Method getNodeDimensions() is called to calculate > the new dimensions for the node. In this

Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v4]

2024-01-28 Thread David Holmes
On Sat, 27 Jan 2024 18:24:45 GMT, Coleen Phillimore wrote: >> This mechanically replaces NULL with nullptr in hpp/cpp native files in test >> native code. This didn't attempt to change NULL in comments to say null >> because nullptr is generally the right thing for the comment to say. It >>

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v3]

2024-01-28 Thread Renjith Kannath Pariyangad
On Fri, 26 Jan 2024 00:27:45 GMT, Harshitha Onkar wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Fixed whitespace errors > > @Renjithkannath There are many test changes in a single PR, it would be >

Withdrawn: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close

2024-01-28 Thread Renjith Kannath Pariyangad
On Thu, 25 Jan 2024 04:52:15 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your su

Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v4]

2024-01-28 Thread Kim Barrett
On Sat, 27 Jan 2024 18:24:45 GMT, Coleen Phillimore wrote: >> This mechanically replaces NULL with nullptr in hpp/cpp native files in test >> native code. This didn't attempt to change NULL in comments to say null >> because nullptr is generally the right thing for the comment to say. It >>