Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF [v3]

2024-01-29 Thread Tejesh R
> The issue is w.r.t to way that Synth prints the table. In Synth, the printing > of Table happens column wise by painting blocks of columns which is due to > the fact that Graphics used which is `ProxyGrpahics2D` (which get selected in > `RasterPrinterJob `class, otherwise it would be

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-29 Thread Renjith Kannath Pariyangad
On Tue, 30 Jan 2024 06:30:00 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated manual printer test cases with 'PassFailJFrame', also removed unused >> variables. Added 'SkippedException' in case of printer missing or not >> configured. >> >> Please review and let me know

Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v2]

2024-01-29 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has

Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF

2024-01-29 Thread Tejesh R
On Tue, 30 Jan 2024 06:42:01 GMT, Abhishek Kumar wrote: > > Comparing it to the description/example you gave on the difference, I can't > > seem to recreate that change. These screenshots were generated by using the > > `Print` option on the test and outputting to a PDF file. Any insights for

Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF

2024-01-29 Thread Abhishek Kumar
On Wed, 17 Jan 2024 05:09:02 GMT, Tejesh R wrote: > Comparing it to the description/example you gave on the difference, I can't > seem to recreate that change. These screenshots were generated by using the > `Print` option on the test and outputting to a PDF file. Any insights for why > I'm

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

2024-01-29 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your suggestions. > > Regards, > Renjith Renjith Kannath Pariyangad has

Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF [v2]

2024-01-29 Thread Abhishek Kumar
On Tue, 30 Jan 2024 04:54:05 GMT, Tejesh R wrote: >> The issue is w.r.t to way that Synth prints the table. In Synth, the >> printing of Table happens column wise by painting blocks of columns which is >> due to the fact that Graphics used which is `ProxyGrpahics2D` (which get >> selected in

Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF [v2]

2024-01-29 Thread Prasanta Sadhukhan
On Tue, 30 Jan 2024 04:54:05 GMT, Tejesh R wrote: >> The issue is w.r.t to way that Synth prints the table. In Synth, the >> printing of Table happens column wise by painting blocks of columns which is >> due to the fact that Graphics used which is `ProxyGrpahics2D` (which get >> selected in

Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF [v2]

2024-01-29 Thread Tejesh R
> The issue is w.r.t to way that Synth prints the table. In Synth, the printing > of Table happens column wise by painting blocks of columns which is due to > the fact that Graphics used which is `ProxyGrpahics2D` (which get selected in > `RasterPrinterJob `class, otherwise it would be

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v7]

2024-01-29 Thread Prasanta Sadhukhan
On Mon, 29 Jan 2024 06:56:58 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v7]

2024-01-29 Thread Prasanta Sadhukhan
On Mon, 29 Jan 2024 06:56:58 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has

Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF

2024-01-29 Thread Prasanta Sadhukhan
On Mon, 11 Dec 2023 11:25:34 GMT, Tejesh R wrote: > The issue is w.r.t to way that Synth prints the table. In Synth, the printing > of Table happens column wise by painting blocks of columns which is due to > the fact that Graphics used which is `ProxyGrpahics2D` (which get selected in >

Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF

2024-01-29 Thread Prasanta Sadhukhan
On Mon, 11 Dec 2023 11:25:34 GMT, Tejesh R wrote: > The issue is w.r.t to way that Synth prints the table. In Synth, the printing > of Table happens column wise by painting blocks of columns which is due to > the fact that Graphics used which is `ProxyGrpahics2D` (which get selected in >

Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close

2024-01-29 Thread Harshitha Onkar
On Mon, 29 Jan 2024 06:24:29 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > Updated manual printer test cases with 'PassFailJFrame', also removed unused > variables. Added 'SkippedException' in case of printer missing or not > configured. > > Please review and let me know your

Re: RFR: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations [v3]

2024-01-29 Thread Phil Race
On Mon, 29 Jan 2024 07:13:49 GMT, Christoph Langer wrote: >> This picks up fixing the issue of >> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had >> been integrated with #17224 but @prrace had concerns and so it was backed >> out. >> >> I have now spent quite some

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2024-01-29 Thread Alexey Ivanov
On Fri, 26 Jan 2024 20:11:07 GMT, MustavData wrote: >> Sergey Bylokhov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp >> >> date >> >> Co-authored-by:

Re: RFR: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations [v3]

2024-01-29 Thread Alexey Ivanov
On Mon, 29 Jan 2024 07:13:49 GMT, Christoph Langer wrote: >> This picks up fixing the issue of >> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had >> been integrated with #17224 but @prrace had concerns and so it was backed >> out. >> >> I have now spent quite some

Re: RFR: 8323670: A few client tests intermittently throw ConcurrentModificationException [v2]

2024-01-29 Thread Alexey Ivanov
On Thu, 25 Jan 2024 13:58:50 GMT, Tejesh R wrote: >> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) >> also created concurrent exception intermittently (monthly once/quarterly >> once) on CI system. The issue was not able to be reproduced yet, hence >> proposing an

Re: RFR: JDK-8324238 : [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg

2024-01-29 Thread Damon Nguyen
On Thu, 25 Jan 2024 01:03:28 GMT, Harshitha Onkar wrote: > ShapeNotSetSometimes.java fails on macOS 11 on a random iteration of > `colorCheck()` as shown below. The `colorCheck()` is repeated for about 50 > times in the test. It is observed to pass on previous attempts and fail on a > random

Integrated: JDK-8324733 : [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653

2024-01-29 Thread Harshitha Onkar
On Fri, 26 Jan 2024 20:25:12 GMT, Harshitha Onkar wrote: > Following tests fail on macOS 14 and thus being problemlisted. The reason for > the failures is tracked as an external macOS platform bug by > [JDK-8322653](https://bugs.openjdk.org/browse/JDK-8322653). This pull request has now been

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v7]

2024-01-29 Thread Phil Race
On Mon, 29 Jan 2024 06:56:58 GMT, vtstydev wrote: >> More correct way to take in consideration nonzero PHYSICALOFFSETX, >> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows >> platform under certain conditions real device prints shifted image on paper. > > vtstydev has

Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v5]

2024-01-29 Thread Coleen Phillimore
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore wrote: >> This mechanically replaces NULL with nullptr in hpp/cpp native files in test >> native code. This didn't attempt to change NULL in comments to say null >> because nullptr is generally the right thing for the comment to say. It >>

Integrated: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files

2024-01-29 Thread Coleen Phillimore
On Fri, 26 Jan 2024 16:40:32 GMT, Coleen Phillimore wrote: > This mechanically replaces NULL with nullptr in hpp/cpp native files in test > native code. This didn't attempt to change NULL in comments to say null > because nullptr is generally the right thing for the comment to say. It does

Re: RFR: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations [v3]

2024-01-29 Thread Matthias Baesken
On Mon, 29 Jan 2024 07:13:49 GMT, Christoph Langer wrote: >> This picks up fixing the issue of >> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had >> been integrated with #17224 but @prrace had concerns and so it was backed >> out. >> >> I have now spent quite some

Re: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185

2024-01-29 Thread Matthias Baesken
On Mon, 29 Jan 2024 14:24:43 GMT, Christoph Langer wrote: > The assertions reported in the bug were observed spuriously and here and > there broke tests in some Windows configurations. > For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), >

Re: RFR: 8323670: A few client tests intermittently throw ConcurrentModificationException

2024-01-29 Thread Alexey Ivanov
On Fri, 26 Jan 2024 22:57:49 GMT, Sergey Bylokhov wrote: >>> What is the code path which modifies the vector when we iterate it? >> >> I don't think we are able to trace it out, since the issue intermittent and >> previously I had made a copy of the vector list before checking for equality >>

Re: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185

2024-01-29 Thread Matthias Baesken
On Mon, 29 Jan 2024 14:24:43 GMT, Christoph Langer wrote: >However, it seems to be some kind of a pseudo device where you can not get a >DC via CreateDC. This behavior/monitor type > doesn't seem to be well documented, though. This was my observation too, but is it always the case ?

RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185

2024-01-29 Thread Christoph Langer
The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations. For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or

Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v5]

2024-01-29 Thread Coleen Phillimore
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore wrote: >> This mechanically replaces NULL with nullptr in hpp/cpp native files in test >> native code. This didn't attempt to change NULL in comments to say null >> because nullptr is generally the right thing for the comment to say. It >>

Re: RFR: 8323670: A few client tests intermittently throw ConcurrentModificationException [v2]

2024-01-29 Thread Alexey Ivanov
On Thu, 25 Jan 2024 13:58:50 GMT, Tejesh R wrote: >> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) >> also created concurrent exception intermittently (monthly once/quarterly >> once) on CI system. The issue was not able to be reproduced yet, hence >> proposing an

Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v5]

2024-01-29 Thread Coleen Phillimore
> This mechanically replaces NULL with nullptr in hpp/cpp native files in test > native code. This didn't attempt to change NULL in comments to say null > because nullptr is generally the right thing for the comment to say. It does > attempt to change NULL to "null" rather than "nullptr" in

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v15]

2024-01-29 Thread Prasanta Sadhukhan
> javadoc contract for JComponent.setMinimumSize(Dimension) states: > > "Sets the minimum size of this component to a constant value. Subsequent > calls to getMinimumSize will always return this value..." > > However, JScrollBar overrides getMinimumSize() and breaks this contract - it > always

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v12]

2024-01-29 Thread Alexey Ivanov
On Mon, 29 Jan 2024 10:17:29 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 785: >> >>> 783: * Returns the minimum size for the {@code JScrollBar}. >>> 784: * The scrollbar is flexible along its scrolling axis and >>> 785: *

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v14]

2024-01-29 Thread Alexey Ivanov
On Mon, 29 Jan 2024 10:26:54 GMT, Prasanta Sadhukhan wrote: >> javadoc contract for JComponent.setMinimumSize(Dimension) states: >> >> "Sets the minimum size of this component to a constant value. Subsequent >> calls to getMinimumSize will always return this value..." >> >> However,

Re: RFR: JDK-8324733 : [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653

2024-01-29 Thread Tejesh R
On Fri, 26 Jan 2024 20:25:12 GMT, Harshitha Onkar wrote: > Following tests fail on macOS 14 and thus being problemlisted. The reason for > the failures is tracked as an external macOS platform bug by > [JDK-8322653](https://bugs.openjdk.org/browse/JDK-8322653). Marked as reviewed by tr

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v14]

2024-01-29 Thread Prasanta Sadhukhan
> javadoc contract for JComponent.setMinimumSize(Dimension) states: > > "Sets the minimum size of this component to a constant value. Subsequent > calls to getMinimumSize will always return this value..." > > However, JScrollBar overrides getMinimumSize() and breaks this contract - it > always

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v12]

2024-01-29 Thread Prasanta Sadhukhan
On Mon, 29 Jan 2024 10:07:35 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> javadoc update in JScrollbar and JComponent > > src/java.desktop/share/classes/javax/swing/JScrollBar.java line

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v13]

2024-01-29 Thread Prasanta Sadhukhan
> javadoc contract for JComponent.setMinimumSize(Dimension) states: > > "Sets the minimum size of this component to a constant value. Subsequent > calls to getMinimumSize will always return this value..." > > However, JScrollBar overrides getMinimumSize() and breaks this contract - it > always

Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v12]

2024-01-29 Thread Alexey Ivanov
On Mon, 29 Jan 2024 06:47:50 GMT, Prasanta Sadhukhan wrote: >> javadoc contract for JComponent.setMinimumSize(Dimension) states: >> >> "Sets the minimum size of this component to a constant value. Subsequent >> calls to getMinimumSize will always return this value..." >> >> However,