Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v4]

2024-02-19 Thread Tejesh R
On Tue, 20 Feb 2024 07:21:18 GMT, Sergey Bylokhov wrote: >> This how it is done in >> [RepaintManager](https://github.com/openjdk/jdk/blob/69a11c7f7ea7c4195a8ee56391bdf04c75bd8156/src/java.desktop/share/classes/javax/swing/RepaintManager.java#L1711), >> it uses background color of the componen

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v4]

2024-02-19 Thread Sergey Bylokhov
On Tue, 20 Feb 2024 05:36:55 GMT, Tejesh R wrote: >> Since this is an intermediate buffer its content should not affect the >> rendering, so it should contain only the image rendered by the component >> itself. > > This how it is done in > [RepaintManager](https://github.com/openjdk/jdk/blob/

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-19 Thread Tejesh R
On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov wrote: >> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a >> single *Print* button as its test UI. To simplify the UI, I used the new >> `splitUI` method from #17845. >> >> In addition to it, I refactored the test: >>

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v4]

2024-02-19 Thread Tejesh R
On Tue, 20 Feb 2024 05:34:00 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/javax/swing/BufferStrategyPaintManager.java >> line 252: >> >>> 250: >>> g2d.setBackground(paintingComponent.getBackground()); >>> 251: g2d.clearRect(x, y, w, h);

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v4]

2024-02-19 Thread Sergey Bylokhov
On Tue, 20 Feb 2024 05:17:04 GMT, Sergey Bylokhov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Frame dispose moved into EDT > > src/java.desktop/share/classes/javax/swing/BufferStrategyPaintManager.java > line 252:

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v4]

2024-02-19 Thread Sergey Bylokhov
On Mon, 12 Feb 2024 05:38:17 GMT, Tejesh R wrote: >> This is happening in linux where `BuffereStrategyPaintManager` is used to >> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint >> to offscreen where the background is not refreshed, which does only clipping >> and

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v4]

2024-02-19 Thread Sergey Bylokhov
On Mon, 12 Feb 2024 05:38:17 GMT, Tejesh R wrote: >> This is happening in linux where `BuffereStrategyPaintManager` is used to >> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint >> to offscreen where the background is not refreshed, which does only clipping >> and

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v3]

2024-02-19 Thread Sergey Bylokhov
On Wed, 14 Feb 2024 18:09:15 GMT, Per Minborg wrote: >> This PR proposes to remove the use of `Unsafe` in the class >> `XEmbeddingContainer ` and replace it with the supported FFM API. >> >> I tried to make this PR as small as possible while opening up for migration >> of other classes later o

Integrated: 8325950: Make sure all files in the JDK pass jcheck

2024-02-19 Thread Magnus Ihse Bursie
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote: > Since jcheck only checks file in a commit, there is a possibility of us > getting files in the repository that would not be accepted by jcheck. This > can happen when extending the set of files checked by jcheck, or if jcheck > chan

Integrated: 8307246 : Printing: banded raster path doesn't account for device offset values

2024-02-19 Thread vtstydev
On Fri, 8 Dec 2023 05:52:46 GMT, vtstydev wrote: > More correct way to take in consideration nonzero PHYSICALOFFSETX, > PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows > platform under certain conditions real device prints shifted image on paper. This pull request ha

RFR: JDK-8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns

2024-02-19 Thread Matthias Baesken
In AccessBridgeJavaEntryPoints.cpp we have a couple of exception checks with potential early returns. Those miss ReleaseStringChars . - Commit messages: - JDK-8326140 Changes: https://git.openjdk.org/jdk/pull/17915/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17915&range

Re: RFR: JDK-8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns

2024-02-19 Thread Matthias Baesken
On Mon, 19 Feb 2024 13:04:47 GMT, Matthias Baesken wrote: > In AccessBridgeJavaEntryPoints.cpp we have a couple of exception checks with > potential early returns. Those miss ReleaseStringChars . btw there might be further room for improvement / simplification. The current macro code blocks lo

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-19 Thread Dmitry Markov
On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov wrote: >> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a >> single *Print* button as its test UI. To simplify the UI, I used the new >> `splitUI` method from #17845. >> >> In addition to it, I refactored the test: >>

Re: RFR: 8294148: Support JSplitPane for instructions and test UI

2024-02-19 Thread Dmitry Markov
On Wed, 14 Feb 2024 13:22:48 GMT, Alexey Ivanov wrote: > This enhancement adds three methods to `PassFailJFrame.Builder`: > > 1. **`splitUIRight`** to display test UI to the right of the instructions; > 2. **`splitUIBottom`** to display test UI to the bottom of the instructions; > 3. `splitUI`:

Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v50]

2024-02-19 Thread Magnus Ihse Bursie
On Sun, 21 Jan 2024 07:58:11 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less acceptin

Re: RFR: 8325097: [macos14] Test "java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.html" failed on macOS 14.3 aarch64 when double-click with the right button on the tray icon with m

2024-02-19 Thread Tejesh R
On Fri, 16 Feb 2024 21:30:21 GMT, Alisen Chung wrote: >> Root cause of the test failure was fixed with >> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the >> other fix also included a test update. > > Alisen Chung has updated the pull request incrementally with one addi

Re: RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v10]

2024-02-19 Thread Alexey Ivanov
On Mon, 19 Feb 2024 06:02:10 GMT, Prasanta Sadhukhan wrote: > guess you can do "\integrate" for us to "sponsor" Or rather, @vtstydev, issue the [`/integrate`](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate) command to integrate the fix. Someone wil