Integrated: 8187759: Background not refreshed when painting over a transparent JFrame

2024-02-20 Thread Tejesh R
On Tue, 12 Dec 2023 13:04:26 GMT, Tejesh R wrote: > This is happening in linux where `BuffereStrategyPaintManager` is used to > paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint > to offscreen where the background is not refreshed, which does only clipping > and then

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v4]

2024-02-20 Thread Sergey Bylokhov
On Wed, 21 Feb 2024 04:27:13 GMT, Tejesh R wrote: >> That code was added by me to implement the shaped windows on macOS, that is >> the only platform we support the translucent backbuffer in RepaintManager. >> For the translucent backbuffer and even opaque component it is necessary to >> clear

Re: RFR: 8325097: [macos14] Test "java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.html" failed on macOS 14.3 aarch64 when double-click with the right button on the tray icon with m

2024-02-20 Thread Abhishek Kumar
On Tue, 20 Feb 2024 21:01:11 GMT, Alisen Chung wrote: >> Root cause of the test failure was fixed with >> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the >> other fix also included a test update. > > Alisen Chung has updated the pull request incrementally with one addi

Re: RFR: 8187759: Background not refreshed when painting over a transparent JFrame [v4]

2024-02-20 Thread Tejesh R
On Tue, 20 Feb 2024 07:21:18 GMT, Sergey Bylokhov wrote: >> This how it is done in >> [RepaintManager](https://github.com/openjdk/jdk/blob/69a11c7f7ea7c4195a8ee56391bdf04c75bd8156/src/java.desktop/share/classes/javax/swing/RepaintManager.java#L1711), >> it uses background color of the componen

Re: RFR: 8325097: [macos14] Test "java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.html" failed on macOS 14.3 aarch64 when double-click with the right button on the tray icon with m

2024-02-20 Thread Tejesh R
On Tue, 20 Feb 2024 21:01:11 GMT, Alisen Chung wrote: >> Root cause of the test failure was fixed with >> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the >> other fix also included a test update. > > Alisen Chung has updated the pull request incrementally with one addi

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v3]

2024-02-20 Thread Phil Race
On Wed, 14 Feb 2024 18:09:15 GMT, Per Minborg wrote: >> This PR proposes to remove the use of `Unsafe` in the class >> `XEmbeddingContainer ` and replace it with the supported FFM API. >> >> I tried to make this PR as small as possible while opening up for migration >> of other classes later o

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v3]

2024-02-20 Thread Phil Race
On Wed, 21 Feb 2024 01:55:57 GMT, Sergey Bylokhov wrote: > > Embedded frames are for applets (dead) and JAWT and SWT. I don't see how > > any of those could use this. > > yeah, I meant jawt, not eawt. SWT used some of the code directly from the > native code, so they bypassed private access an

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v3]

2024-02-20 Thread Sergey Bylokhov
On Wed, 21 Feb 2024 01:23:34 GMT, Phil Race wrote: > Embedded frames are for applets (dead) and JAWT and SWT. I don't see how any > of those could use this. yeah, I meant jawt, not eawt. SWT used some of the code directly from the native code, so they bypassed private access and modules. Might

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v3]

2024-02-20 Thread Phil Race
On Wed, 21 Feb 2024 00:45:08 GMT, Sergey Bylokhov wrote: > > Anyone have ANY idea where or how this might be used ? I'd like to be sure > > before I propose that. > > When the eawt was enhanced to support embedded frames all related > non-public/internal code was not deleted - it was found tha

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v3]

2024-02-20 Thread Sergey Bylokhov
On Tue, 20 Feb 2024 22:46:58 GMT, Phil Race wrote: >Anyone have ANY idea where or how this might be used ? I'd like to be sure >before I propose that. When the eawt was enhanced to support embedded frames all related non-public/internal code was not deleted - it was found that people used that

Re: RFR: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API [v3]

2024-02-20 Thread Phil Race
On Wed, 14 Feb 2024 18:09:15 GMT, Per Minborg wrote: >> This PR proposes to remove the use of `Unsafe` in the class >> `XEmbeddingContainer ` and replace it with the supported FFM API. >> >> I tried to make this PR as small as possible while opening up for migration >> of other classes later o

Re: RFR: 8325097: [macos14] Test "java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.html" failed on macOS 14.3 aarch64 when double-click with the right button on the tray icon with m

2024-02-20 Thread Alisen Chung
> Root cause of the test failure was fixed with > https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the > other fix also included a test update. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: update test strings

Integrated: 8294148: Support JSplitPane for instructions and test UI

2024-02-20 Thread Alexey Ivanov
On Wed, 14 Feb 2024 13:22:48 GMT, Alexey Ivanov wrote: > This enhancement adds three methods to `PassFailJFrame.Builder`: > > 1. **`splitUIRight`** to display test UI to the right of the instructions; > 2. **`splitUIBottom`** to display test UI to the bottom of the instructions; > 3. `splitUI`:

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-20 Thread Alexey Ivanov
On Tue, 20 Feb 2024 10:34:46 GMT, Tejesh R wrote: >> Yes, we can. There's `@key printer` which implies the test is to be run on a >> system where at least one printer is available. >> >> What do you suggest actually? > > I am thinking whether the printer availability check is required at > Ins

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-20 Thread Tejesh R
On Tue, 20 Feb 2024 10:11:14 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 53: >> >>> 51: >>> 52: private static final String INFO = """ >>> 53: You need a printer for this test. If you have none, let >> >> Can we use `PrinterJob.lo

Re: RFR: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java [v2]

2024-02-20 Thread Alexey Ivanov
On Tue, 20 Feb 2024 06:56:06 GMT, Tejesh R wrote: >> Alexey Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - Merge 8294148-splitUI >> - Revert the condition in print() >> - Update copyright year >> -

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v2]

2024-02-20 Thread Abhishek Kumar
On Fri, 16 Feb 2024 19:16:45 GMT, Abhishek Kumar wrote: > @mrserb [JDK-8298153](https://bugs.openjdk.org/browse/JDK-8298153) issue > raised by you for JCheckBox and JRadioButton has similar issue with JLabel. > The proposed fix here resolves the issue for JLabel and similar approach is > appli

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v3]

2024-02-20 Thread Abhishek Kumar
> JLabel text is not painted with the LAF defined foreground color in GTK LAF. > In GTK LAF the foreground color is retrieved by using native system APIs. Fix > is to return the foreground color if it is set by LAF defined property > otherwise return the default color by calling native APIs. > A