On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
> sp
On Fri, 23 Feb 2024 21:43:21 GMT, Phil Race wrote:
> The change looks good but I'd like to run it through all our tests since if
> there's anything wrong with this code path we are in trouble :-)
Yes, please test thoroughly and let me know. I'll give it another spin in our
testing as well.
>
On Fri, 23 Feb 2024 15:58:18 GMT, Maxim Kartashev
wrote:
> XToolkit implements `toFront()` essentially by sending the
> `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when
> the target window is in the iconified state. So the fix is to cancel that
> state prior to se
On 2024-02-23 23:31, Philip Race wrote:
> I have no idea if you have contributed to OpenJDK before.,
> If you have not, follow the instructions at
> https://openjdk.org/guide/#sign-the-oca
> and in general read as much of that guide as makes sense for you.
Sounds good, thanks.
> After that I sugg
On Fri, 23 Feb 2024 13:44:15 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>> [JDK-8269529](https://bugs.op
I have no idea if you have contributed to OpenJDK before.,
If you have not, follow the instructions at
https://openjdk.org/guide/#sign-the-oca
and in general read as much of that guide as makes sense for you.
After that I suggest a ROUGH draft github PR be posted here, so we can
see what it
a
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
> sp
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
> sp
The idea of setting up general "toolchains" in the native build was good, but
it turned out that we really only need a single toolchain, with a single twist:
if it should use CC or CPP to link. This is better described by a specific
argument to SetupNativeCompilation, LANG := C++ or LANG := C (t
XToolkit implements `toFront()` essentially by sending the
`_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when
the target window is in the iconified state. So the fix is to cancel that state
prior to sending the message.
The test verifies that the fix works for maximiz
On Fri, 16 Feb 2024 13:26:19 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>> [JDK-8269529](https://bugs.op
> The assertions reported in the bug were observed spuriously and here and
> there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
> [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or
> [JDK-8323664](https://bugs.o
> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a
> single *Print* button as its test UI. To simplify the UI, I used the new
> `splitUI` method from #17845.
>
> In addition to it, I refactored the test:
>
> - Extracted the rendered text into a constant to ensure the s
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
14 matches
Mail list logo
