RFR: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

Introduce delays in test to stabilize. Test passes 50x after fix. - Commit messages: - added delays to stabilize test Changes: https://git.openjdk.org/jdk/pull/18091/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18091&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

On Mon, 29 Jan 2024 20:56:42 GMT, Alexey Ivanov wrote: >> I am working to verify the initial fix of JDK-8270269 in OpenJDK 23 (beta). >> The basic environment is: >> >> OpenJDK: "Azul Systems, Inc.", "Zulu23+11-CA", "23-beta+1", "x86_64", >> ".:git:e278d5994c10+" >> OS: Windows 11,

Re: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10 is pressed [v4]

On Fri, 1 Mar 2024 15:06:49 GMT, Alexey Ivanov wrote: > Is the line too long without wrapping? It's around 100 columns.. so wrapping looks good to me. - PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509199308

Re: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10 is pressed [v2]

On Fri, 1 Mar 2024 10:42:31 GMT, Alexey Ivanov wrote: >>> You could add @modules java.desktop/com.sun.java.swing.plaf.windows to >>> jtreg tags and access the >>> com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method >>> to verify that the mnemonics are shown or hidden bas

Re: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10 is pressed [v5]

> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. > Behavior is not similar to windows native application. Fix is to ensure that > menu mnemonic state toggles between show and hide. > > Can be verified with SwingSet2 application. > CI tests are green with the fix.

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v4]

On Fri, 1 Mar 2024 11:39:09 GMT, Abhishek Kumar wrote: >> Menu mnemonic doesn't toggle between show and hide state when F10 is >> pressed. Behavior is not similar to windows native application. Fix is to >> ensure that menu mnemonic state toggles between show and hide. >> >> Can be verified wi

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v3]

On Thu, 29 Feb 2024 07:48:09 GMT, Abhishek Kumar wrote: >> Menu mnemonic doesn't toggle between show and hide state when F10 is >> pressed. Behavior is not similar to windows native application. Fix is to >> ensure that menu mnemonic state toggles between show and hide. >> >> Can be verified w

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v4]

> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. > Behavior is not similar to windows native application. Fix is to ensure that > menu mnemonic state toggles between show and hide. > > Can be verified with SwingSet2 application. > CI tests are green with the fix.

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v2]

On Fri, 1 Mar 2024 10:22:16 GMT, Abhishek Kumar wrote: > > You could add @modules java.desktop/com.sun.java.swing.plaf.windows to > > jtreg tags and access the > > com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method > > to verify that the mnemonics are shown or hidden ba

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v4]

On Fri, 1 Mar 2024 10:38:21 GMT, Abhishek Kumar wrote: >> JLabel text is not painted with the LAF defined foreground color in GTK LAF. >> In GTK LAF the foreground color is retrieved by using native system APIs. >> Fix is to return the foreground color if it is set by LAF defined property >> o

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v4]

> JLabel text is not painted with the LAF defined foreground color in GTK LAF. > In GTK LAF the foreground color is retrieved by using native system APIs. Fix > is to return the foreground color if it is set by LAF defined property > otherwise return the default color by calling native APIs. > A

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v2]

On Thu, 29 Feb 2024 11:24:38 GMT, Alexey Ivanov wrote: > You could add @modules java.desktop/com.sun.java.swing.plaf.windows to jtreg > tags and access the > com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method to > verify that the mnemonics are shown or hidden based on h

Re: RFR: 8286759: TextComponentPrintable: consequent -> consecutive positions

On Thu, 29 Feb 2024 15:13:16 GMT, Alexey Ivanov wrote: > A trivial change in a comment: consequent → _consecutive_ positions. > > This was found in [a code > review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for > [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306)

Re: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v7]

On Thu, 29 Feb 2024 22:24:14 GMT, Christoph Langer wrote: >> The assertions reported in the bug were observed spuriously and here and >> there broke tests in some Windows configurations. >> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), >> [JDK-8269529](https://bugs.op

Re: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v8]

> The assertions reported in the bug were observed spuriously and here and > there broke tests in some Windows configurations. > For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), > [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or > [JDK-8323664](https://bugs.o