Re: RFR: 8321428: Deprecate for removal the package java.beans.beancontext [v4]

2024-04-10 Thread Sergey Bylokhov
On Wed, 10 Apr 2024 21:25:06 GMT, Larry Cable wrote: >> the beancontext package was added (by me) in JDK 1.2 to provide >> JavaBeans(tm) with a containment and services hierarchy. >> >> based upon concepts from OpenDoc, which was a popular component model at the >> time, the API pre-dated the

Re: RFR: 8321428: Deprecate for removal the package java.beans.beancontext [v4]

2024-04-10 Thread Larry Cable
> the beancontext package was added (by me) in JDK 1.2 to provide JavaBeans(tm) > with a containment and services hierarchy. > > based upon concepts from OpenDoc, which was a popular component model at the > time, the API pre-dated the addition of language features such as > annotations, and

Re: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does not work on macOS

2024-04-10 Thread Tres Finocchiaro
On Mon, 8 Apr 2024 23:19:13 GMT, Phil Race wrote: >> The fix provides ability to print Black & White pages on macOS. >> >> Cocoa API has >> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) >> function but it is marked as

Re: RFR: 8321428: Deprecate for removal the package java.beans.beancontext

2024-04-10 Thread Larry Cable
On Tue, 2 Apr 2024 15:52:29 GMT, Sergey Bylokhov wrote: > > public code corpus should be searched prior to removal in order to > > determine impact. > > What are results of that search? a cursory search revealed almost no usage, a more in depth search should be performed prior to actual

Re: RFR: 8321428: Deprecate for removal the package java.beans.beancontext [v2]

2024-04-10 Thread Larry Cable
On Tue, 9 Apr 2024 13:57:31 GMT, Alexey Ivanov wrote: > Should the copyright year be bumped to 2024 in all the modified files? yes, my bad I'll update and push... - PR Comment: https://git.openjdk.org/jdk/pull/18569#issuecomment-2048202242

Re: RFR: 8321428: Deprecate for removal the package java.beans.beancontext [v3]

2024-04-10 Thread Larry Cable
> the beancontext package was added (by me) in JDK 1.2 to provide JavaBeans(tm) > with a containment and services hierarchy. > > based upon concepts from OpenDoc, which was a popular component model at the > time, the API pre-dated the addition of language features such as > annotations, and

Integrated: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel

2024-04-10 Thread Alexey Ivanov
On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov wrote: > I'm adding a regression test for > [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and > [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a > regression test for >

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Tejesh R
On Wed, 10 Apr 2024 11:23:22 GMT, Tejesh R wrote: >> test/jdk/javax/swing/JTable/JTableScrollPrintTest.java line 45: >> >>> 43: * @test >>> 44: * @key headful >>> 45: * @bug 8210807 8322140 >> >> Suggestion: >> >> You may update the test with `PassFailJFrame.builder()`. >> >> I guess

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Tejesh R
On Wed, 10 Apr 2024 08:56:08 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >>

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-10 Thread Abhishek Kumar
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L [v5]

2024-04-10 Thread Abhishek Kumar
On Tue, 5 Mar 2024 05:28:01 GMT, Abhishek Kumar wrote: >> JLabel text is not painted with the LAF defined foreground color in GTK LAF. >> In GTK LAF the foreground color is retrieved by using native system APIs. >> Fix is to return the foreground color if it is set by LAF defined property >>

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Tejesh R
On Wed, 10 Apr 2024 09:05:49 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >>

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L [v5]

2024-04-10 Thread Abhishek Kumar
On Tue, 26 Mar 2024 08:22:52 GMT, Prasanta Sadhukhan wrote: >> @aivanov-jdk >> >>> This looks weird… So you're saying Label[Enabled].textForeground and >>> Label[Disabled].textForeground are used for Nimbus (and Synth and GTK) >>> instead of Label.foreground and Label.disabledForeground

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Tejesh R
On Wed, 10 Apr 2024 10:27:03 GMT, Abhishek Kumar wrote: >> I'm sure whether a new Graphics2D object will be created or reference will >> be passed, just vaguely remember a conversation regarding disposing it and >> suggested not to dispose since a reference will be passed on. So not sure >>

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Abhishek Kumar
On Wed, 10 Apr 2024 09:59:19 GMT, Tejesh R wrote: >> Since you are creating it locally, I guess you can dispose it. > > I'm sure whether a new Graphics2D object will be created or reference will be > passed, just vaguely remember a conversation regarding disposing it and > suggested not to

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Tejesh R
On Wed, 10 Apr 2024 09:51:05 GMT, Abhishek Kumar wrote: >> I'm not sure whether we have to dispose it here at this context. > > Since you are creating it locally, I guess you can dispose it. I'm sure whether a new Graphics2D object will be created or reference will be passed, just vaguely

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Abhishek Kumar
On Wed, 10 Apr 2024 09:32:42 GMT, Tejesh R wrote: >> src/java.desktop/share/classes/sun/print/PathGraphics.java line 1155: >> >>> 1153: >>> resolutionImage.getHeight(null), >>> 1154:

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Tejesh R
On Wed, 10 Apr 2024 08:57:00 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >>

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v3]

2024-04-10 Thread Abhishek Kumar
On Wed, 10 Apr 2024 04:43:29 GMT, Tejesh R wrote: >> Fix suggested in bug >> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) >> had a regression in Nimbus L yet it resolved the issue in other L The >> better approach would be to handle

Integrated: 8328482: Convert and Open source few manual applet test to main based

2024-04-10 Thread Tejesh R
On Fri, 22 Mar 2024 09:48:08 GMT, Tejesh R wrote: > Convert and open source these manual applet test to main based: > java/awt/Frame/MegaIconTest/MegaIconTest.html > java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html > java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html >