Integrated: 8322135: Printing JTable in Windows L&F throws InternalError: HTHEME is null

2024-04-24 Thread Tejesh R
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote: > Getting a theme for particular dpi failed in windows L&F during print test. > Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme > was independent of DPI. After the fix > (https://github.com/openjdk/jdk/commit/a63afa

Re: RFR: 8323965: modify fix for 8317771 to remove reflection instantiation of the inner class

2024-04-24 Thread Alexander Zuev
On Fri, 19 Apr 2024 15:16:41 GMT, Artem Semenov wrote: > I replaced reflection with using an accessor > @azuev-java please review src/java.desktop/share/classes/javax/swing/JTree.java line 4276: > 4274: > 4275: static { > 4276: SwingAccessor.setAccessibleJTreeNodeCreateAcce

Integrated: 8328896: Fontmetrics for large Fonts has zero width

2024-04-24 Thread Phil Race
On Tue, 9 Apr 2024 18:50:17 GMT, Phil Race wrote: > The main problem here is that we do not curate what font point size we passed > to freetype, > and would pass in one larger than freetype's maximum of FT_USHORT_MAX which > is USHRT_MAX. > This isn't documented, SFAICS, and is checked a couple

Integrated: 8314592: Add shortcut to SymbolLookup::find

2024-04-24 Thread Per Minborg
On Mon, 25 Mar 2024 14:56:23 GMT, Per Minborg wrote: > While `SymbolLookup` correctly uses an `Optional` return to denote whether a > symbol has been found by the lookup or not (which enables composition of > symbol lookups), many clients end up just calling `Optional::get`, or > `Optional::or

Re: RFR: 8314592: Add shortcut to SymbolLookup::find [v7]

2024-04-24 Thread Per Minborg
On Mon, 22 Apr 2024 13:46:59 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> co

Re: RFR: 8314592: Add shortcut to SymbolLookup::find [v8]

2024-04-24 Thread Per Minborg
> While `SymbolLookup` correctly uses an `Optional` return to denote whether a > symbol has been found by the lookup or not (which enables composition of > symbol lookups), many clients end up just calling `Optional::get`, or > `Optional::orElseThrow()` on the result. > > This PR proposes to ad

Re: Usage of iconv()

2024-04-24 Thread Magnus Ihse Bursie
That is a good question. libiconv is used only on macOS and AIX, for a few libraries, as you say. I just tried removing -liconv from the macOS dependencies and recompiled, just to see what would happen. There were three instances for macOS: libsplashscreen, libjdwp and libinstrument. Out of th

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-04-24 Thread Magnus Ihse Bursie
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote: > WIP > > This changeset contains hsdis for Windows/gcc Port. It supports both the > binutils and capstone backends, though the LLVM backend is left out due to > compatibility issues encountered during the build. Currently, which gcc > di