Question about coalescing COMPONENT_RESIZED events

2024-04-25 Thread Jeremy Wood
I’m looking for general feedback/advice. Is there any reason not to put the following method in a Component? @Override protected AWTEvent coalesceEvents(AWTEvent existingEvent, AWTEvent newEvent) { if (newEvent.getID() == ComponentEvent.COMPONENT_RESIZED) return newEvent;

Re: RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel

2024-04-25 Thread Sergey Bylokhov
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote: > This PR provides a regression test for > [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in > BasicDirectoryModel.validateFileCache_ reviewed in #18111. > > The test is inspired and based on `ConcurrentModification`

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v9]

2024-04-25 Thread Vicente Romero
On Thu, 25 Apr 2024 23:24:07 GMT, Jonathan Gibbons wrote: >> Please review the updates to support a proposed new >> `-Xlint:dangling-doc-comments` option. >> >> The work can be thought of as in 3 parts: >> >> 1. An update to the `javac` internal class `DeferredLintHandler` so that it >> is

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v9]

2024-04-25 Thread Jonathan Gibbons
> Please review the updates to support a proposed new > `-Xlint:dangling-doc-comments` option. > > The work can be thought of as in 3 parts: > > 1. An update to the `javac` internal class `DeferredLintHandler` so that it > is possible to specify the appropriately configured `Lint` object when

Re: RFR: JDK-8329004 : Update Libpng to 1.6.43 [v3]

2024-04-25 Thread Harshitha Onkar
> Libpng updated from 1.6.40 to 1.6.43 Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: Updating.txt - Changes: - all: https://git.openjdk.org/jdk/pull/18964/files - new:

Re: RFR: JDK-8329004 : Update Libpng to 1.6.43 [v2]

2024-04-25 Thread Harshitha Onkar
On Thu, 25 Apr 2024 22:46:23 GMT, Phil Race wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added missing 4 lines of header > > src/java.desktop/share/native/libsplashscreen/libpng/png.h line 30: > >> 28: *

Re: RFR: JDK-8329004 : Update Libpng to 1.6.43 [v2]

2024-04-25 Thread Harshitha Onkar
> Libpng updated from 1.6.40 to 1.6.43 Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: added missing 4 lines of header - Changes: - all: https://git.openjdk.org/jdk/pull/18964/files - new:

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v8]

2024-04-25 Thread Jonathan Gibbons
> Please review the updates to support a proposed new > `-Xlint:dangling-doc-comments` option. > > The work can be thought of as in 3 parts: > > 1. An update to the `javac` internal class `DeferredLintHandler` so that it > is possible to specify the appropriately configured `Lint` object when

Re: RFR: JDK-8329004 : Update Libpng to 1.6.43

2024-04-25 Thread Phil Race
On Thu, 25 Apr 2024 22:28:06 GMT, Harshitha Onkar wrote: > Libpng updated from 1.6.40 to 1.6.43 src/java.desktop/share/native/libsplashscreen/libpng/png.h line 30: > 28: * License version 2 only, as published by the Free Software Foundation. > 29: * However, the following notice accompanied

RFR: JDK-8329004 : Update Libpng to 1.6.43

2024-04-25 Thread Harshitha Onkar
Libpng updated from 1.6.40 to 1.6.43 - Commit messages: - .md file update - libpng update v1.6.43 Changes: https://git.openjdk.org/jdk/pull/18964/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18964=00 Issue: https://bugs.openjdk.org/browse/JDK-8329004 Stats: 694 lines

Re: RFR: 8331011: [XWayland] TokenStorage fails under Security Manager [v2]

2024-04-25 Thread Phil Race
On Thu, 25 Apr 2024 17:22:48 GMT, Alexander Zvegintsev wrote: >> This fix adds missing doPrivileged calls in TokenStorage, which is used to >> help take screenshots in Wayland. > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last

Re: Usage of iconv()

2024-04-25 Thread Philip Race
On 4/24/24 4:24 AM, Magnus Ihse Bursie wrote: That is a good question. libiconv is used only on macOS and AIX, for a few libraries, as you say. I just tried removing -liconv from the macOS dependencies and recompiled, just to see what would happen. There were three instances for macOS:

Re: RFR: 8331011: [XWayland] TokenStorage fails under Security Manager [v2]

2024-04-25 Thread Alexander Zvegintsev
> This fix adds missing doPrivileged calls in TokenStorage, which is used to > help take screenshots in Wayland. Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision: fix copyright years - Changes: - all:

Re: RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel

2024-04-25 Thread Alexey Ivanov
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote: > This PR provides a regression test for > [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in > BasicDirectoryModel.validateFileCache_ reviewed in #18111. > > The test is inspired and based on `ConcurrentModification`

RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel

2024-04-25 Thread Alexey Ivanov
This PR provides a regression test for [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in BasicDirectoryModel.validateFileCache_ reviewed in #18111. The test is inspired and based on `ConcurrentModification` that I wrote for

RFR: 8331011: [XWayland] TokenStorage fails under Security Manager

2024-04-25 Thread Alexander Zvegintsev
This fix adds missing doPrivileged calls in TokenStorage, which is used to help take screenshots in Wayland. - Commit messages: - initial Changes: https://git.openjdk.org/jdk/pull/18950/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18950=00 Issue:

Re: RFR: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected [v2]

2024-04-25 Thread Abhishek Kumar
On Tue, 23 Apr 2024 07:51:59 GMT, Tejesh R wrote: >> Instructions set has been updated as per OS specific. JTable keyboard >> navigation is tested in each OS and according it's current implementation >> the instructions has been updated (Few has been removed and few has been >> updated). >>