Re: RFR: 8331011: [XWayland] TokenStorage fails under Security Manager [v2]

2024-04-29 Thread Sergey Bylokhov
On Thu, 25 Apr 2024 17:22:48 GMT, Alexander Zvegintsev wrote: >> This fix adds missing doPrivileged calls in TokenStorage, which is used to >> help take screenshots in Wayland. > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-29 Thread Sergey Bylokhov
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev wrote: >> Some tests try to get the focus of a window by clicking on its title bar. >> >> On XWayland, however, emulating mouse clicks with XTEST currently only >> affects the XWayland server, not the window decorations, so trying to

Re: RFR: JDK-8329692 : Add more details to FrameStateTest.java test instructions

2024-04-29 Thread Abhishek Kumar
On Mon, 29 Apr 2024 23:24:19 GMT, Harshitha Onkar wrote: > For the following manual test, more instructions are added as to what to > expect for "hide,iconify and show" vs "hide,iconify,show and restore" for > clarity. Since these lines are unchanged, can't add comments there. 1. AT L155,

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-29 Thread Alexander Zvegintsev
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev wrote: >> Some tests try to get the focus of a window by clicking on its title bar. >> >> On XWayland, however, emulating mouse clicks with XTEST currently only >> affects the XWayland server, not the window decorations, so trying to

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-29 Thread Alexander Zvegintsev
On Mon, 29 Apr 2024 21:08:28 GMT, Harshitha Onkar wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > test/jdk/java/awt/regtesthelpers/Util.java line 674: > >> 672: return

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-29 Thread Alexander Zvegintsev
> Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click > on the window title will have no effect. > > So the solution is

Re: RFR: 8331011: [XWayland] TokenStorage fails under Security Manager [v2]

2024-04-29 Thread Harshitha Onkar
On Thu, 25 Apr 2024 17:22:48 GMT, Alexander Zvegintsev wrote: >> This fix adds missing doPrivileged calls in TokenStorage, which is used to >> help take screenshots in Wayland. > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last

RFR: JDK-8329692 : Add more details to FrameStateTest.java test instructions

2024-04-29 Thread Harshitha Onkar
For the following manual test, more instructions are added as to what to expect for "hide,iconify and show" vs "hide,iconify,show and restore" for clarity. - Commit messages: - minor update - added instructions for clarity Changes: https://git.openjdk.org/jdk/pull/19008/files

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures

2024-04-29 Thread Harshitha Onkar
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev wrote: > Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click >

Re: RFR: 8328999: Update GIFlib to 5.2.2

2024-04-29 Thread Alexander Zvegintsev
On Fri, 26 Apr 2024 22:02:38 GMT, Phil Race wrote: >> Updating giflib, clientlibs tests are green on all platforms > > src/java.desktop/share/native/libsplashscreen/giflib/gif_hash.h line 40: > >> 38: #include >> 39: #endif >> 40: /** End JDK modifications to support building on Windows **/ >

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures

2024-04-29 Thread Harshitha Onkar
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev wrote: > Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click >

Re: RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel [v2]

2024-04-29 Thread Alexey Ivanov
> This PR provides a regression test for > [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in > BasicDirectoryModel.validateFileCache_ reviewed in #18111. > > The test is inspired and based on `ConcurrentModification` that I wrote for >

Re: RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel

2024-04-29 Thread Tejesh R
On Mon, 29 Apr 2024 14:45:43 GMT, Tejesh R wrote: > > Is it necessary to create dummy files here in this test? Can't we just > > create JFileChooser without creating dummy files and proceed with loader > > test? Because I tested without using dummy files and getting exception > > without

Re: RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel

2024-04-29 Thread Tejesh R
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote: > This PR provides a regression test for > [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in > BasicDirectoryModel.validateFileCache_ reviewed in #18111. > > The test is inspired and based on `ConcurrentModification`

Integrated: JDK-8329004 : Update Libpng to 1.6.43

2024-04-29 Thread Harshitha Onkar
On Thu, 25 Apr 2024 22:28:06 GMT, Harshitha Onkar wrote: > Libpng updated from 1.6.40 to 1.6.43 This pull request has now been integrated. Changeset: 4e422943 Author:Harshitha Onkar URL: https://git.openjdk.org/jdk/commit/4e4229438ad2e8ac59ac675465e4d3d4e13bf156 Stats: 610

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures

2024-04-29 Thread Victor Dyakov
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev wrote: > Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click >

Re: RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel

2024-04-29 Thread Tejesh R
On Mon, 29 Apr 2024 13:22:00 GMT, Alexey Ivanov wrote: > > Is it necessary to create dummy files here in this test? Can't we just > > create JFileChooser without creating dummy files and proceed with loader > > test? Because I tested without using dummy files and getting exception > > without

Re: RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel

2024-04-29 Thread Alexey Ivanov
On Mon, 29 Apr 2024 10:42:26 GMT, Tejesh R wrote: > Is it necessary to create dummy files here in this test? Can't we just create > JFileChooser without creating dummy files and proceed with loader test? > Because I tested without using dummy files and getting exception without > JDK-8325179

Re: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]

2024-04-29 Thread Alexey Ivanov
On Mon, 29 Apr 2024 12:44:14 GMT, Joel Uckelman wrote: > Will this be backported to Java 21 and 22? It would be very helpful if it > could be. It is already backported to 22. I'm working on backporting it to all supported Oracle releases of Java. It is up to the OpenJDK community to backport

Re: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]

2024-04-29 Thread Joel Uckelman
On Tue, 5 Mar 2024 17:40:01 GMT, Alexey Ivanov wrote: >> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there >> are cases where >> `a < b & b < c but a == c` >> which *violates its general contract*. >> >> In particular, it happens for the personal folder

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures

2024-04-29 Thread Alexander Zvegintsev
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev wrote: > Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click >

RFR: 8280988: [XWayland] Click on title to request focus test failures

2024-04-29 Thread Alexander Zvegintsev
Some tests try to get the focus of a window by clicking on its title bar. On XWayland, however, emulating mouse clicks with XTEST currently only affects the XWayland server, not the window decorations, so trying to click on the window title will have no effect. So the solution is to click

Re: RFR: 8331142: Add test for number of loader threads in BasicDirectoryModel

2024-04-29 Thread Tejesh R
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote: > This PR provides a regression test for > [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in > BasicDirectoryModel.validateFileCache_ reviewed in #18111. > > The test is inspired and based on `ConcurrentModification`

RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF

2024-04-29 Thread Abhishek Kumar
In GTK LAF, the menu mnemonics are always displayed which is different from the native behavior. In native application **(tested with gedit**), the menu mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially and then toggles between show/hide on `ALT` press. Proposed fix