Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v2]

2024-05-07 Thread Abhishek Kumar
On Wed, 8 May 2024 05:05:02 GMT, Tejesh R wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Var moved to local scope > > test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 48: > >> 46:

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v2]

2024-05-07 Thread Abhishek Kumar
> In GTK LAF, the menu mnemonics are always displayed which is different from > the native behavior. In native application **(tested with gedit**), the menu > mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially > and then toggles between show/hide on `ALT` press. >

Re: RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2024-05-07 Thread Tejesh R
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote: > Opening closed dnd test > Test is green on all platforms test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java line 190: > 188: reset(); > 189: robot.mouseMove(p.x, p.y); > 190:

Re: RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2024-05-07 Thread Tejesh R
On Wed, 8 May 2024 05:29:49 GMT, Tejesh R wrote: >> Opening closed dnd test >> Test is green on all platforms > > test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java > line 190: > >> 188: reset(); >> 189: robot.mouseMove(p.x, p.y); >> 190:

Re: RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2024-05-07 Thread Tejesh R
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote: > Opening closed dnd test > Test is green on all platforms test/jdk/java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java line 169: > 167: > 168: public void dispose() { > 169: frame.dispose();

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF

2024-05-07 Thread Tejesh R
On Mon, 29 Apr 2024 09:00:46 GMT, Abhishek Kumar wrote: > In GTK LAF, the menu mnemonics are always displayed which is different from > the native behavior. In native application **(tested with gedit**), the menu > mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially >

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF

2024-05-07 Thread Tejesh R
On Tue, 7 May 2024 17:44:18 GMT, Abhishek Kumar wrote: > > The fix applies to single/first menu, its doesn't apply to other Menu items > > when there are more than one. Since you have taken _gedit_ as reference > > where one Menu item is present you might have followed according to it, but >

Re: RFR: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2024-05-07 Thread Sergey Bylokhov
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote: > Opening closed dnd test > Test is green on all platforms Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19128#pullrequestreview-2044249314

RFR: 8331870: open java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.java

2024-05-07 Thread Alisen Chung
Opening closed dnd test Test is green on all platforms - Commit messages: - init commit Changes: https://git.openjdk.org/jdk/pull/19128/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19128=00 Issue: https://bugs.openjdk.org/browse/JDK-8331870 Stats: 204 lines in 1 file

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF

2024-05-07 Thread Abhishek Kumar
On Tue, 7 May 2024 10:40:41 GMT, Tejesh R wrote: > The fix applies to single/first menu, its doesn't apply to other Menu items > when there are more than one. Since you have taken _gedit_ as reference where > one Menu item is present you might have followed according to it, but when > you see

Re: RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v7]

2024-05-07 Thread Philip Race
On 5/6/24 11:08 AM, Alexander Scherbatiy wrote: On Thu, 2 May 2024 18:30:23 GMT, Alexander Scherbatiy wrote: The fix adds new public `OutputBin` print attribute class which allow to set a printer output bin in a `PrinterJob` class. The corresponding internal `CustomOutputBin` class is

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2024-05-07 Thread Alexey Ivanov
On Wed, 1 May 2024 18:01:03 GMT, ScientificWare wrote: > I won a racing bib for the "Marathon Pour Tous" of Paris 2024 Olympic Games. Congratulations! Good luck! > …I have suspended all projects becauseof my training plan until september. > > My intent is to deliver the unit test in december.

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF

2024-05-07 Thread Tejesh R
On Mon, 29 Apr 2024 09:00:46 GMT, Abhishek Kumar wrote: > In GTK LAF, the menu mnemonics are always displayed which is different from > the native behavior. In native application **(tested with gedit**), the menu > mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially >