On Thu, 9 May 2024 20:49:55 GMT, Alisen Chung wrote:
> why does the get method also set the `isMnemonicHidden` flag? Shouldn't this
> only be done on the set method?
`isMnemonicHidden` is set to false to make sure if the UI defaults don't
support to hide mnemonics, then don't hide it.
On Fri, 10 May 2024 05:02:36 GMT, Harshitha Onkar wrote:
>> This doesn't work here since the Instruction rows are quite more.
>
> @TejeshR13 Rows can be increased so as to reduce scrolling.
Increased to 30 rows, guess this would be optimal size.
-
PR Review Comment:
On Thu, 9 May 2024 18:47:02 GMT, Damon Nguyen wrote:
> I've tried both the MacOS and Windows instructions. I believe it was fine.
> Still need to follow the Linux instructions unless someone else has already.
> I need to redo my Linux setup again. Then I can re-review completely.
Linux
On Thu, 2 May 2024 09:36:18 GMT, Tejesh R wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
>>
On Fri, 10 May 2024 05:06:53 GMT, Harshitha Onkar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix + Eanbled column selection mode
>
> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 182:
>
>> 180:
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFailJFrame.builder is used.
Tejesh R has updated the
On Tue, 23 Apr 2024 07:27:02 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 190:
>>
>>> 188: PassFailJFrame.builder()
>>> 189: .instructions(INSTRUCTIONS)
>>> 190: .rows(11)
>>
>> Suggestion:
>>
>>
On Thu, 2 May 2024 09:36:18 GMT, Tejesh R wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
>>
On Thu, 9 May 2024 17:47:03 GMT, Phil Race wrote:
> Or perhaps this should be pushed down to the GTK L
I tried to have this implementation in GTK L but there were some build issue
I was facing. So, moved it to Synth L but that impacts Nimbus L as well.
> This doesn't seem like an ideal way
On Tue, 6 Feb 2024 05:43:26 GMT, Abhishek Kumar wrote:
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote:
>> WIP
>>
>> This changeset contains hsdis for Windows/gcc Port. It supports both the
>> binutils and capstone backends, though the LLVM backend is left out due to
>> compatibility issues encountered during the build. Currently,
On Thu, 9 May 2024 04:54:27 GMT, Abhishek Kumar wrote:
>> I'm not aware of this. I've normally seen newlines after the test tags, and
>> I use it in my tests without any comments. Not critical either way I
>> suppose. Maybe others know more precisely? @TejeshR13 @kumarabhi006 maybe?
>
> I use
On Thu, 9 May 2024 22:42:28 GMT, Larry Cable wrote:
> can someone with write access review and push?
That's not how it works.
When the PR is marked as ready, you will issue the `/integrate` command. If you
notice in the Description, it already has sufficient reviewers. The only thing
On Wed, 10 Apr 2024 21:25:06 GMT, Larry Cable wrote:
>> the beancontext package was added (by me) in JDK 1.2 to provide
>> JavaBeans(tm) with a containment and services hierarchy.
>>
>> based upon concepts from OpenDoc, which was a popular component model at the
>> time, the API pre-dated the
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Wed, 8 May 2024 19:15:10 GMT, Alisen Chung wrote:
>> Opening closed dnd test
>> Test is green on all platforms
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> button1_down_mask, dispose on edt, replace system err with
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith
On Thu, 2 May 2024 09:33:16 GMT, Tejesh R wrote:
> @DamonGuy @alisenchung any other feedback from your end?
I've tried both the MacOS and Windows instructions. I believe it was fine.
Still need to follow the Linux instructions unless someone else has already. I
need to redo my Linux setup
On Thu, 9 May 2024 13:01:57 GMT, Alexey Ivanov wrote:
> The `javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` test
> frequently fails on Windows in CI, which creates noise.
>
> All of the failures on Windows look the same:
>
> Number of snapshots: 20
> Number of snapshots
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Mon, 6 May 2024 20:51:55 GMT, Sergey Bylokhov wrote:
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
> verify that the cmm id of the icc profile is properly reported. Before
> JDK-8321489 we always report 'lcms' as a cmm id.
Marked as reviewed by dmarkov
On Thu, 9 May 2024 13:01:57 GMT, Alexey Ivanov wrote:
> The `javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` test
> frequently fails on Windows in CI, which creates noise.
>
> All of the failures on Windows look the same:
>
> Number of snapshots: 20
> Number of snapshots
On Mon, 6 May 2024 20:51:55 GMT, Sergey Bylokhov wrote:
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
> verify that the cmm id of the icc profile is properly reported. Before
> JDK-8321489 we always report 'lcms' as a cmm id.
Marked as reviewed by prr (Reviewer).
On Thu, 9 May 2024 13:01:57 GMT, Alexey Ivanov wrote:
> The `javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` test
> frequently fails on Windows in CI, which creates noise.
>
> All of the failures on Windows look the same:
>
> Number of snapshots: 20
> Number of snapshots
The `javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` test
frequently fails on Windows in CI, which creates noise.
All of the failures on Windows look the same:
Number of snapshots: 20
Number of snapshots where number of loader threads:
= 1: 19
= 2: 0
> 2: 1
Exception in
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote:
>> WIP
>>
>> This changeset contains hsdis for Windows/gcc Port. It supports both the
>> binutils and capstone backends, though the LLVM backend is left out due to
>> compatibility issues encountered during the build. Currently,
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote:
>> WIP
>>
>> This changeset contains hsdis for Windows/gcc Port. It supports both the
>> binutils and capstone backends, though the LLVM backend is left out due to
>> compatibility issues encountered during the build. Currently,
> WIP
>
> This changeset contains hsdis for Windows/gcc Port. It supports both the
> binutils and capstone backends, though the LLVM backend is left out due to
> compatibility issues encountered during the build. Currently, which gcc
> distributions are supported is still to be clarified, as
28 matches
Mail list logo
