Re: RFR: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs

2024-05-16 Thread Abhishek Kumar
On Fri, 17 May 2024 03:37:21 GMT, Prasanta Sadhukhan wrote: > Inadvertent mention of Netscape in Javadoc is removed.. Marked as reviewed by abhiscxk (Committer). - PR Review: https://git.openjdk.org/jdk/pull/19276#pullrequestreview-2062312829

RFR: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs

2024-05-16 Thread Prasanta Sadhukhan
Inadvertent mention of Netscape in Javadoc is removed.. - Commit messages: - 8332403: Anachronistic reference to Netscape Communicator in Swing API docs - 8332403: Anachronistic reference to Netscape Communicator in Swing API docs Changes:

Integrated: 8331746: Create a test to verify that the cmm id is not ignored

2024-05-16 Thread Sergey Bylokhov
On Mon, 6 May 2024 20:51:55 GMT, Sergey Bylokhov wrote: > The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and > verify that the cmm id of the icc profile is properly reported. Before > JDK-8321489 we always report 'lcms' as a cmm id. This pull request has now been

Re: RFR: 8332416: Add more font selection options to Font2DTest [v2]

2024-05-16 Thread Phil Race
On Thu, 16 May 2024 19:16:26 GMT, Phil Race wrote: >> Enhance Font2DTest as follows >> >> - Add main menu Radio Button options so that you select the font to use as >> either >> - (1) Font Family + Style (as now) >> - (2) Font Family + Menu of all members of the Family, replacing the Style >>

Re: RFR: 8332416: Add more font selection options to Font2DTest [v2]

2024-05-16 Thread Phil Race
> Enhance Font2DTest as follows > > - Add main menu Radio Button options so that you select the font to use as > either > - (1) Font Family + Style (as now) > - (2) Font Family + Menu of all members of the Family, replacing the Style > - (3) List of all fontnames - which can still be adjusted

RFR: 8332416: Add more font selection options to Font2DTest

2024-05-16 Thread Phil Race
Enhance Font2DTest as follows - Add main menu Radio Button options so that you select the font to use as either - (1) Font Family + Style (as now) - (2) Font Family + Menu of all members of the Family, replacing the Style - (3) List of all fontnames - which can still be adjusted by Style if you

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v7]

2024-05-16 Thread Alan Bateman
On Thu, 16 May 2024 12:23:44 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8331746: Create a test to verify that the cmm id is not ignored [v3]

2024-05-16 Thread Dmitry Markov
On Thu, 16 May 2024 04:27:25 GMT, Sergey Bylokhov wrote: >> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and >> verify that the cmm id of the icc profile is properly reported. Before >> JDK-8321489 we always report 'lcms' as a cmm id. > > Sergey Bylokhov has updated

Re: RFR: 8329667: [macos] Issue with JTree related fix for JDK-8317771

2024-05-16 Thread Victor Dyakov
On Thu, 16 May 2024 01:28:37 GMT, Alexander Zuev wrote: > Caching children and selected children of the thee on the native level; > Caching all children of a specific parent in CAccessibility to enhance > recursive children selection algorithm; > Removing fix for JDK-8317771 as no longer

Integrated: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2024-05-16 Thread Alisen Chung
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote: > Opening closed dnd test > Test is green on all platforms This pull request has now been integrated. Changeset: 6f7ddbec Author:Alisen Chung URL: https://git.openjdk.org/jdk/commit/6f7ddbec7d0bc459d44b6518fe1d982eaba7f37b Stats:

Re: RFR: 8331746: Create a test to verify that the cmm id is not ignored [v3]

2024-05-16 Thread Alexey Ivanov
On Thu, 16 May 2024 04:27:25 GMT, Sergey Bylokhov wrote: >> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and >> verify that the cmm id of the icc profile is properly reported. Before >> JDK-8321489 we always report 'lcms' as a cmm id. > > Sergey Bylokhov has updated

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v7]

2024-05-16 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native`

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Maurizio Cimadamore
On Thu, 16 May 2024 11:55:35 GMT, Jaikiran Pai wrote: >> We already do, see >> https://github.com/openjdk/jdk/pull/19213/files/1c45e5d56c429205ab8185481bc1044a86ab3bc6#diff-d05029afe6aed86f860a10901114402f1f6af4fe1e4b46d883141ab1d2a527b8R582 > > This is slightly different from what we do in the

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Jaikiran Pai
On Thu, 16 May 2024 11:47:13 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/sun/launcher/resources/launcher.properties line >> 72: >> >>> 70: \ by code in modules for which native access is not >>> explicitly enabled.\n\ >>> 71: \ is one of

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Maurizio Cimadamore
On Thu, 16 May 2024 11:42:48 GMT, Jaikiran Pai wrote: > Hello Maurizio, in the current mainline, we have code in `LauncherHelper` > https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/launcher/LauncherHelper.java#L636 > where we enable native access to all unnamed

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Jaikiran Pai
On Wed, 15 May 2024 16:08:17 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-16 Thread Jaikiran Pai
On Wed, 15 May 2024 16:08:17 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L [v5]

2024-05-16 Thread Abhishek Kumar
On Tue, 26 Mar 2024 08:22:52 GMT, Prasanta Sadhukhan wrote: >> @aivanov-jdk >> >>> This looks weird… So you're saying Label[Enabled].textForeground and >>> Label[Disabled].textForeground are used for Nimbus (and Synth and GTK) >>> instead of Label.foreground and Label.disabledForeground

Re: RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L [v6]

2024-05-16 Thread Abhishek Kumar
> JLabel text is not painted with the LAF defined foreground color in GTK LAF. > In GTK LAF the foreground color is retrieved by using native system APIs. Fix > is to return the foreground color if it is set by LAF defined property > otherwise return the default color by calling native APIs. >

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis [v2]

2024-05-16 Thread Julian Waters
On Wed, 15 May 2024 13:32:38 GMT, Magnus Ihse Bursie wrote: > Hi Julian, sorry for not getting back to you. > > The problem from my PoV is that this is a very large and intrusive patch in > the build of the actual product, for a claimed problem in the tangential > hsdis library. I have not