Integrated: 8311110: multichar warning in WinAccessBridge.cpp

2024-06-12 Thread Abhishek Kumar
On Wed, 12 Jun 2024 04:58:47 GMT, Abhishek Kumar wrote: > Looks like there was a typo for null character. It should be `'\0'` instead > of `'/0'`. > Build with clang toolchain with the help of [this > PR](https://github.com/openjdk/jdk/pull/17019) and after the changes there is > no warning.

Re: RFR: 8291472: [macos] jawt 1.4 lock/unlock not supported

2024-06-12 Thread Phil Race
On Tue, 11 Jun 2024 02:37:44 GMT, Sergey Bylokhov wrote: >> Removing if check for unsupported jawt versions > > Is it possible to cover this fix by the test? @mrserb can you look at this one. - PR Comment: https://git.openjdk.org/jdk/pull/19639#issuecomment-2164063828

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]

2024-06-12 Thread Damon Nguyen
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]

2024-06-12 Thread Damon Nguyen
On Mon, 10 Jun 2024 23:11:04 GMT, Jonathan Gibbons wrote: >> @jonathan-gibbons I just realized that this change to the German file >> matches the file with the Japanese and Chinese localized files. By that I >> mean the "backwards" translations are also present for the Japanese and >> Chinese

Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v2]

2024-06-12 Thread Sergey Bylokhov
On Wed, 12 Jun 2024 11:52:47 GMT, Alexey Ivanov wrote: > How do we remove this constructor? Can it be removed right away? Should it be > deprecated for several releases before it's removed? Just delete it in all versions of 17+? - PR Comment:

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-12 Thread Justin Lu
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8332099: since-checker - Add @ since to package-info in jdk.jsobject

2024-06-12 Thread Phil Race
On Sun, 12 May 2024 00:37:26 GMT, Nizar Benalla wrote: > Simple code cleanup. > If you're reviewing this, thanks. Marked as reviewed by prr (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19197#pullrequestreview-2114066829

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-12 Thread Phil Race
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333801: Typos in @code references of BufferedImage and JTableHeader [v2]

2024-06-12 Thread Phil Race
On Wed, 12 Jun 2024 04:05:32 GMT, Jayathirth D V wrote: >> Resolved typos related to ArrayIndexOutOfBoundsException in BufferedImage >> and JTableHeader. > > Jayathirth D V has updated the pull request incrementally with one additional > commit since the last revision: > > Update Marked as

Re: RFR: 8311110: multichar warning in WinAccessBridge.cpp

2024-06-12 Thread Phil Race
On Wed, 12 Jun 2024 04:58:47 GMT, Abhishek Kumar wrote: > Looks like there was a typo for null character. It should be `'\0'` instead > of `'/0'`. > Build with clang toolchain with the help of [this > PR](https://github.com/openjdk/jdk/pull/17019) and after the changes there is > no warning.

Re: RFR: 8334032: javax.print: Missing @since tag in new class OutputBin

2024-06-12 Thread Phil Race
On Tue, 11 Jun 2024 16:57:35 GMT, Marc R. Hoffmann wrote: > 8334032: javax.print: Missing @since tag in new class OutputBin Marked as reviewed by prr (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19662#pullrequestreview-2114021594

Integrated: 8315655: [macos] Right click and dragging over a component with a popup menu will open the popup

2024-06-12 Thread Alisen Chung
On Wed, 5 Jun 2024 23:33:21 GMT, Alisen Chung wrote: > Issue is a mouse drag will trigger a popup in macos, but not in linux or > windows. > The solution is to add a check for a mouse pressed event to show popup and > prevent mouse entered events from triggering the popup This pull request

Re: RFR: 8291472: [macos] jawt 1.4 lock/unlock not supported

2024-06-12 Thread Alisen Chung
On Tue, 11 Jun 2024 02:37:44 GMT, Sergey Bylokhov wrote: > Is it possible to cover this fix by the test? How would I go about writing a test? - PR Comment: https://git.openjdk.org/jdk/pull/19639#issuecomment-2163687022

Re: RFR: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero

2024-06-12 Thread Phil Race
On Wed, 12 Jun 2024 08:02:00 GMT, Matthias Baesken wrote: > When running the jdk jtreg tests with ubsan enabled binaries on Linux x86_64, > I get the warning below. > This shows up in a couple of tests, for example > java/awt/image/mlib/MlibOpsTest.jtr >

Re: RFR: 8334123: log the opening of Type 1 fonts

2024-06-12 Thread Phil Race
On Wed, 12 Jun 2024 12:16:38 GMT, Matthias Baesken wrote: > When font logging is enabled (e.g. by setting -Dsun.java2d.debugfonts=true ), > currently the open operations for ttf fonts are logged, but not for Type1 > fonts. > The logging would be more clear and consistent with added logging for

RFR: 8334123: log the opening of Type 1 fonts

2024-06-12 Thread Matthias Baesken
When font logging is enabled (e.g. by setting -Dsun.java2d.debugfonts=true ), currently the open operations for ttf fonts are logged, but not for Type1 fonts. The logging would be more clear and consistent with added logging for Type 1 fonts. - Commit messages: - JDK-8334123

Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v2]

2024-06-12 Thread Alexey Ivanov
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote: >> If you're currently reviewing this PR, thank you! >> Most fixes here are according to the reports by the since checker tool in >> #18934 and are pretty simple. >> >> To make reviewing easier >> - `BasicSliderUI` has the constructor

Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v2]

2024-06-12 Thread Alexey Ivanov
On Tue, 11 Jun 2024 19:17:43 GMT, Jonathan Gibbons wrote: >> src/java.desktop/share/classes/java/awt/geom/Path2D.java line 297: >> >>> 295: /** >>> 296: * @since 10 >>> 297: */ >> >> Not sure it's required… >> >> If it is, you should also add explicit

Re: RFR: 8311110: multichar warning in WinAccessBridge.cpp

2024-06-12 Thread Julian Waters
On Wed, 12 Jun 2024 04:58:47 GMT, Abhishek Kumar wrote: > Looks like there was a typo for null character. It should be `'\0'` instead > of `'/0'`. > Build with clang toolchain with the help of [this > PR](https://github.com/openjdk/jdk/pull/17019) and after the changes there is > no warning.

RFR: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero

2024-06-12 Thread Matthias Baesken
When running the jdk jtreg tests with ubsan enabled binaries on Linux x86_64, I get the warning below. This shows up in a couple of tests, for example java/awt/image/mlib/MlibOpsTest.jtr java/awt/image/Raster/TestChildRasterOp.jtr

Re: RFR: 8311110: multichar warning in WinAccessBridge.cpp

2024-06-12 Thread Daniel Jeliński
On Wed, 12 Jun 2024 04:58:47 GMT, Abhishek Kumar wrote: > Looks like there was a typo for null character. It should be `'\0'` instead > of `'/0'`. > Build with clang toolchain with the help of [this > PR](https://github.com/openjdk/jdk/pull/17019) and after the changes there is > no warning.