Re: RFR: 8332854: Unable to build openjdk with --with-harfbuzz=system

On Sun, 16 Jun 2024 21:31:50 GMT, Phil Race wrote: > Verified on Ubuntu 24.04 I checked build code and looks like by default bundled harfbuzz library is used. With --with-harfbuzz=system, we use system provided harfbuzz lib. Change looks good to me. - Marked as reviewed by jdv (Re

RFR: 8297191 : [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

Hi Reviewers, This fix will resolve page range not printing proper pages if the rage begin from 2 or above on Mac machines. I have verified the manual range related tests like PageRanges.java, ClippedImages.java and test.java and confirmed its fixing the issue. Please review and let me know yo

Re: RFR: 8332854: Unable to build openjdk with --with-harfbuzz=system

On Sun, 16 Jun 2024 21:31:50 GMT, Phil Race wrote: > Verified on Ubuntu 24.04 Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19739#pullrequestreview-2121932893

Re: RFR: 8332854: Unable to build openjdk with --with-harfbuzz=system

On Sun, 16 Jun 2024 21:31:50 GMT, Phil Race wrote: > Verified on Ubuntu 24.04 Marked as reviewed by jwaters (Committer). - PR Review: https://git.openjdk.org/jdk/pull/19739#pullrequestreview-2121903051

Re: RFR: 5021949: JSplitPane setEnabled(false) shouldn't be partially functional [v3]

On Fri, 14 Jun 2024 20:39:25 GMT, Alisen Chung wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Omit gtk > > src/java.desktop/share/classes/javax/swing/JSplitPane.java line 372: > >> 370: public void setE

Re: RFR: 8291472: [macos] jawt 1.4 lock/unlock not supported

On Mon, 10 Jun 2024 21:09:35 GMT, Alisen Chung wrote: > Removing if check for unsupported jawt versions Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19639#pullrequestreview-2121875806

Re: RFR: 8291472: [macos] jawt 1.4 lock/unlock not supported

On Tue, 11 Jun 2024 02:37:44 GMT, Sergey Bylokhov wrote: >> Removing if check for unsupported jawt versions > > Is it possible to cover this fix by the test? > @mrserb can you look at this one. The change looks fine. I remember we had a task to test jawt functionality, but seems we still do no

RFR: 8332854: Unable to build openjdk with --with-harfbuzz=system

Verified on Ubuntu 24.04 - Commit messages: - 8332854 Changes: https://git.openjdk.org/jdk/pull/19739/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19739&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332854 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod