On Tue, 25 Jun 2024 03:41:05 GMT, Prasanta Sadhukhan
wrote:
> 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
This pull request has now been integrated.
Changeset: ae491829
Author:Prasanta Sadhukhan
URL:
On Tue, 25 Jun 2024 09:22:45 GMT, Per Minborg wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8334495
>
> src/java.desktop/share/classes/sun/font/StrikeCache.java line 112:
>
>> 110: * references a memory
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote:
>> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
>> This reduces the coupling between the java.desktop module and the internals
>> of the java.base module.
>>
>> The code being changed here is not particularly performance
On Fri, 21 Jun 2024 07:55:24 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Tue, 25 Jun 2024 15:18:29 GMT, Alexey Ivanov wrote:
>>> In my initial fix, I added the `altProcessor` handler in
>>> `SynthLookAndFeel.initialize` with condition check for GTK L Phil has
>>> suggested not to check for GTK L instead look for some alternate way like
>>> mentioned
>>>
On Tue, 25 Jun 2024 14:58:53 GMT, Alexey Ivanov wrote:
>>> If RootPane.altPress can be changed dynamically, you can install a
>>> PropertyChangeListener to UIManager.
>>
>> I think it can be changed but is it really required to handle it ?
>> I mean why does a user change it dynamically ?
>
>>
On Mon, 24 Jun 2024 07:20:24 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
>> line 751:
>>
>>> 749: * Repaints all the components with the mnemonics in the given
>>> window and all its owned windows.
>>> 750: */
>>> 751:
On Mon, 24 Jun 2024 07:21:49 GMT, Abhishek Kumar wrote:
>>>Requesting the value of RootPane.altPress from UIManager each time
>>>postProcessKeyEvent is called is inefficient, so you can store the value in
>>>altProcessor when look and feel is installed.
>>
>> I guess you are pointing out the
On Mon, 24 Jun 2024 07:19:49 GMT, Abhishek Kumar wrote:
> Should I revert it back to javadoc style comment ?
Absolutely!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1652814116
On Tue, 25 Jun 2024 03:41:05 GMT, Prasanta Sadhukhan
wrote:
> 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19874#pullrequestreview-2138314011
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote:
>> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
>> This reduces the coupling between the java.desktop module and the internals
>> of the java.base module.
>>
>> The code being changed here is not particularly performance
11 matches
Mail list logo
