Re: [jdk23] RFR: Merge d876cacf73ad698eda6668ccebbdfbe7690a0b06 [v2]

2024-07-16 Thread Jaikiran Pai
> This brings the CPU24_07 changes into jdk23 branch. Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. - Changes: - all: https://git.openjdk.org/jdk/p

Integrated: Merge 13341ca70276c891add2e4652b6e1e8020610988

2024-07-16 Thread Jaikiran Pai
On Wed, 17 Jul 2024 05:33:15 GMT, Jaikiran Pai wrote: > This brings in CPU24_07 changes into master branch This pull request has now been integrated. Changeset: d90c20c0 Author:Jaikiran Pai URL: https://git.openjdk.org/jdk/commit/d90c20c0c728ced94493e0e58956153f6f61f898 Stats: 1

[jdk23] Integrated: Merge d876cacf73ad698eda6668ccebbdfbe7690a0b06

2024-07-16 Thread Jaikiran Pai
On Wed, 17 Jul 2024 05:33:54 GMT, Jaikiran Pai wrote: > This brings the CPU24_07 changes into jdk23 branch. This pull request has now been integrated. Changeset: 7afb958e Author:Jaikiran Pai URL: https://git.openjdk.org/jdk/commit/7afb958e8d30221456a7b4634de0200dfe074950 Stats:

Re: RFR: Merge 13341ca70276c891add2e4652b6e1e8020610988

2024-07-16 Thread Jaikiran Pai
On Wed, 17 Jul 2024 05:33:15 GMT, Jaikiran Pai wrote: > This brings in CPU24_07 changes into master branch Thank you David and Daniel for the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/20211#issuecomment-2232494499

Re: RFR: Merge 13341ca70276c891add2e4652b6e1e8020610988 [v2]

2024-07-16 Thread Jaikiran Pai
> This brings in CPU24_07 changes into master branch Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. - Changes: - all: https://git.openjdk.org/jdk/pu

Re: [jdk23] RFR: Merge d876cacf73ad698eda6668ccebbdfbe7690a0b06

2024-07-16 Thread David Holmes
On Wed, 17 Jul 2024 05:33:54 GMT, Jaikiran Pai wrote: > This brings the CPU24_07 changes into jdk23 branch. Hotspot looks good. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20212#pullrequestreview-2181941981

Re: RFR: Merge 13341ca70276c891add2e4652b6e1e8020610988

2024-07-16 Thread David Holmes
On Wed, 17 Jul 2024 05:33:15 GMT, Jaikiran Pai wrote: > This brings in CPU24_07 changes into master branch Hotspot looks good. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20211#pullrequestreview-2181940719

Re: [jdk23] RFR: Merge d876cacf73ad698eda6668ccebbdfbe7690a0b06

2024-07-16 Thread Daniel Jeliński
On Wed, 17 Jul 2024 05:33:54 GMT, Jaikiran Pai wrote: > This brings the CPU24_07 changes into jdk23 branch. Marked as reviewed by djelinski (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20212#pullrequestreview-2181924794

Re: RFR: Merge 13341ca70276c891add2e4652b6e1e8020610988

2024-07-16 Thread Daniel Jeliński
On Wed, 17 Jul 2024 05:33:15 GMT, Jaikiran Pai wrote: > This brings in CPU24_07 changes into master branch Marked as reviewed by djelinski (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20211#pullrequestreview-2181924404

RFR: Merge 13341ca70276c891add2e4652b6e1e8020610988

2024-07-16 Thread Jaikiran Pai
This brings in CPU24_07 changes into master branch - Commit messages: - 8323390: Enhance mask blit functionality - 8320097: Improve Image transformations - 8327413: Enhance compilation efficiency - 8324559: Improve 2D image handling - 8325600: Better symbol storage - 8319859: Be

[jdk23] RFR: Merge d876cacf73ad698eda6668ccebbdfbe7690a0b06

2024-07-16 Thread Jaikiran Pai
This brings the CPU24_07 changes into jdk23 branch. - Commit messages: - 8323390: Enhance mask blit functionality - 8320097: Improve Image transformations - 8327413: Enhance compilation efficiency - 8324559: Improve 2D image handling - 8325600: Better symbol storage - 8319859: B

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-07-16 Thread David Holmes
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

client-libs-dev@openjdk.org

2024-07-16 Thread Abhishek Kumar
On Tue, 16 Jul 2024 19:49:39 GMT, Damon Nguyen wrote: > Are there no repercussions to setting this boolean to `TRUE` across the board > for one test to pass? I guess my question is, why was it explicitly set to FALSE before and now we set it to TRUE? Why was it set to `FALSE` before is unclea

Integrated: JDK-8336413 : gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf

2024-07-16 Thread Harshitha Onkar
On Mon, 15 Jul 2024 23:29:25 GMT, Harshitha Onkar wrote: > Typedef re-declaration warnings were seen on Solaris in 11u but this seems to > be an issue in all releases including mainline, but only the Solaris compiler > warns. > > Two typedef declarations are causing this issue - `GMainContex

client-libs-dev@openjdk.org

2024-07-16 Thread Damon Nguyen
On Wed, 10 Jul 2024 05:56:17 GMT, Abhishek Kumar wrote: > This test was modified under > [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the > applet usage. Test modification includes the instruction change as well which > says that `Check that there is a panel with "T

Re: RFR: 8335130: The test "javax/swing/plaf/synth/ComponentsOrientationSupport/5033822/bug5033822.java" fails because the background color of the tabs is displayed incorrectly.

2024-07-16 Thread Damon Nguyen
On Tue, 9 Jul 2024 06:13:15 GMT, Abhishek Kumar wrote: > Issue is due to the condition added for the opaque property of > SynthTabbedPane in > [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990). The previous fix > for GTK and Nimbus was handled commonly in `SynthTabbedPaneUI` class to

Re: RFR: JDK-8336413 : gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf

2024-07-16 Thread Damon Nguyen
On Mon, 15 Jul 2024 23:29:25 GMT, Harshitha Onkar wrote: > Typedef re-declaration warnings were seen on Solaris in 11u but this seems to > be an issue in all releases including mainline, but only the Solaris compiler > warns. > > Two typedef declarations are causing this issue - `GMainContex

Re: Feedback request: Add new RenderingHints.KEY_FONT_HINTING

2024-07-16 Thread Philip Race
On 7/15/24 5:11 PM, Daniel Gredler wrote: Hi Phil, Thank you for the response and the insights! I have to admit I don't know much about the situation in macOS, but I assume they're moving things in a direction that works best for their particular situation (complete control over both the so

Re: RFR: JDK-8336413 : gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf

2024-07-16 Thread Phil Race
On Mon, 15 Jul 2024 23:29:25 GMT, Harshitha Onkar wrote: > Typedef re-declaration warnings were seen on Solaris in 11u but this seems to > be an issue in all releases including mainline, but only the Solaris compiler > warns. > > Two typedef declarations are causing this issue - `GMainContex

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-07-16 Thread Daniel Jeliński
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v2]

2024-07-16 Thread Kim Barrett
On Tue, 16 Jul 2024 08:52:01 GMT, Julian Waters wrote: >> src/jdk.jdwp.agent/windows/native/libjdwp/util_md.h line 32: >> >>> 30: #include /* for _MAx_PATH */ >>> 31: >>> 32: typedef unsigned long long UNSIGNED_JLONG; >> >> This change has nothing to do with _sprintf. Not sure why it's

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-07-16 Thread Kim Barrett
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-07-16 Thread Julian Waters
> snprintf has been available for all officially and unofficially supported > compilers for Windows, Visual Studio since version 2015 and gcc since, well, > forever. snprintf is conforming to C99 since the start when compiling using > gcc, and 2015 when using Visual Studio. Since it conforms to

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v2]

2024-07-16 Thread Julian Waters
On Mon, 15 Jul 2024 16:30:02 GMT, Kim Barrett wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> USe os::snprintf in HotSpot > > src/jdk.jdwp.agent/windows/native/libjdwp/util_md.h line 32: > >> 30: #include /