On Tue, 3 Sep 2024 06:16:06 GMT, David Holmes wrote:
>>> Also doesn't a call like this trigger the warning about ignoring a function
>>> result, or have we disabled that one?
>>
>> Such a warning would be horrible to have enable. Then you would have to read
>> the value of every function that
On Tue, 3 Sep 2024 05:52:31 GMT, Magnus Ihse Bursie wrote:
>> This code is devoid of pretty much all error handling and logging, but I
>> agree that a simple fprintf on error would be useful.
>> Also doesn't a call like this trigger the warning about ignoring a function
>> result, or have we di
On Tue, 3 Sep 2024 05:50:43 GMT, Abhishek Kumar wrote:
> @prsadhuk As we were discussing about the test change and removal of
> SecondaryLoop change, I tested the current changes without the fix proposed
> in [JDK-8007563](https://bugs.openjdk.org/browse/JDK-8007563) and test failed
> which is
On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar wrote:
>> Test was failing on multiple platforms mainly windows and linux and was
>> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
>> fetch the correct background color using robot. Now test passed for multiple
>> i
> Test was failing on multiple platforms mainly windows and linux and was
> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
> fetch the correct background color using robot. Now test passed for multiple
> iteration (~50 times) in CI pipeline for all platforms. Wild i
On Sat, 31 Aug 2024 00:48:12 GMT, Harshitha Onkar wrote:
> I'm not sure if the SecondaryLoop code is required for this test or it can be
> simplified?
I have tried simplifying the test code and removed SecondaryLoop code. Tested
the current changes in CI across all platforms and no failure obs
On Tue, 3 Sep 2024 02:25:16 GMT, David Holmes wrote:
> Also doesn't a call like this trigger the warning about ignoring a function
> result, or have we disabled that one?
Such a warning would be horrible to have enable. Then you would have to read
the value of every function that thought it sh
On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar wrote:
>> Test was failing on multiple platforms mainly windows and linux and was
>> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
>> fetch the correct background color using robot. Now test passed for multiple
>> i
On Mon, 2 Sep 2024 22:32:34 GMT, Magnus Ihse Bursie wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust indentation in X11Color.c
>
> src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c line 744:
On Fri, 30 Aug 2024 07:23:54 GMT, Prasanta Sadhukhan
wrote:
>> The testcase calls Platform.exit before the dialog is made visible but
>> on macOS, JavaFX takes over the AppKit thread and uses that as the FX
>> application thread. As part of the FX platform shutdown process, it detaches
>> that
On Mon, 2 Sep 2024 20:06:06 GMT, Martin Doerr wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust indentation in X11Color.c
>
> src/java.desktop/unix/native/common/awt/X11Color.c line 1234:
>
>> 1232: awt_a
On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken wrote:
>> We get a couple of warnings as errors on AIX because of unused variables or
>> functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken wrote:
>> We get a couple of warnings as errors on AIX because of unused variables or
>> functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
I moved SurfaceDataProxy cache into a separate class.
Now caching level is determined by placement of the SurfaceManager.ProxyCache
object instead of a "proxy key". This cache "owns" proxies and therefore strong
refs via them do not prevent the cache and GraphicsConfig from being detected
as wea
On Mon, 2 Sep 2024 12:17:57 GMT, Christoph Langer wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust indentation in X11Color.c
>
> src/java.desktop/unix/native/common/awt/X11Color.c line 1236:
>
>> 1234:
On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken wrote:
> We get a couple of warnings as errors on AIX because of unused variables or
> functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:66
> We get a couple of warnings as errors on AIX because of unused variables or
> functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10:
> error: unused variable 'exePath' [-Werror,-Wunused
On Mon, 2 Sep 2024 12:30:43 GMT, Julian Waters wrote:
> Ah, the joys of supporting a platform that isn't covered by the Actions
> compile and test safety net :)
A Linux/clang build in the GHA would have probably shown at least a part of
those errors.
-
PR Comment: https://git.ope
On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken wrote:
> We get a couple of warnings as errors on AIX because of unused variables or
> functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:66
On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken wrote:
> We get a couple of warnings as errors on AIX because of unused variables or
> functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:66
On Thu, 29 Aug 2024 04:38:29 GMT, Tejesh R wrote:
> On analysis of captured image, it is observed that there are few pixels which
> vary slightly w.r.t to expected color. Hence tolerance is included in color
> comparison.
> Tested in mach5 multiple time and its green.
> JBS - [JDK-8187759](ht
We get a couple of warnings as errors on AIX because of unused variables or
functions , for example :
/priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10:
error: unused variable 'exePath' [-Werror,-Wunused-variabl
On Mon, 2 Sep 2024 05:03:25 GMT, Jayathirth D V wrote:
>>> Why are we extending this test to be run on Mac now? Looks like it was
>>> Linux specific test.
>>>
>>> Also Title "Comparing buffered images of white background frame fails in
>>> Mac" makes it looks like some product issue. But chang
On Wed, 21 Aug 2024 21:53:39 GMT, Magnus Ihse Bursie wrote:
> As a preparation for Hermetic Java, we need to have a way to look up during
> runtime if we are using a statically linked library or not.
>
> This change will be the first step needed towards compiling the object files
> only once,
On Fri, 30 Aug 2024 04:57:56 GMT, Abhishek Kumar wrote:
>> `static final Map ICONS_MAP` is modified only in
>> `static` block. Then
>> [com.sun.java.swing.plaf.gtk.GTKStyle#get](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/com/
25 matches
Mail list logo
