On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar wrote:
>> Test was failing on multiple platforms mainly windows and linux and was
>> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
>> fetch the correct background color using robot. Now test passed for multiple
>> i
On Wed, 4 Sep 2024 05:54:20 GMT, Abhishek Kumar wrote:
> > > > Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still
> > > > valid?
> > >
> > >
> > > Yes, issue still exists for mac machine.
> >
> >
> > Issue is for AquaL&F which as per your verification in
> > [JDK-8331619](h
> Test failed intermittently on particular host. Though analysis pointed out to
> a test frame at left top on that host, I've updated the test for further
> stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for colo
On Wed, 4 Sep 2024 05:36:00 GMT, Abhishek Kumar wrote:
> > Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?
>
> Yes, issue still exists for mac machine.
Issue is for AquaL&F which as per your verification in
[JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619) a
On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar wrote:
>> Test was failing on multiple platforms mainly windows and linux and was
>> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
>> fetch the correct background color using robot. Now test passed for multiple
>> i
On Wed, 4 Sep 2024 05:30:48 GMT, Abhishek Kumar wrote:
> Is [JDK-7148101](https://bugs.openjdk.org/browse/JDK-7148101) still valid?
Yes, issue still exists for mac machine.
-
PR Comment: https://git.openjdk.org/jdk/pull/20791#issuecomment-2327960292
On Wed, 4 Sep 2024 05:02:24 GMT, Prasanta Sadhukhan
wrote:
> Seems like closed test 4690946 where the UI property
> "TabbedPane.tabAreaBackground" was added in webrev.0 is moved to open and
> renamed as javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java..Any idea
> why the test is only f
On Fri, 23 Aug 2024 09:17:43 GMT, Prasanta Sadhukhan
wrote:
> The testcase calls Platform.exit before the dialog is made visible but
> on macOS, JavaFX takes over the AppKit thread and uses that as the FX
> application thread. As part of the FX platform shutdown process, it detaches
> that thr
On Wed, 4 Sep 2024 04:21:00 GMT, Abhishek Kumar wrote:
>> Test was failing on multiple platforms mainly windows and linux and was
>> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
>> fetch the correct background color using robot. Now test passed for multiple
>> i
On Mon, 5 Aug 2024 04:46:47 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component ev
On Wed, 4 Sep 2024 00:04:19 GMT, Harshitha Onkar wrote:
> break check;
Yeah starting with `checkmarkFound = true` might not be right condition to
start with. I selected these specific pixels index pattern based on checkmarker
considering color gradient. Pixel counter would also be fine I guess
On Wed, 28 Aug 2024 08:54:39 GMT, Abhishek Kumar wrote:
> `static final Map ICONS_MAP` is modified only in
> `static` block. Then
> [com.sun.java.swing.plaf.gtk.GTKStyle#get](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/com/sun
On Wed, 4 Sep 2024 01:10:16 GMT, Damon Nguyen wrote:
> Worth noting, I think it'd be good to rename the test since we're removing it
> from the problemlist and moving the test to a new location anyway. Maybe
> rename it to `JTabbedPaneBackgroundColorTest` or something similar to be more
> desc
> Test was failing on multiple platforms mainly windows and linux and was
> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
> fetch the correct background color using robot. Now test passed for multiple
> iteration (~50 times) in CI pipeline for all platforms. Wild i
On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar wrote:
>> Test was failing on multiple platforms mainly windows and linux and was
>> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
>> fetch the correct background color using robot. Now test passed for multiple
>> i
In a JComboBox, if the user opens the dropdown list and clicks and holds the
down-button, then ALT-TABs to switch focus, when the user re-focuses the frame
with the JComboBox and opens the dropdown list again, the list will still be
scrolling even though the down-button isn't pressed.
This isn'
On Tue, 3 Sep 2024 09:20:36 GMT, Tejesh R wrote:
>> Test failed intermittently on particular host. Though analysis pointed out
>> to a test frame at left top on that host, I've updated the test for further
>> stabilizing it. Two things done here:
>> 1. Move the frame to center of the screen rat
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically,
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically,
On Tue, 3 Sep 2024 18:10:06 GMT, Erik Joelsson wrote:
> I'm guessing this would work if I built the regular image first, or at least
> at the same time.
No, I don't think that should matter. `static-jdk-image` depends on
`exploded-image`, and the files in your error message resides in `jdk`, n
On Tue, 3 Sep 2024 18:17:33 GMT, Manukumar V S wrote:
>> This is a highly intermittent failure, and it failed only once in CI on a
>> particular windows machine and passed on all other runs.
>>
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn
>
On Tue, 3 Sep 2024 18:17:33 GMT, Manukumar V S wrote:
>> This is a highly intermittent failure, and it failed only once in CI on a
>> particular windows machine and passed on all other runs.
>>
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn
>
On Tue, 3 Sep 2024 18:13:13 GMT, Harshitha Onkar wrote:
> LGTM now. Does CI testing look good with the updated changes?
Yes, I have attached the results in the bug comment.
-
PR Comment: https://git.openjdk.org/jdk/pull/20777#issuecomment-2327139798
On Tue, 3 Sep 2024 18:02:33 GMT, Harshitha Onkar wrote:
> > Individual robot.delay() can be added after UI creation and when frame
> > state is changed to stabilize the test.
>
> You are still missing some delays. Please check the diff lines in the
> following code snippet.
>
> ```
> @@ -124,
On Tue, 3 Sep 2024 18:14:44 GMT, Manukumar V S wrote:
>> This is a highly intermittent failure, and it failed only once in CI on a
>> particular windows machine and passed on all other runs.
>>
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn
>
> This is a highly intermittent failure, and it failed only once in CI on a
> particular windows machine and passed on all other runs.
>
> Failure reason:
> When the button was displayed for the first time, the focus rectangle drawn
> on the button text(Button A) was not seen(failure images att
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically,
On Sat, 31 Aug 2024 09:09:22 GMT, Manukumar V S wrote:
> Individual robot.delay() can be added after UI creation and when frame state
> is changed to stabilize the test.
You are still missing some delays.
@@ -124,16 +125,15 @@ public void runTest() throws Exception {
try {
On Tue, 3 Sep 2024 16:41:26 GMT, Harshitha Onkar wrote:
> ```
> frame.setExtendedState(JFrame.MAXIMIZED_BOTH);
> System.out.println("Frame is maximized");
> robot.waitForIdle();
> ```
>
> You missed adding delays after frame state changes, in the a
> This is a highly intermittent failure, and it failed only once in CI on a
> particular windows machine and passed on all other runs.
>
> Failure reason:
> When the button was displayed for the first time, the focus rectangle drawn
> on the button text(Button A) was not seen(failure images att
On Thu, 1 Aug 2024 21:51:04 GMT, Daniel Gredler wrote:
>> At some point the `JPEGImageWriter` was optimized to reduce duplication /
>> copying of rasters and data buffers (see `JDK-6266748`). However,
>> `PNGImageWriter` never received a similar optimization, and is making
>> unnecessary copie
On Sat, 31 Aug 2024 09:08:59 GMT, Manukumar V S wrote:
>> This is a highly intermittent failure, and it failed only once in CI on a
>> particular windows machine and passed on all other runs.
>>
>> Failure reason:
>> When the button was displayed for the first time, the focus rectangle drawn
On Tue, 3 Sep 2024 10:37:20 GMT, Abhishek Kumar wrote:
> > I am not sure why secondary loop was added in the testcase for JDK-8078269..
>
> That is unclear to me as well.
>
> > JDK-8078269 issue was `TabbedPane.tabAreaBackground` should have precedence
> > over `setBackground` but it was not w
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically,
As a prerequisite for Hermetic Java, we need a statically linked `java`
launcher. It should behave like the normal, dynamically linked `java` launcher,
except that all JDK native libraries should be statically, not dynamically,
linked.
This patch is the first step towards this goal. It will gen
On Tue, 3 Sep 2024 07:26:53 GMT, Matthias Baesken wrote:
>> We get a couple of warnings as errors on AIX because of unused variables or
>> functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
On Mon, 2 Sep 2024 11:43:20 GMT, Matthias Baesken wrote:
> We get a couple of warnings as errors on AIX because of unused variables or
> functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:66
On Tue, 3 Sep 2024 08:42:03 GMT, Prasanta Sadhukhan
wrote:
> I am not sure why secondary loop was added in the testcase for JDK-8078269..
That is unclear to me as well.
> JDK-8078269 issue was `TabbedPane.tabAreaBackground` should have precedence
> over `setBackground` but it was not workin
On Fri, 30 Aug 2024 07:20:47 GMT, Tejesh R wrote:
> > > Have you checked what is the root cause? Are the pixels drawn incorrectly
> > > in the frame, or is the robot distorting the colors when it grabs the
> > > pixels?
> >
> >
> > The issue occurs intermittently/might be even host specific.
On Tue, 3 Sep 2024 07:26:53 GMT, Matthias Baesken wrote:
>> We get a couple of warnings as errors on AIX because of unused variables or
>> functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
> Test failed intermittently on particular host. Though analysis pointed out to
> a test frame at left top on that host, I've updated the test for further
> stabilizing it. Two things done here:
> 1. Move the frame to center of the screen rather than left top.
> 2. Added tolerance checks for colo
On Tue, 3 Sep 2024 05:50:00 GMT, Abhishek Kumar wrote:
>> Test was failing on multiple platforms mainly windows and linux and was
>> problemlisted for all platforms. Increased the delay from 200ms to 500 ms to
>> fetch the correct background color using robot. Now test passed for multiple
>> i
On Tue, 3 Sep 2024 06:08:34 GMT, Prasanta Sadhukhan
wrote:
> Secondary loop was added for JDK-8078269 not for JDK-8007563 so you need to
> check if test fail without Secondary loop without that fix and passes with
> the fix..
I tested without the fix for JDK-8078269 for different scenarion:
> We get a couple of warnings as errors on AIX because of unused variables or
> functions , for example :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10:
> error: unused variable 'exePath' [-Werror,-Wunused
On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken wrote:
>> We get a couple of warnings as errors on AIX because of unused variables or
>> functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
On Fri, 30 Aug 2024 04:57:56 GMT, Abhishek Kumar wrote:
>> `static final Map ICONS_MAP` is modified only in
>> `static` block. Then
>> [com.sun.java.swing.plaf.gtk.GTKStyle#get](https://github.com/kumarabhi006/jdk/blob/73f7a5f15dbba54a98f3916ff1190520ac07874d/src/java.desktop/share/classes/com/
On Tue, 3 Sep 2024 06:42:42 GMT, Julian Waters wrote:
>> At one stage we started using the idiom:
>>
>> (void) someFunc();
>>
>> to tell the compiler to not warn about the unused result. IIRC that stopped
>> working.
>
> Not entirely sure about clang, but casting to void to silence warnings sh
47 matches
Mail list logo
