Re: RFR: 8303904: [macos]Transparent Windows Paint Wrong (Opaque, Pixelated) w/o Volatile Buffering

2025-02-03 Thread Jeremy
On Tue, 4 Feb 2025 00:07:48 GMT, anass baya wrote: > The PR includes two fix : > 1 - The first fix targets proper rendering of the transparent image. > 2 - The second fix ensures the image is painted at the correct resolution to > avoid pixelation. src/java.desktop/macosx/classes/sun/java2d/me

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v10]

2025-02-03 Thread ScientificWare
On Mon, 9 Dec 2024 09:56:15 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK-

Re: RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v2]

2025-02-03 Thread Abhishek Kumar
On Mon, 3 Feb 2025 18:45:50 GMT, Alexey Ivanov wrote: >> Since it will never be tested on Windows XP machine, I thought it's not >> worth to mention. > > It just references the point where the feature was introduced. > > Currently supported versions of Java likely don't start on Windows XP any

Re: RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v2]

2025-02-03 Thread Abhishek Kumar
On Fri, 31 Jan 2025 20:40:27 GMT, Alexey Ivanov wrote: >> The `javax/swing/JButton/4796987/bug4796987.java` test strictly verifies if >> it's run on Windows XP, for this reason it never runs on modern versions of >> Windows. >> >> Since Windows XP is obsolete and visual styles cannot be disabl

Re: RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]

2025-02-03 Thread duke
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Added pageloader cancel before new page creation along with code >> restructuring. Moved all page loading calls inside synchronize to make it >> thread safe. >> >> Regards, >> Renjith. > > Renjith Kann

Re: RFR: 8303904: [macos]Transparent Windows Paint Wrong (Opaque, Pixelated) w/o Volatile Buffering

2025-02-03 Thread lawrence . andrews
On Tue, 4 Feb 2025 00:07:48 GMT, anass baya wrote: > The PR includes two fix : > 1 - The first fix targets proper rendering of the transparent image. > 2 - The second fix ensures the image is painted at the correct resolution to > avoid pixelation. test/jdk/javax/swing/JWindow/NonVolatileTrans

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v3]

2025-02-03 Thread Alisen Chung
On Mon, 3 Feb 2025 19:02:30 GMT, Damon Nguyen wrote: >> The test instructions say that disabled PopupMenus should not have shortcuts >> shown, but on MacOS, these shortcuts still appear. When checking native >> MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the >> test

RFR: 8303904: [macos]Transparent Windows Paint Wrong (Opaque, Pixelated) w/o Volatile Buffering

2025-02-03 Thread anass baya
8303904: [macos]Transparent Windows Paint Wrong (Opaque, Pixelated) w/o Volatile Buffering - Commit messages: - fix for pixelated images - Add test for pixelated images at high resolution - Test for Mac platfotm - Unit Test to Verify Window Transparency and Black Border Presence

Re: RFR: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen [v6]

2025-02-03 Thread Alisen Chung
On Fri, 31 Jan 2025 19:51:07 GMT, Alexey Ivanov wrote: > In macOS? Do you mean in macOS-specific code in JDK? > > ~If the code to clamp mouse coordinates has already been written, why are you > writing new code instead of re-using the existing code?~ Yes, I meant macOS-specific code in JDK. Th

Re: RFR: 8348600: Update PipeWire to 1.3.81

2025-02-03 Thread Alexander Zvegintsev
On Mon, 3 Feb 2025 18:50:41 GMT, Alexander Zvegintsev wrote: > This changeset updates the pipewire headers to the latest available version. > It contains the minimum set of required header files needed to build the JDK. > > The updated headers are a direct copy from the > https://gitlab.freede

RFR: 8348600: Update PipeWire to 1.3.81

2025-02-03 Thread Alexander Zvegintsev
This changeset updates the pipewire headers to the latest available version. It contains the minimum set of required header files needed to build the JDK. The updated headers are a direct copy from the https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/1.3.81 (except for the `\t` -> `

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v3]

2025-02-03 Thread Alexander Zvegintsev
On Mon, 3 Feb 2025 19:02:30 GMT, Damon Nguyen wrote: >> The test instructions say that disabled PopupMenus should not have shortcuts >> shown, but on MacOS, these shortcuts still appear. When checking native >> MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the >> test

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v2]

2025-02-03 Thread Damon Nguyen
On Mon, 3 Feb 2025 18:10:04 GMT, Abhishek Kumar wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > test/jdk/java/awt/PopupMenu/PopupMenuVisuals.java line 81: > >> 79: Menu sm = new Menu("S

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v2]

2025-02-03 Thread Damon Nguyen
On Mon, 3 Feb 2025 18:25:47 GMT, Alexander Zvegintsev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > test/jdk/java/awt/PopupMenu/PopupMenuVisuals.java line 49: > >> 47: If following

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v3]

2025-02-03 Thread Damon Nguyen
> The test instructions say that disabled PopupMenus should not have shortcuts > shown, but on MacOS, these shortcuts still appear. When checking native > MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the > test doesn't modify the popup's shortcuts other than adding the

Re: RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v2]

2025-02-03 Thread Alexey Ivanov
On Mon, 3 Feb 2025 18:07:38 GMT, Abhishek Kumar wrote: >> Why not? Visual styles were introduced in Windows XP. >> >> Even though the test was written when both Windows Vista and Windows 7 had >> already been released, it was limited to Windows XP only for some reason. > > Since it will never b

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v2]

2025-02-03 Thread Alexander Zvegintsev
On Mon, 3 Feb 2025 17:49:15 GMT, Damon Nguyen wrote: >> The test instructions say that disabled PopupMenus should not have shortcuts >> shown, but on MacOS, these shortcuts still appear. When checking native >> MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the >> test

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v2]

2025-02-03 Thread Abhishek Kumar
On Mon, 3 Feb 2025 17:49:15 GMT, Damon Nguyen wrote: >> The test instructions say that disabled PopupMenus should not have shortcuts >> shown, but on MacOS, these shortcuts still appear. When checking native >> MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the >> test

Re: RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v2]

2025-02-03 Thread Abhishek Kumar
On Mon, 3 Feb 2025 17:45:02 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/JButton/4796987/bug4796987.java line 30: >> >>> 28: * @requires (os.family == "windows") >>> 29: * @summary Verify JButton.setBorderPainted(false) removes border >>> 30: * for Windows visual styles (Windows XP

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v2]

2025-02-03 Thread Damon Nguyen
> The test instructions say that disabled PopupMenus should not have shortcuts > shown, but on MacOS, these shortcuts still appear. When checking native > MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the > test doesn't modify the popup's shortcuts other than adding the

Re: RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v2]

2025-02-03 Thread Damon Nguyen
On Mon, 3 Feb 2025 07:00:58 GMT, Abhishek Kumar wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > test/jdk/java/awt/PopupMenu/PopupMenuVisuals.java line 50: > >> 48: - Menu is disabled

Re: RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v2]

2025-02-03 Thread Alexey Ivanov
On Mon, 3 Feb 2025 06:38:28 GMT, Abhishek Kumar wrote: >> Alexey Ivanov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update the test summary >> - Remove the redundant button > > test/jdk/javax/swing/JButton/4796987/bug4796987.java

Re: RFR: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen [v11]

2025-02-03 Thread Alexander Zvegintsev
On Tue, 28 Jan 2025 23:21:26 GMT, Alisen Chung wrote: >> Currently on macOS when mouseMove is given an offscreen coordinate to move >> the mouse to, mouseMove will physically clamp to the edge of the screen, but >> if you try to grab the mouse location immediately after by using >> MouseInfo.g

Re: RFR: 8348830: LIBFONTMANAGER optimization is always HIGHEST

2025-02-03 Thread Matthias Baesken
On Fri, 31 Jan 2025 13:59:45 GMT, Julian Waters wrote: > Still, for some simple cases like e.g. BUILD_LIBSPLASHSCREEN changing the opt > level from LOW to SIZE is probably the best > thing to do after some more testing. The size optimization worked pretty well on most platforms , have to look

Integrated: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland

2025-02-03 Thread Alexander Zvegintsev
On Tue, 28 Jan 2025 11:28:27 GMT, Alexander Zvegintsev wrote: > Several TrayIcon tests are trying to click on the system tray icon with Robot > using XTest API. > > Basically we have the same kind of failures as before, e.g. > [JDK-8280990](https://bugs.openjdk.org/browse/JDK-8280990) >> the