Re: RFR: 8349932: PSPrinterJob sometimes generates unnecessary PostScript commands

2025-02-14 Thread Daniel Gredler
On Fri, 14 Feb 2025 20:41:02 GMT, Phil Race wrote: >> Trying to print text which is ignored (e.g. `\r` or `\n` or `\t`), or trying >> to print empty shapes generates PostScript graphics context setup commands >> which are not necessary. This can lead to unnecessarily large PostScript >> files,

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]

2025-02-14 Thread Brian Burkhalter
On Fri, 14 Feb 2025 21:41:24 GMT, Phil Race wrote: >> src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java >> line 1653: >> >>> 1651: if (exifMarkerSegment != null >>> 1652: && exifMarkerSegment.getNumThumbnails() == 1) { >>> 1653:

Re: RFR: 8349932: PSPrinterJob sometimes generates unnecessary PostScript commands [v2]

2025-02-14 Thread Daniel Gredler
> Trying to print text which is ignored (e.g. `\r` or `\n` or `\t`), or trying > to print empty shapes generates PostScript graphics context setup commands > which are not necessary. This can lead to unnecessarily large PostScript > files, and can complicate analysis / comparison of these files.

Re: Reading Frames from a GIF file

2025-02-14 Thread David Alayachew
Hey Jeremy, Yeah, that's not even close to the performance that Java is capable of. If you want to see something that is used in Production using only Java code, look at iCafe. The code is all open source, and I know it can do what you are trying to do because I did it too. It'll give you an idea

Re: RFR: 8348596: Update FreeType to 2.13.3 [v2]

2025-02-14 Thread Alisen Chung
> Upgrading freetype 3rd party tool to newest update Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: fix spacing - Changes: - all: https://git.openjdk.org/jdk/pull/23649/files - new: https://git.openjdk.org/jdk/pull/

Reading Frames from a GIF file

2025-02-14 Thread Jeremy Wood
I have a generic question for the group. I’m trying to implement a method resembling: public BufferedImage seek(File gifFile, int millis) Ideally I’d like to: 1. Not add a 3rd party jar to our class path 2. Not write a new file 3. Not load the entire gif file into memory as a byte array 4. Use

Re: Where to submit a bug to A11Y and AWT for people to take a look at?

2025-02-14 Thread Julian Waters
I can add the build log that lists all the errors found, if that helps. I think my main concern now is that unlike with HotSpot and the build system, I don't actually know that many people who review AWT and A11Y (Nor how to get the attention of said client maintainers) aside from Phil, who is very

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]

2025-02-14 Thread Brian Burkhalter
On Thu, 2 Jan 2025 06:49:19 GMT, Jeremy wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; thi

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]

2025-02-14 Thread Phil Race
On Fri, 14 Feb 2025 19:37:35 GMT, Brian Burkhalter wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8160327: fixing typo so `thumbnailPos` can be zero >> >> The `thumbnailLength` cannot be zero, but the position can

Re: RFR: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back [v4]

2025-02-14 Thread Harshitha Onkar
On Fri, 14 Feb 2025 20:20:27 GMT, Damon Nguyen wrote: >> Redo for JComboBox infinite scrolling issue. The issue is that when a >> scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB) >> while scrolling, when focused is returned to the scrolling application, the >> JComboBox

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]

2025-02-14 Thread Brian Burkhalter
On Thu, 2 Jan 2025 06:49:19 GMT, Jeremy wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; thi

RFR: 8348596: Update FreeType to 2.13.3

2025-02-14 Thread Alisen Chung
Upgrading freetype 3rd party tool to newest update - Commit messages: - freetype upgrade Changes: https://git.openjdk.org/jdk/pull/23649/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23649&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348596 Stats: 3813 lines i

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters

2025-02-14 Thread Daniel Gredler
On Fri, 14 Feb 2025 00:04:29 GMT, Phil Race wrote: >> When a string contains zero-width characters, `LineBreakMeasurer` calculates >> line breaks incorrectly. >> >> The root cause appears to be that `LineBreakMeasurer` eventually calls into >> `StandardGlyphVector.getGlyphInfo()`, which derive

Re: RFR: 8349932: PSPrinterJob sometimes generates unnecessary PostScript commands

2025-02-14 Thread Phil Race
On Wed, 12 Feb 2025 19:32:31 GMT, Daniel Gredler wrote: > Trying to print text which is ignored (e.g. `\r` or `\n` or `\t`), or trying > to print empty shapes generates PostScript graphics context setup commands > which are not necessary. This can lead to unnecessarily large PostScript > files

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters [v2]

2025-02-14 Thread Daniel Gredler
> When a string contains zero-width characters, `LineBreakMeasurer` calculates > line breaks incorrectly. > > The root cause appears to be that `LineBreakMeasurer` eventually calls into > `StandardGlyphVector.getGlyphInfo()`, which derives the glyph advances from > the glyph IDs. However, HarfB

Re: RFR: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back [v4]

2025-02-14 Thread Damon Nguyen
> Redo for JComboBox infinite scrolling issue. The issue is that when a > scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB) while > scrolling, when focused is returned to the scrolling application, the > JComboBox will still be scrolling even though nothing it being clicked

Re: RFR: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back [v4]

2025-02-14 Thread Damon Nguyen
On Fri, 14 Feb 2025 19:35:56 GMT, Harshitha Onkar wrote: >> Tested this solution locally and in CI. Seems to work well. Clientlibs >> passes and the updated, automatic test also passes on all related platforms. >> Updated the PR. Thanks for providing the automated test and suggested change. > >

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]

2025-02-14 Thread Brian Burkhalter
On Thu, 2 Jan 2025 06:49:19 GMT, Jeremy wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; thi

Re: RFR: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back [v3]

2025-02-14 Thread Harshitha Onkar
On Tue, 11 Feb 2025 19:10:55 GMT, Damon Nguyen wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java >> line 1620: >> >>> 1618: do { >>> 1619: // If application isn't in focus, stop the timer >>> 1620: if (focusOwner ==

Re: RFR: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back [v3]

2025-02-14 Thread Harshitha Onkar
On Tue, 11 Feb 2025 19:10:55 GMT, Damon Nguyen wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java >> line 1620: >> >>> 1618: do { >>> 1619: // If application isn't in focus, stop the timer >>> 1620: if (focusOwner ==

Re: RFR: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back [v3]

2025-02-14 Thread Harshitha Onkar
On Tue, 11 Feb 2025 19:16:36 GMT, Damon Nguyen wrote: >> Redo for JComboBox infinite scrolling issue. The issue is that when a >> scrollbar is clicked and held, if the user switches focus (ex: ALT+TAB) >> while scrolling, when focused is returned to the scrolling application, the >> JComboBox

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]

2025-02-14 Thread Brian Burkhalter
On Thu, 2 Jan 2025 06:49:19 GMT, Jeremy wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; thi

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]

2025-02-14 Thread Brian Burkhalter
On Thu, 2 Jan 2025 06:49:19 GMT, Jeremy wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; thi

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v2]

2025-02-14 Thread Brian Burkhalter
On Thu, 13 Feb 2025 20:50:07 GMT, Phil Race wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8160327: fixing typo so `thumbnailPos` can be zero >> >> The `thumbnailLength` cannot be zero, but the position can be. > >

Re: RFR: 8349751: AIX build failure after upgrade pipewire to 1.3.81 [v4]

2025-02-14 Thread Martin Doerr
On Fri, 14 Feb 2025 04:52:31 GMT, Phil Race wrote: >> Alexander Zvegintsev has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains seven commits: >> >> - Merge master >> - move fix to spa/utils/endian.h >> - merge "if defined" >> - 83

Re: RFR: 8349351 : Combine Screen Inset Tests into a Single File [v2]

2025-02-14 Thread Alexey Ivanov
On Sun, 9 Feb 2025 19:56:48 GMT, anass baya wrote: >> While working on [JDK-6899304](https://bugs.openjdk.org/browse/JDK-6899304), >> we discovered that there are two tests meant to perform the same task. >> >> The first test is located at >> test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest

Integrated: 8349351 : Combine Screen Inset Tests into a Single File

2025-02-14 Thread anass baya
On Tue, 4 Feb 2025 20:26:45 GMT, anass baya wrote: > While working on [JDK-6899304](https://bugs.openjdk.org/browse/JDK-6899304), > we discovered that there are two tests meant to perform the same task. > > The first test is located at > test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest/Mult

Re: RFR: 8349351 : Combine Screen Inset Tests into a Single File [v2]

2025-02-14 Thread duke
On Sun, 9 Feb 2025 19:56:48 GMT, anass baya wrote: >> While working on [JDK-6899304](https://bugs.openjdk.org/browse/JDK-6899304), >> we discovered that there are two tests meant to perform the same task. >> >> The first test is located at >> test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest

Integrated: 8349751: AIX build failure after upgrade pipewire to 1.3.81

2025-02-14 Thread Alexander Zvegintsev
On Mon, 10 Feb 2025 19:07:49 GMT, Alexander Zvegintsev wrote: > Filed as a separate issue to keep the #23426 clean. > > Fix is the same as in the > `src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` part > of the [JDK-8309703](https://bugs.openjdk.org/browse/JDK-8309703)

Re: RFR: 8349751: AIX build failure after upgrade pipewire to 1.3.81 [v4]

2025-02-14 Thread Martin Doerr
On Thu, 13 Feb 2025 11:55:53 GMT, Alexander Zvegintsev wrote: >> Filed as a separate issue to keep the #23426 clean. >> >> Fix is the same as in the >> `src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` >> part of the [JDK-8309703](https://bugs.openjdk.org/browse/JDK-830