On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by G
> JPEG segments can only be 65535-bytes long. (The marker length is expressed
> as 2 bytes.) The problem in this ticket is that we were writing more than
> 65535 bytes to a segment, which later caused parsing errors when we tried to
> read the file back.
>
> This includes 2 changes:
>
> 1. We
> JPEG segments can only be 65535-bytes long. (The marker length is expressed
> as 2 bytes.) The problem in this ticket is that we were writing more than
> 65535 bytes to a segment, which later caused parsing errors when we tried to
> read the file back.
>
> This includes 2 changes:
>
> 1. We
On Fri, 7 Mar 2025 05:19:54 GMT, Tejesh R wrote:
>> Jeremy Wood has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8351110: code cleanup
>>
>> This is in response to:
>> https://github.com/openjdk/jdk/pull/23920#discussion_r198446559
On Wed, 5 Mar 2025 18:29:49 GMT, Jeremy Wood wrote:
> JPEG segments can only be 65535-bytes long. (The marker length is expressed
> as 2 bytes.) The problem in this ticket is that we were writing more than
> 65535 bytes to a segment, which later caused parsing errors when we tried to
> read th
On Wed, 5 Mar 2025 03:13:32 GMT, Prasanta Sadhukhan
wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
>> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
>> drawing the radiobutton alongside icon.
>> If icon is not there, the radio
On Thu, 6 Mar 2025 21:23:26 GMT, Phil Race wrote:
>If an app got a profile 'from some place', it probably should not be trying to
>change it,
But this is not always possible. For example, a buffered image has a color
model that references a color space and a color profile. To modify something
On Fri, 21 Feb 2025 21:13:16 GMT, Daniel Gredler wrote:
>> When a string contains zero-width characters, `LineBreakMeasurer` calculates
>> line breaks incorrectly.
>>
>> The root cause appears to be that `LineBreakMeasurer` eventually calls into
>> `StandardGlyphVector.getGlyphInfo()`, which d
On Tue, 25 Feb 2025 20:00:18 GMT, Alisen Chung wrote:
> upgrading third party library to newest version
This pull request has now been integrated.
Changeset: a23fb0af
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/a23fb0af65f491ef655ba114fcc8032a09a55213
Stats: 471
> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile
> API.
>
> Test passes on Linux amd64 so far:
>
> TIME=`date +%s`;
> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport;
> jtreg -a -ignore:quiet -w:test.${TIME}/jdk/JTwork
> -r:test.${TIME}/jdk/JTreport
> -j
On Thu, 6 Mar 2025 15:56:43 GMT, Magnus Ihse Bursie wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done
On Fri, 27 Dec 2024 11:05:30 GMT, GennadiyKrivoshein wrote:
>> This update allows users to print with grayscale using color printers.
>> Actually, it is not possible to use the "Monochrome" option from the "Color
>> Appearance" panel. Also Chromaticity.MONOCHROME can't be used to print
>> grays
On Mon, 17 Feb 2025 14:06:53 GMT, Daniel Gredler wrote:
> On other platforms like Windows and Linux, the `\n`, `\r` and `\t` characters
> are ignored when drawing text to a `Graphics2D` object. On macOS this is not
> currently the case.
>
> See, for example, `CMap.getControlCodeGlyph(int, bool
On Fri, 21 Feb 2025 21:13:16 GMT, Daniel Gredler wrote:
>> When a string contains zero-width characters, `LineBreakMeasurer` calculates
>> line breaks incorrectly.
>>
>> The root cause appears to be that `LineBreakMeasurer` eventually calls into
>> `StandardGlyphVector.getGlyphInfo()`, which d
On Thu, 6 Mar 2025 20:17:13 GMT, Sergey Bylokhov wrote:
>
> I guess the most interesting changes for us are related to pre-multiplied
> alpha. And it would be good to check what "Change computation of profile ID"
> means.
I think neither is a big deal.
The first sounds to be about test cover
On Thu, 6 Mar 2025 20:30:42 GMT, Sergey Bylokhov wrote:
> I'm just not sure how this should be handled from the application's point of
> view. The app may obtain a profile from some place and use it for some images
> or pixels. Then, if the app wants to tweak the rendering intent for some
> re
On Thu, 6 Mar 2025 20:11:15 GMT, Alisen Chung wrote:
>> upgrading third party library to newest version
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyright year
Marked as reviewed by dnguyen (Committer).
On Thu, 6 Mar 2025 00:11:26 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8319192
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java line
> 38:
>
>> 36: import java.io.
On Wed, 5 Mar 2025 21:20:11 GMT, Harshitha Onkar wrote:
>>> can we just ignore it instead and did not use suspicion
>>> IllegalArgumentException for correct parameters? or change the type to
>>> something unrelated to "..ArgumentException"?
>>
>> This has been [my
>> suggestion](https://githu
On Thu, 6 Mar 2025 20:11:15 GMT, Alisen Chung wrote:
>> upgrading third party library to newest version
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyright year
Marked as reviewed by honkar (Reviewer).
--
On Wed, 5 Mar 2025 21:32:39 GMT, Phil Race wrote:
>Yes, readObject(..) and readResolve(..) will return the singleton
We do not specify anywhere in the API that we use singletons; that is an
implementation detail.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussi
On Thu, 6 Mar 2025 20:11:15 GMT, Alisen Chung wrote:
>> upgrading third party library to newest version
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyright year
Marked as reviewed by prr (Reviewer).
-
On Thu, 6 Mar 2025 00:27:30 GMT, Alexander Zuev wrote:
>And your point is? If someone made a bad choice in the past i do not think
>repeating it is beneficial.
That is not a bad choice; this is how it should be implemented. Most, if not
all, of those code paths are security-related. You can co
> upgrading third party library to newest version
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23784/files
- new: https://git.openjdk.org/jd
On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by G
On Wed, 5 Mar 2025 03:13:32 GMT, Prasanta Sadhukhan
wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
>> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
>> drawing the radiobutton alongside icon.
>> If icon is not there, the radio
On Thu, 6 Mar 2025 14:15:38 GMT, Erik Joelsson wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Gr
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Thu, 6 Mar 2025 14:21:08 GMT, Erik Joelsson wrote:
> What is the intended way of using this? Do you run make with
> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the specific
> way of linking to pthread?
This is in preparation of the upcoming BSD port, which uses `-pthread
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Thu, 23 Jan 2025 09:23:52 GMT, Matthias Baesken wrote:
> In java2d coding there are a few overflows (those are shown when running
> jtreg tests with ubsan enabled binaries)
> jtreg test java/awt/Scrollbar/AquaLFScrollbarTest/ScrollBarBorderTest.java
> shows
>
> jdk/src/java.desktop/share/n
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Thu, 6 Mar 2025 12:46:25 GMT, David Holmes wrote:
> Abstracting this out seems reasonable to me, though I should say I thought we
> already used `-pthread` rather than `-lpthread`.
I noticed there were a few places that used `-pthread` by default. I left these
alone in this PR.
---
Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
possible to parameterize this for platforms that use different flags for
enabling posix threads.
This work is a continuation of the work done by Greg Lewis in [1], but
generalized for the full JDK, and set at the conf
On Wed, 5 Mar 2025 21:21:14 GMT, Phil Race wrote:
> So I think this points out that whilst ubsan findings might be an interesting
> data point, it isn't an automatic "go update the code".
I agree, the findings have to be checked and not always this leads to a source
change.
-
PR
35 matches
Mail list logo
