Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v21]

2025-03-11 Thread Prasanta Sadhukhan
> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is > shown without radiobutton in WIndowsLookAndFeel as there was no provision of > drawing the radiobutton alongside icon. > If icon is not there, the radiobutton is drawn. Added provision of drawing > the radiobutton win

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v10]

2025-03-11 Thread Brian Burkhalter
On Tue, 4 Mar 2025 03:41:10 GMT, Jeremy Wood wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time

Re: RFR: 8280818: Expand bug8033699.java to iterate over all LaFs

2025-03-11 Thread Damon Nguyen
On Mon, 10 Mar 2025 14:48:09 GMT, Rajat Mahajan wrote: > Added code to Iterates over all installed Look and Feel environments and > added related exception handling. > > Testing done. I also tested this and the test passes consistently on all LAFs. test/jdk/javax/swing/JRadioButton/8033699/bu

Re: RFR: 8280818: Expand bug8033699.java to iterate over all LaFs

2025-03-11 Thread Damon Nguyen
On Tue, 11 Mar 2025 21:15:55 GMT, Rajat Mahajan wrote: >> test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 1: >> >>> 1: /* >> >> Minor changes can be done >> 1. mainFrame = new JFrame("Bug 8033699 - `9` Tests for `Grouped / >> Non-Grouped` Radio Buttons"); >> 2. Non group can be

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v8]

2025-03-11 Thread Alexander Zuev
On Tue, 11 Mar 2025 14:48:12 GMT, GennadiyKrivoshein wrote: >> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use >> more that one print option. >> >> **Reason of the bug**: >> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two >> indexes for

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v8]

2025-03-11 Thread Phil Race
On Tue, 11 Mar 2025 14:48:12 GMT, GennadiyKrivoshein wrote: >> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use >> more that one print option. >> >> **Reason of the bug**: >> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two >> indexes for

Re: RFR: 8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError [v4]

2025-03-11 Thread Harshitha Onkar
On Wed, 5 Mar 2025 21:34:09 GMT, Alexander Zuev wrote: >> - Check that the calculated audio data size does not exceed available heap >> memory before committing to the rendering >> - Add a test case > > Alexander Zuev has updated the pull request incrementally with two additional > commits sinc

Re: RFR: 8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError [v4]

2025-03-11 Thread Harshitha Onkar
On Wed, 5 Mar 2025 21:34:09 GMT, Alexander Zuev wrote: >> - Check that the calculated audio data size does not exceed available heap >> memory before committing to the rendering >> - Add a test case > > Alexander Zuev has updated the pull request incrementally with two additional > commits sinc

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v6]

2025-03-11 Thread Jeremy Wood
> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were > opaque. > > In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier > and mistakenly indicated it *could* support a BufferedImage. But when the > actual BufferedImage arrived (which was transluce

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v17]

2025-03-11 Thread Harshitha Onkar
> Built-in Profiles are singleton objects and if the user happens to modify > this shared profile object via setData() then the modified version of the > profile is returned each time the same built-in profile is requested via > getInstance(). > > It is good to protect Built-in profiles from su

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v16]

2025-03-11 Thread Alexey Ivanov
On Tue, 11 Mar 2025 21:08:42 GMT, Harshitha Onkar wrote: >> Built-in Profiles are singleton objects and if the user happens to modify >> this shared profile object via setData() then the modified version of the >> profile is returned each time the same built-in profile is requested via >> getI

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v16]

2025-03-11 Thread Alexey Ivanov
On Tue, 11 Mar 2025 21:16:00 GMT, Harshitha Onkar wrote: >> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 126: >> >>> 124: /* >>> 125: * Deferral is only used for standard profiles. Enabling the >>> appropriate >>> 126: * access privileges is hand

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v16]

2025-03-11 Thread Harshitha Onkar
On Tue, 11 Mar 2025 21:11:16 GMT, Alexey Ivanov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> modifier order changed, added comment to BuiltInProfile > > src/java.desktop/share/classes/java/awt/color/ICC_Profi

Integrated: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error

2025-03-11 Thread Karm Michal Babacek
On Sun, 2 Mar 2025 00:50:30 GMT, Karm Michal Babacek wrote: > Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile > API. > > Test passes on Linux amd64 so far: > > TIME=`date +%s`; > mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; > jtreg -a -ignore:quiet -w

Re: RFR: 8280818: Expand bug8033699.java to iterate over all LaFs

2025-03-11 Thread Rajat Mahajan
On Tue, 11 Mar 2025 06:28:07 GMT, Abhishek Kumar wrote: >> Added code to Iterates over all installed Look and Feel environments and >> added related exception handling. >> >> Testing done. > > test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 1: > >> 1: /* > > Minor changes can b

Re: RFR: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error [v4]

2025-03-11 Thread Karm Michal Babacek
On Fri, 7 Mar 2025 12:38:08 GMT, Karm Michal Babacek wrote: >> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile >> API. >> >> Test passes on Linux amd64 so far: >> >> TIME=`date +%s`; >> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; >> jtreg -a -ignore:

Re: RFR: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error [v5]

2025-03-11 Thread Alexey Ivanov
On Tue, 11 Mar 2025 21:11:04 GMT, Karm Michal Babacek wrote: >> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile >> API. >> >> Test passes on Linux amd64 so far: >> >> TIME=`date +%s`; >> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; >> jtreg -a -ignore

Re: RFR: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error [v4]

2025-03-11 Thread duke
On Fri, 7 Mar 2025 12:38:08 GMT, Karm Michal Babacek wrote: >> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile >> API. >> >> Test passes on Linux amd64 so far: >> >> TIME=`date +%s`; >> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; >> jtreg -a -ignore:

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v15]

2025-03-11 Thread Harshitha Onkar
On Tue, 11 Mar 2025 19:42:12 GMT, Alexey Ivanov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review changes > > src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 116: > >> 114: * built

Re: RFR: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error [v5]

2025-03-11 Thread Karm Michal Babacek
> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile > API. > > Test passes on Linux amd64 so far: > > TIME=`date +%s`; > mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; > jtreg -a -ignore:quiet -w:test.${TIME}/jdk/JTwork > -r:test.${TIME}/jdk/JTreport > -j

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v16]

2025-03-11 Thread Alexey Ivanov
On Tue, 11 Mar 2025 21:08:42 GMT, Harshitha Onkar wrote: >> Built-in Profiles are singleton objects and if the user happens to modify >> this shared profile object via setData() then the modified version of the >> profile is returned each time the same built-in profile is requested via >> getI

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v2]

2025-03-11 Thread Jeremy Wood
> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were > opaque. > > In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier > and mistakenly indicated it *could* support a BufferedImage. But when the > actual BufferedImage arrived (which was transluce

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v16]

2025-03-11 Thread Harshitha Onkar
> Built-in Profiles are singleton objects and if the user happens to modify > this shared profile object via setData() then the modified version of the > profile is returned each time the same built-in profile is requested via > getInstance(). > > It is good to protect Built-in profiles from su

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v10]

2025-03-11 Thread Phil Race
On Mon, 10 Mar 2025 17:10:09 GMT, Brian Burkhalter wrote: >> Jeremy Wood has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8160327: adding "Reading Thumbnail Images" for Exif marker changes >> >> This is in response to: >> https://g

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v4]

2025-03-11 Thread Jeremy Wood
> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were > opaque. > > In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier > and mistakenly indicated it *could* support a BufferedImage. But when the > actual BufferedImage arrived (which was transluce

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v11]

2025-03-11 Thread Alexey Ivanov
On Mon, 10 Mar 2025 18:47:17 GMT, Phil Race wrote: >>>Since there is no way to check if a profile is built-in, making built-in >>>profiles read-only might be a better approach, similar to [java >>>properties](https://bugs.openjdk.org/browse/JDK-8066709). >> >> But it also has its own disadvant

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v3]

2025-03-11 Thread Jeremy Wood
On Mon, 10 Mar 2025 13:16:21 GMT, Alexey Ivanov wrote: >> Jeremy Wood has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - 8351108: adding empty line to bottom of file >> >>This is in response to: >>https://github.com/openjdk/j

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv

2025-03-11 Thread snake66
On Tue, 11 Mar 2025 19:35:45 GMT, Erik Joelsson wrote: >> Allows for future support for platforms that require different flags for >> libiconv support. >> >> Sponsored-by: The FreeBSD Foundation > > I think this looks ok, but please wait for Magnus to have a look too. @erikj79 Thanks for the r

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v15]

2025-03-11 Thread Alexey Ivanov
On Tue, 11 Mar 2025 17:47:53 GMT, Harshitha Onkar wrote: >> Built-in Profiles are singleton objects and if the user happens to modify >> this shared profile object via setData() then the modified version of the >> profile is returned each time the same built-in profile is requested via >> getI

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv

2025-03-11 Thread Erik Joelsson
On Tue, 11 Mar 2025 19:22:34 GMT, snake66 wrote: > Allows for future support for platforms that require different flags for > libiconv support. > > Sponsored-by: The FreeBSD Foundation I think this looks ok, but please wait for Magnus to have a look too. - Marked as reviewed by e

RFR: 8351323: Parameterize compiler and linker flags for iconv

2025-03-11 Thread snake66
Allows for future support for platforms that require different flags for libiconv support. Sponsored-by: The FreeBSD Foundation - Commit messages: - 8351323: Parameterize libiconv compiler and linker flags Changes: https://git.openjdk.org/jdk/pull/23995/files Webrev: https://web

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v20]

2025-03-11 Thread Prasanta Sadhukhan
> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is > shown without radiobutton in WIndowsLookAndFeel as there was no provision of > drawing the radiobutton alongside icon. > If icon is not there, the radiobutton is drawn. Added provision of drawing > the radiobutton win

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v4]

2025-03-11 Thread GennadiyKrivoshein
On Wed, 5 Mar 2025 22:07:05 GMT, Phil Race wrote: >> GennadiyKrivoshein has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains five >> additional commi

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v10]

2025-03-11 Thread Jeremy Wood
On Tue, 4 Mar 2025 03:41:10 GMT, Jeremy Wood wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v14]

2025-03-11 Thread Alexey Ivanov
On Tue, 11 Mar 2025 17:43:44 GMT, Harshitha Onkar wrote: > test controls the type of arguments (valid arguments) Yes. And the arguments can change, although it's very unlikely. The built-in check in the code is done before validating the arguments, therefore we know that whatever exception is

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v15]

2025-03-11 Thread Harshitha Onkar
> Built-in Profiles are singleton objects and if the user happens to modify > this shared profile object via setData() then the modified version of the > profile is returned each time the same built-in profile is requested via > getInstance(). > > It is good to protect Built-in profiles from su

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v14]

2025-03-11 Thread Harshitha Onkar
On Tue, 11 Mar 2025 13:31:46 GMT, Alexey Ivanov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> builtIn converted to transient, tests updated > > test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck.java line

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v13]

2025-03-11 Thread Harshitha Onkar
On Mon, 10 Mar 2025 23:33:39 GMT, Harshitha Onkar wrote: >> test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck.java line 71: >> >>> 69: } catch (IllegalArgumentException iae) { >>> 70: if (!iae.getMessage().equals(EXCEPTION_MSG)) { >>> 71: thr

Re: RFR: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen [v12]

2025-03-11 Thread Alisen Chung
> Currently on macOS when mouseMove is given an offscreen coordinate to move > the mouse to, mouseMove will physically clamp to the edge of the screen, but > if you try to grab the mouse location immediately after by using > MouseInfo.getPointerInfo().getLocation() you will get the value of the

Re: RFR: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error [v4]

2025-03-11 Thread Phil Race
On Fri, 7 Mar 2025 12:38:08 GMT, Karm Michal Babacek wrote: >> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile >> API. >> >> Test passes on Linux amd64 so far: >> >> TIME=`date +%s`; >> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; >> jtreg -a -ignore:

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v3]

2025-03-11 Thread Jeremy Wood
> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were > opaque. > > In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier > and mistakenly indicated it *could* support a BufferedImage. But when the > actual BufferedImage arrived (which was transluce

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v7]

2025-03-11 Thread GennadiyKrivoshein
> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use > more that one print option. > > **Reason of the bug**: > execCmd array uses one index per print flag, but 'OPTIONS' flag can use two > indexes for the options. > > **Fix description**: > make the size of the exec

Re: RFR: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error [v4]

2025-03-11 Thread Severin Gehwolf
On Fri, 7 Mar 2025 12:38:08 GMT, Karm Michal Babacek wrote: >> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile >> API. >> >> Test passes on Linux amd64 so far: >> >> TIME=`date +%s`; >> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; >> jtreg -a -ignore:

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v3]

2025-03-11 Thread Alexander Zvegintsev
On Mon, 10 Mar 2025 17:20:36 GMT, Jeremy Wood wrote: >> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were >> opaque. >> >> In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier >> and mistakenly indicated it *could* support a BufferedImage. But w

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v18]

2025-03-11 Thread Phil Race
On Wed, 5 Mar 2025 03:13:32 GMT, Prasanta Sadhukhan wrote: >> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is >> shown without radiobutton in WIndowsLookAndFeel as there was no provision of >> drawing the radiobutton alongside icon. >> If icon is not there, the radio

Integrated: 8160327: Support for thumbnails present in APP1 marker for JPEG

2025-03-11 Thread Jeremy Wood
On Wed, 1 Jan 2025 21:38:28 GMT, Jeremy Wood wrote: > This adds support for parsing thumbnails in an APP1 Exif marker. > > This builds on an unfinished proposal by Brian Burkhalter (around 2016). In > that previous work the only additional meta info he parsed was the image > creation time; thi

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters [v3]

2025-03-11 Thread Daniel Gredler
On Thu, 6 Mar 2025 22:32:40 GMT, Phil Race wrote: >> Daniel Gredler has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright year > > I just deleted a comment added to the wrong PR! @prrace Did you get a chance to submit that te

Integrated: JDK-8348597 : Update HarfBuzz to 10.4.0

2025-03-11 Thread Harshitha Onkar
On Tue, 4 Mar 2025 23:52:49 GMT, Harshitha Onkar wrote: > Harfbuzz upgraded to v10.4.0 > > File changes - > > **Newly added files** > > libharfbuzz/OT/Var/VARC/VARC.hh > libharfbuzz/OT/Var/VARC/coord-setter.hh > libharfbuzz/hb-decycler.hh > libharfbuzz/hb-geometry.hh > libharfbuzz/hb-ot-var-v

Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object

2025-03-11 Thread Daniel Gredler
On Mon, 17 Feb 2025 14:06:53 GMT, Daniel Gredler wrote: > On other platforms like Windows and Linux, the `\n`, `\r` and `\t` characters > are ignored when drawing text to a `Graphics2D` object. On macOS this is not > currently the case. > > See, for example, `CMap.getControlCodeGlyph(int, bool

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-11 Thread Magnus Ihse Bursie
On Thu, 6 Mar 2025 13:27:15 GMT, snake66 wrote: >> Abstracting this out seems reasonable to me, though I should say I thought >> we already used `-pthread` rather than `-lpthread`. >> >> Needs build team approval before integrating. > >> Abstracting this out seems reasonable to me, though I sho

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v5]

2025-03-11 Thread GennadiyKrivoshein
> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use > more that one print option. > > **Reason of the bug**: > execCmd array uses one index per print flag, but 'OPTIONS' flag can use two > indexes for the options. > > **Fix description**: > make the size of the exec

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v5]

2025-03-11 Thread Jeremy Wood
> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were > opaque. > > In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier > and mistakenly indicated it *could* support a BufferedImage. But when the > actual BufferedImage arrived (which was transluce

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v4]

2025-03-11 Thread Jeremy Wood
On Mon, 10 Mar 2025 19:28:24 GMT, Alexey Ivanov wrote: >> Jeremy Wood has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8351108: changing Error to Exception, adding javadoc >> >> This is partly in response to: >> https://github.com/

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel

2025-03-11 Thread Alexey Ivanov
On Tue, 4 Mar 2025 06:51:54 GMT, Jeremy Wood wrote: > Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were > opaque. > > In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier > and mistakenly indicated it *could* support a BufferedImage. But when th

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v4]

2025-03-11 Thread GennadiyKrivoshein
On Wed, 5 Mar 2025 22:05:51 GMT, Phil Race wrote: >> GennadiyKrivoshein has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains five >> additional commi

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-11 Thread duke
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Integrated: 8351322: Parameterize link option for pthreads

2025-03-11 Thread snake66
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote: > Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's > possible to parameterize this for platforms that use different flags for > enabling posix threads. > > This work is a continuation of the work done by Greg Lewis in

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v14]

2025-03-11 Thread Alexey Ivanov
On Mon, 10 Mar 2025 23:22:36 GMT, Harshitha Onkar wrote: >> Built-in Profiles are singleton objects and if the user happens to modify >> this shared profile object via setData() then the modified version of the >> profile is returned each time the same built-in profile is requested via >> getI

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v7]

2025-03-11 Thread GennadiyKrivoshein
On Mon, 10 Mar 2025 18:18:48 GMT, Phil Race wrote: >> GennadiyKrivoshein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> align UnixPrintJob with PSPrinterJob > > test/jdk/javax/print/UnixPrintJobOptionsTest.java line 131: > >> 129:

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v7]

2025-03-11 Thread GennadiyKrivoshein
On Mon, 10 Mar 2025 17:02:16 GMT, Phil Race wrote: >> GennadiyKrivoshein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> align UnixPrintJob with PSPrinterJob > > test/jdk/javax/print/UnixPrintJobOptionsTest.java line 50: > >> 48: * @bu

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v8]

2025-03-11 Thread GennadiyKrivoshein
> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use > more that one print option. > > **Reason of the bug**: > execCmd array uses one index per print flag, but 'OPTIONS' flag can use two > indexes for the options. > > **Fix description**: > make the size of the exec

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v5]

2025-03-11 Thread Alexey Ivanov
On Mon, 10 Mar 2025 20:38:45 GMT, Jeremy Wood wrote: >> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were >> opaque. >> >> In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier >> and mistakenly indicated it *could* support a BufferedImage. But w

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v5]

2025-03-11 Thread Alexey Ivanov
On Mon, 10 Mar 2025 20:38:45 GMT, Jeremy Wood wrote: >> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were >> opaque. >> >> In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier >> and mistakenly indicated it *could* support a BufferedImage. But w

Re: RFR: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error [v4]

2025-03-11 Thread Alexey Ivanov
On Fri, 7 Mar 2025 12:38:08 GMT, Karm Michal Babacek wrote: >> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile >> API. >> >> Test passes on Linux amd64 so far: >> >> TIME=`date +%s`; >> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; >> jtreg -a -ignore:

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters [v3]

2025-03-11 Thread duke
On Fri, 21 Feb 2025 21:13:16 GMT, Daniel Gredler wrote: >> When a string contains zero-width characters, `LineBreakMeasurer` calculates >> line breaks incorrectly. >> >> The root cause appears to be that `LineBreakMeasurer` eventually calls into >> `StandardGlyphVector.getGlyphInfo()`, which d

Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object

2025-03-11 Thread Daniel Gredler
On Mon, 10 Mar 2025 20:37:57 GMT, Harshitha Onkar wrote: >> Good news: it looks like it was possible to resolve the `0x` conflict on >> the HarfBuzz side by adjusting the HarfBuzz internal representation of AAT >> deleted glyphs. Amazingly quick turnaround from @behdad! I think we'll want

Integrated: 8286204: [Accessibility, macOS, VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS

2025-03-11 Thread Abhishek Kumar
On Fri, 28 Feb 2025 11:22:58 GMT, Abhishek Kumar wrote: > VoiceOver is unable to announce the correct value for spinner. For JSpinner > with maximum value of more than 10, VO announce 10 as 1, 20 as 2 and so on. > Probable reason is the "ACCESSIBLE_TEXT_PROPERTY" fired by accessible > JTextCom